From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by mx.groups.io with SMTP id smtpd.web09.2.1576776062979647642 for ; Thu, 19 Dec 2019 09:21:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=A96HxMgv; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.208.66, mailfrom: pete@akeo.ie) Received: by mail-ed1-f66.google.com with SMTP id i16so5644297edr.5 for ; Thu, 19 Dec 2019 09:21:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=25al/b0qhYNH6HBakBS9i1Wb5P7EwP0IM1QMiQvUa94=; b=A96HxMgv+6ltsMHFFKaEkNmcys1sxEFQXF410iD57bkyVPRmx4wcRJLgtGf/3QfJki Wbd4eQyyxy8LmAZxvve3ygaZFteM3SpNdOQZeuwsbaDjUdXUnWY9/Fc257P+WCsqDiBs zMXKnchLMb59nIt+4qKUQtwizBE1Vt/y1Kyftke5IC1Cw+obl0eURDIppRoVXqJZ33rX 9gmrhl+l9W8+PlltceqntijBjEnkXeUuXS5df4fV1qZjwAMFJLsmeCTel48xnztAbCnU rhCdRx1GNUNzRs6yCag+qMSm91O5PeXGBJj3Ujfa3Ko0JCeOICtGG83dLNm4G2/3Mljn YRaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=25al/b0qhYNH6HBakBS9i1Wb5P7EwP0IM1QMiQvUa94=; b=FHcLSwAJWhgQcd9noh59dTvqyE5TkPFraZShldaF0vKPrBBiks6WBuXft1f8TvRPYa kydwg4yLjw4H4vOOjU9K6uf273VgPuBKiVynA/AgIVUAdkvTfkaIdSjIBlSSqI8kltti g0nB3RtR4yxdn3SX+SI2bha+jF0sVWTwOT3io5Cnm0an3t/3zpBM13tNxcuQ0+SJxg1g mbloODrMDlNNh2MdrOvLWUHKxxoBn/0ghUUK3LPqbKsZ416loSnYrygDscr0VQBBdSTl YjJ5fmQi2XJxAZQFDNFuXxM5+nKy+DK+xlejM8qCJ02iVe5NJxKlYF+ndmI0x0K4icmS jYsg== X-Gm-Message-State: APjAAAXvabInk5+uRSMIGNrrWQLL4a/nDB6AeCvZCcL8U1FrqbMTLnjY AXOHA3nJwr7qWgrjTlnAnLq1jQ== X-Google-Smtp-Source: APXvYqwDx42PUqXWtDZnYkBi2NcNC+/rgrFfwrSX8VmYL9WvaQbKeUbSlWhsW3suV9ycvacG+oSAwA== X-Received: by 2002:a17:906:23e2:: with SMTP id j2mr10759984ejg.257.1576776061297; Thu, 19 Dec 2019 09:21:01 -0800 (PST) Return-Path: Received: from [10.0.0.122] ([84.203.77.210]) by smtp.googlemail.com with ESMTPSA id f3sm540141edw.80.2019.12.19.09.20.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Dec 2019 09:20:57 -0800 (PST) Subject: Re: [edk2-platforms][PATCH v2 0/7] Platform/RPi4: ACPI improvements To: Ard Biesheuvel Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20191219121434.2856-1-pete@akeo.ie> From: "Pete Batard" Message-ID: <37b90619-354a-802b-e589-8cea7b11902c@akeo.ie> Date: Thu, 19 Dec 2019 17:20:55 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2019.12.19 16:55, Ard Biesheuvel wrote: > On Thu, 19 Dec 2019 at 14:14, Pete Batard wrote: >> >> Changes from v1 (https://edk2.groups.io/g/devel/message/52342 - 52348): >> * Add PL011 and miniUART constants in Silicon/.../Bcm2836.h and use >> those in the SPCR and DBG2 tables >> * Use default values in FADT wherever possible >> * Drop MCFG table >> * Improve computation of MMIO window in XHCI table >> * Improve/clarify macro definitions in XHCI table >> * Fix a typo in one of the new sections from the Readme >> >> Andrei Warkentin (1): >> Platform/RPi4: Add XHCI ACPI table >> >> Ard Biesheuvel (1): >> Platform/RPi4: Add ACPI basic mode build option >> >> Pete Batard (5): >> Silicon/Bcm283x: Add UART constants for PL011 and miniUART >> Platform/RPi4: Clean up ACPI definitions >> Platform/RPi4: Improve FADT ACPI table generation >> Platform/RPi4: Improve SPCR and DBG2 ACPI table generation >> Platform/RPi4: Add switch to select between PL011 and miniUART >> > > For the series > Reviewed-by: Ard Biesheuvel > > Pushed as 8187c6f35035..e9395c53ba2c Awesome! Can I ask for someone to please push https://edk2.groups.io/g/devel/topic/68154411#52131 as well, since it's been reviewed? This may become quite relevant for people playing with DEBUG versions of the Pi 4 firmware... Thanks, /Pete > > Thanks all > > >> Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf | 3 + >> Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c | 8 ++ >> Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.h | 12 +- >> Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf | 8 +- >> Platform/RaspberryPi/RPi4/AcpiTables/Csrt.aslc | 42 +++--- >> Platform/RaspberryPi/RPi4/AcpiTables/Dbg2.aslc | 105 +++++++++++++-- >> Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl | 1 + >> Platform/RaspberryPi/RPi4/AcpiTables/Fadt.aslc | 99 ++++++++++---- >> Platform/RaspberryPi/RPi4/AcpiTables/Gtdt.aslc | 30 ++--- >> Platform/RaspberryPi/RPi4/AcpiTables/Madt.aslc | 11 +- >> Platform/RaspberryPi/RPi4/AcpiTables/Pep.asl | 4 +- >> Platform/RaspberryPi/RPi4/AcpiTables/Pep.c | 6 +- >> Platform/RaspberryPi/RPi4/AcpiTables/Pep.h | 8 +- >> Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl | 48 ------- >> Platform/RaspberryPi/RPi4/AcpiTables/Spcr.aslc | 96 ++++++++++++++ >> Platform/RaspberryPi/RPi4/AcpiTables/Uart.asl | 6 +- >> Platform/RaspberryPi/RPi4/AcpiTables/Xhci.asl | 137 ++++++++++++++++++++ >> Platform/RaspberryPi/RPi4/RPi4.dsc | 29 +++++ >> Platform/RaspberryPi/RPi4/RPi4.fdf | 7 + >> Platform/RaspberryPi/RPi4/Readme.md | 52 ++++++-- >> Platform/RaspberryPi/RaspberryPi.dec | 3 + >> Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h | 17 ++- >> 22 files changed, 570 insertions(+), 162 deletions(-) >> delete mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl >> create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.aslc >> create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Xhci.asl >> >> -- >> 2.21.0.windows.1 >>