* [PATCH v2 0/1] OvmfPkg/XenPvBlkDxe: add return value if allocting fail
@ 2020-11-24 2:06 wenyi,xie
2020-11-24 2:06 ` [PATCH EDK2 v2 1/1] " wenyi,xie
0 siblings, 1 reply; 5+ messages in thread
From: wenyi,xie @ 2020-11-24 2:06 UTC (permalink / raw)
To: devel, jordan.l.justen, lersek, ard.biesheuvel, anthony.perard,
julien
Cc: songdongkuang, xiewenyi2
Main Changes since v1 :
Returning EFI_OUT_OF_RESOURCES if pool allocting fail.
Wenyi Xie (1):
OvmfPkg/XenPvBlkDxe: add return value if allocting fail
OvmfPkg/XenPvBlkDxe/BlockFront.c | 4 ++++
1 file changed, 4 insertions(+)
--
2.20.1.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH EDK2 v2 1/1] OvmfPkg/XenPvBlkDxe: add return value if allocting fail
2020-11-24 2:06 [PATCH v2 0/1] OvmfPkg/XenPvBlkDxe: add return value if allocting fail wenyi,xie
@ 2020-11-24 2:06 ` wenyi,xie
2020-11-24 9:16 ` Laszlo Ersek
0 siblings, 1 reply; 5+ messages in thread
From: wenyi,xie @ 2020-11-24 2:06 UTC (permalink / raw)
To: devel, jordan.l.justen, lersek, ard.biesheuvel, anthony.perard,
julien
Cc: songdongkuang, xiewenyi2
return EFI_OUT_OF_RESOURCES if pool allocating fail.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Julien Grall <julien@xen.org>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
OvmfPkg/XenPvBlkDxe/BlockFront.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/OvmfPkg/XenPvBlkDxe/BlockFront.c b/OvmfPkg/XenPvBlkDxe/BlockFront.c
index 122a6baed25a..32d70c36cef2 100644
--- a/OvmfPkg/XenPvBlkDxe/BlockFront.c
+++ b/OvmfPkg/XenPvBlkDxe/BlockFront.c
@@ -155,6 +155,10 @@ XenPvBlockFrontInitialization (
ASSERT (NodeName != NULL);
Dev = AllocateZeroPool (sizeof (XEN_BLOCK_FRONT_DEVICE));
+ if (Dev == NULL) {
+ return EFI_OUT_OF_RESOURCES;
+ }
+
Dev->Signature = XEN_BLOCK_FRONT_SIGNATURE;
Dev->NodeName = NodeName;
Dev->XenBusIo = XenBusIo;
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH EDK2 v2 1/1] OvmfPkg/XenPvBlkDxe: add return value if allocting fail
2020-11-24 2:06 ` [PATCH EDK2 v2 1/1] " wenyi,xie
@ 2020-11-24 9:16 ` Laszlo Ersek
2020-11-24 9:19 ` wenyi,xie
0 siblings, 1 reply; 5+ messages in thread
From: Laszlo Ersek @ 2020-11-24 9:16 UTC (permalink / raw)
To: Wenyi Xie, devel, jordan.l.justen, ard.biesheuvel, anthony.perard,
julien
Cc: songdongkuang
On 11/24/20 03:06, Wenyi Xie wrote:
> return EFI_OUT_OF_RESOURCES if pool allocating fail.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
> OvmfPkg/XenPvBlkDxe/BlockFront.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/OvmfPkg/XenPvBlkDxe/BlockFront.c b/OvmfPkg/XenPvBlkDxe/BlockFront.c
> index 122a6baed25a..32d70c36cef2 100644
> --- a/OvmfPkg/XenPvBlkDxe/BlockFront.c
> +++ b/OvmfPkg/XenPvBlkDxe/BlockFront.c
> @@ -155,6 +155,10 @@ XenPvBlockFrontInitialization (
> ASSERT (NodeName != NULL);
>
> Dev = AllocateZeroPool (sizeof (XEN_BLOCK_FRONT_DEVICE));
> + if (Dev == NULL) {
> + return EFI_OUT_OF_RESOURCES;
> + }
> +
> Dev->Signature = XEN_BLOCK_FRONT_SIGNATURE;
> Dev->NodeName = NodeName;
> Dev->XenBusIo = XenBusIo;
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Unless it's urgent for you, I'd like to merge this after
edk2-stable202011. It's a bugfix alright, but the issue seems to have
existed for a long time, with presumably no symptoms for most users.
Thanks
Laszlo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH EDK2 v2 1/1] OvmfPkg/XenPvBlkDxe: add return value if allocting fail
2020-11-24 9:16 ` Laszlo Ersek
@ 2020-11-24 9:19 ` wenyi,xie
2020-11-27 17:57 ` [edk2-devel] " Laszlo Ersek
0 siblings, 1 reply; 5+ messages in thread
From: wenyi,xie @ 2020-11-24 9:19 UTC (permalink / raw)
To: Laszlo Ersek, devel, jordan.l.justen, ard.biesheuvel,
anthony.perard, julien
Cc: songdongkuang
It's OK to me.
Thanks
Wenyi
On 2020/11/24 17:16, Laszlo Ersek wrote:
> On 11/24/20 03:06, Wenyi Xie wrote:
>> return EFI_OUT_OF_RESOURCES if pool allocating fail.
>>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Anthony Perard <anthony.perard@citrix.com>
>> Cc: Julien Grall <julien@xen.org>
>> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
>> ---
>> OvmfPkg/XenPvBlkDxe/BlockFront.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/OvmfPkg/XenPvBlkDxe/BlockFront.c b/OvmfPkg/XenPvBlkDxe/BlockFront.c
>> index 122a6baed25a..32d70c36cef2 100644
>> --- a/OvmfPkg/XenPvBlkDxe/BlockFront.c
>> +++ b/OvmfPkg/XenPvBlkDxe/BlockFront.c
>> @@ -155,6 +155,10 @@ XenPvBlockFrontInitialization (
>> ASSERT (NodeName != NULL);
>>
>> Dev = AllocateZeroPool (sizeof (XEN_BLOCK_FRONT_DEVICE));
>> + if (Dev == NULL) {
>> + return EFI_OUT_OF_RESOURCES;
>> + }
>> +
>> Dev->Signature = XEN_BLOCK_FRONT_SIGNATURE;
>> Dev->NodeName = NodeName;
>> Dev->XenBusIo = XenBusIo;
>>
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> Unless it's urgent for you, I'd like to merge this after
> edk2-stable202011. It's a bugfix alright, but the issue seems to have
> existed for a long time, with presumably no symptoms for most users.
>
> Thanks
> Laszlo
>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH EDK2 v2 1/1] OvmfPkg/XenPvBlkDxe: add return value if allocting fail
2020-11-24 9:19 ` wenyi,xie
@ 2020-11-27 17:57 ` Laszlo Ersek
0 siblings, 0 replies; 5+ messages in thread
From: Laszlo Ersek @ 2020-11-27 17:57 UTC (permalink / raw)
To: devel, xiewenyi2, jordan.l.justen, ard.biesheuvel, anthony.perard,
julien
Cc: songdongkuang
On 11/24/20 10:19, wenyi,xie via groups.io wrote:
> It's OK to me.
>
> Thanks
> Wenyi
Merged as commit f69a2b9a4202, via
<https://github.com/tianocore/edk2/pull/1151>.
Thanks
Laszlo
> On 2020/11/24 17:16, Laszlo Ersek wrote:
>> On 11/24/20 03:06, Wenyi Xie wrote:
>>> return EFI_OUT_OF_RESOURCES if pool allocating fail.
>>>
>>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>> Cc: Anthony Perard <anthony.perard@citrix.com>
>>> Cc: Julien Grall <julien@xen.org>
>>> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
>>> ---
>>> OvmfPkg/XenPvBlkDxe/BlockFront.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/OvmfPkg/XenPvBlkDxe/BlockFront.c b/OvmfPkg/XenPvBlkDxe/BlockFront.c
>>> index 122a6baed25a..32d70c36cef2 100644
>>> --- a/OvmfPkg/XenPvBlkDxe/BlockFront.c
>>> +++ b/OvmfPkg/XenPvBlkDxe/BlockFront.c
>>> @@ -155,6 +155,10 @@ XenPvBlockFrontInitialization (
>>> ASSERT (NodeName != NULL);
>>>
>>> Dev = AllocateZeroPool (sizeof (XEN_BLOCK_FRONT_DEVICE));
>>> + if (Dev == NULL) {
>>> + return EFI_OUT_OF_RESOURCES;
>>> + }
>>> +
>>> Dev->Signature = XEN_BLOCK_FRONT_SIGNATURE;
>>> Dev->NodeName = NodeName;
>>> Dev->XenBusIo = XenBusIo;
>>>
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>
>> Unless it's urgent for you, I'd like to merge this after
>> edk2-stable202011. It's a bugfix alright, but the issue seems to have
>> existed for a long time, with presumably no symptoms for most users.
>>
>> Thanks
>> Laszlo
>>
>> .
>>
>
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-27 17:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-24 2:06 [PATCH v2 0/1] OvmfPkg/XenPvBlkDxe: add return value if allocting fail wenyi,xie
2020-11-24 2:06 ` [PATCH EDK2 v2 1/1] " wenyi,xie
2020-11-24 9:16 ` Laszlo Ersek
2020-11-24 9:19 ` wenyi,xie
2020-11-27 17:57 ` [edk2-devel] " Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox