From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61])
 by mx.groups.io with SMTP id smtpd.web09.217.1582675542511543422
 for <devel@edk2.groups.io>;
 Tue, 25 Feb 2020 16:05:42 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QUkPUcXr;
 spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1582675541;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=40gFgh53ordIpsPTh2Fj2LP0LLZuk+XhumYBjRgH2Do=;
	b=QUkPUcXrzVbKq++JJI0BpEJr5P9OZS/SMFxLv9kYF4601nZC0PwB46pVJoqT/J+AxS6KzC
	49SvZLCQ3/03DWrQpR1C7IWos0Oz6QVMwmbP3i1+wuud+QJtxGmOfVPmGkdrgA9hmV7hTe
	eU1oFLhzUxaUJYR3hLP7GMw+1sBlBF4=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-294-hE-agZumMKmZmqZ0BWFThA-1; Tue, 25 Feb 2020 19:05:40 -0500
X-MC-Unique: hE-agZumMKmZmqZ0BWFThA-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F218D800D5C;
	Wed, 26 Feb 2020 00:05:38 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-104.ams2.redhat.com [10.36.117.104])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 4C5EE5C21B;
	Wed, 26 Feb 2020 00:05:32 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v2 2/5] ArmVirtPkg/PlatformPeiLib: make PcdLib dependency explicit in .INF
To: devel@edk2.groups.io, ard.biesheuvel@linaro.org
Cc: eric.auger@redhat.com, philmd@redhat.com, marcandre.lureau@redhat.com,
 stefanb@linux.ibm.com, leif@nuviainc.com
References: <20200225104449.22453-1-ard.biesheuvel@linaro.org>
 <20200225104449.22453-3-ard.biesheuvel@linaro.org>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <37d70b53-6f93-e124-d359-3d61ca997ea0@redhat.com>
Date: Wed, 26 Feb 2020 01:05:31 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200225104449.22453-3-ard.biesheuvel@linaro.org>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 02/25/20 11:44, Ard Biesheuvel wrote:
> We currently include PcdLib.h in PlatformPeiLib, without declaring
> this dependency in its .INF description. Since all the PCDs we use
> resolve to fixed type in practice, this does not really matter at
> the moment, but since we will be adding dynamic PCD references in
> a subsequent patch, let's make the PcdLib dependency explicit, so
> that its dispatch is guaranteed to be ordered correctly with respect
> to the provider of the dynamic PCD PPI.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.inf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.inf b/ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.inf
> index 46db117ac28e..5428040f121d 100644
> --- a/ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.inf
> +++ b/ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.inf
> @@ -29,6 +29,7 @@ [LibraryClasses]
>    DebugLib
>    HobLib
>    FdtLib
> +  PcdLib
>  
>  [FixedPcd]
>    gArmTokenSpaceGuid.PcdFvSize
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>