From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])
 by mx.groups.io with SMTP id smtpd.web10.888.1610628721552001085
 for <devel@edk2.groups.io>;
 Thu, 14 Jan 2021 04:52:01 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: huawei.com, ip: 45.249.212.191, mailfrom: cenjiahui@huawei.com)
Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58])
	by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DGkh107TRzj7XF;
	Thu, 14 Jan 2021 20:50:57 +0800 (CST)
Received: from [10.174.184.155] (10.174.184.155) by
 DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id
 14.3.498.0; Thu, 14 Jan 2021 20:51:52 +0800
Subject: Re: [PATCH v4 0/9] Add extra pci roots support for Arm
To: Laszlo Ersek <lersek@redhat.com>, <devel@edk2.groups.io>
CC: Jordan Justen <jordan.l.justen@intel.com>, Ard Biesheuvel
	<ard.biesheuvel@arm.com>, Rebecca Cran <rebecca@bsdio.com>, Peter Grehan
	<grehan@freebsd.org>, Anthony Perard <anthony.perard@citrix.com>, "Julien
 Grall" <julien@xen.org>, Leif Lindholm <leif@nuviainc.com>, Sami Mujawar
	<sami.mujawar@arm.com>, <xieyingtai@huawei.com>, <wu.wubin@huawei.com>,
	"Yubo Miao" <miaoyubo@huawei.com>
References: <20210112094549.10238-1-cenjiahui@huawei.com>
 <956970aa-fd13-92fc-adb2-5308a493b334@redhat.com>
From: "Jiahui Cen" <cenjiahui@huawei.com>
Message-ID: <37dc9c07-00a3-c0a5-3e1c-318004c9c56c@huawei.com>
Date: Thu, 14 Jan 2021 20:51:50 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <956970aa-fd13-92fc-adb2-5308a493b334@redhat.com>
X-Originating-IP: [10.174.184.155]
X-CFilter-Loop: Reflected
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Laszlo,

On 2021/1/14 19:53, Laszlo Ersek wrote:
> On 01/12/21 10:45, Jiahui Cen wrote:
>> v3->v4:
>> * Refactor InitRootBridges/UninitRootBridges/GetRootBridges/FreeRootBridges.
>> * Fix library dependencies.
>>
>> v2->v3:
>> * Rename utility functions under the PciHostBridgeUtilityLib namespace.
>> * Remove some unused Library dependencies.
>> * Sort the Include headers.
>>
>> v1->v2:
>> * Separated into four patches.
>> * Factor the same logic parts into a new library.
>>
>> v3: https://edk2.groups.io/g/devel/message/69382
>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059
>> QEMU: https://lore.kernel.org/qemu-devel/20201119014841.7298-1-cenjiahui@huawei.com/
>>
>> This patch series adds support for extra pci roots for ARM.
>>
>> In order to avoid duplicated codes, we introduce a new library
>> PciHostBridgeUtilityLib which extracts common interfaces from
>> OvmfPkg/PciHostBridgeLib. It provides conflicts informing and extra pci
>> roots scanning. Using the utility lib, the uefi could scan for extra
>> root buses and recognize multiple roots for ARM.
>>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Rebecca Cran <rebecca@bsdio.com>
>> Cc: Peter Grehan <grehan@freebsd.org>
>> Cc: Anthony Perard <anthony.perard@citrix.com>
>> Cc: Julien Grall <julien@xen.org>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
>> Signed-off-by: Yubo Miao <miaoyubo@huawei.com>
> 
> I've finished reviewing this version; please submit v6.
> 

Thanks for the detailed review. I'll carefully fix them as you points
and submit v6 soon.

Thanks,
Jiahui

> Thanks
> Laszlo
> 
> .
>