From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Thu, 06 Jun 2019 10:16:16 -0700
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 995E730BB37D;
	Thu,  6 Jun 2019 17:15:52 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-49.ams2.redhat.com [10.36.116.49])
	by smtp.corp.redhat.com (Postfix) with ESMTP id B20677D920;
	Thu,  6 Jun 2019 17:15:46 +0000 (UTC)
Subject: Re: [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID
To: Anthony PERARD <anthony.perard@citrix.com>, devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>, Julien Grall <julien.grall@arm.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 Leif Lindholm <leif.lindholm@linaro.org>, Jian J Wang
 <jian.j.wang@intel.com>, Hao A Wu <hao.a.wu@intel.com>,
 Star Zeng <star.zeng@intel.com>
References: <20190606131459.1464-1-anthony.perard@citrix.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <37fb4041-9b04-43bb-8e02-b41fb25afce2@redhat.com>
Date: Thu, 6 Jun 2019 19:15:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190606131459.1464-1-anthony.perard@citrix.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Thu, 06 Jun 2019 17:16:02 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 06/06/19 15:14, Anthony PERARD wrote:
> The macro SERIAL_DXE_FILE_GUID is been defined twice and the GUID is been used
> once without defining the macro. This patch series define a macro in
> MdeModulePkg where the SerialDxe is, and replace all other use by this new one,
> EDKII_SERIAL_PORT_LIB_VENDOR_GUID.
> 
> Note that I haven't build/test those changes, but I have test the first patch
> by applying a similar change to a patch series I'm working on.
> 
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.serial-dxe-guid-v2
> 
> Thanks.
> 
> Anthony PERARD (4):
>   MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID
>   ArmVirtPkg/PlatformBootManagerLib: Use
>     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
>   ArmPkg/PlatformBootManagerLib: Use EDKII_SERIAL_PORT_LIB_VENDOR_GUID
>     from MdeModulePkg
>   UefiPayloadPkg/PlatformBootManagerLib: Use
>     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
> 
>  MdeModulePkg/MdeModulePkg.dec                 |  3 +++
>  .../Universal/SerialDxe/SerialDxe.inf         |  1 +
>  .../Include/Guid/SerialPortLibVendor.h        | 19 +++++++++++++++++++
>  .../PlatformBootManagerLib/PlatformBm.c       |  8 ++------
>  .../PlatformBootManagerLib/PlatformBm.c       |  8 ++------
>  MdeModulePkg/Universal/SerialDxe/SerialIo.c   |  3 ++-
>  .../PlatformBootManagerLib/PlatformConsole.c  |  3 ++-
>  7 files changed, 31 insertions(+), 14 deletions(-)
>  create mode 100644 MdeModulePkg/Include/Guid/SerialPortLibVendor.h
> 

For patches #1 and #2:

Tested-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo