From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in5.apple.com (mail-out5.apple.com [17.151.62.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 93FA421C91277 for ; Wed, 9 Aug 2017 08:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1502293549; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=FS+R9+1rcIlqk0gy3njcTbpawVte4ZkShOv2dY8LHg0=; b=s1ygMZqnxmXEkm4jJSBwX5dNC/iP/I7uH2X4I9vQ1FrhqibAlNMl7ldwIp5wi6xG YRNqe1bTSaE6NmWLv31oz7/QoYPGJDDq1HLxTw8xl7o8wh5TjXijGDeQTXbqrtbI edSCZgc/Ewri8k1Uvj9TZQUr1qkg9SLh0O26PrDsQ1w2ciJpCri94mL9aU5i3SJ+ yNXervgU+QanFIyUN9MtTyzX83dzEI2/QSTxWU6cnMeNjv2jRKm3TgwXF+61RYzb xmnAE4jvWE1PzX2JO0/5x3WhRXexFcMxQu1vhIPUassG7oIN+wUBZacA6EOFIghM UdoFVKMkpHrdannxC3ctbg==; Received: from relay7.apple.com (relay7.apple.com [17.128.113.101]) (using TLS with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail-in5.apple.com (Apple Secure Mail Relay) with SMTP id AA.BB.06802.D2E2B895; Wed, 9 Aug 2017 08:45:49 -0700 (PDT) X-AuditID: 11973e13-e30ed9c000001a92-1c-598b2e2dc3b9 Received: from nwk-mmpp-sz09.apple.com (nwk-mmpp-sz09.apple.com [17.128.115.80]) by relay7.apple.com (Apple SCV relay) with SMTP id E2.A7.07283.D2E2B895; Wed, 9 Aug 2017 08:45:49 -0700 (PDT) MIME-version: 1.0 Received: from [17.235.14.38] by nwk-mmpp-sz09.apple.com (Oracle Communications Messaging Server 8.0.1.2.20170621 64bit (built Jun 21 2017)) with ESMTPSA id <0OUF00FMGD4BRZ10@nwk-mmpp-sz09.apple.com>; Wed, 09 Aug 2017 08:45:49 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish Message-id: <3801BBFD-12B7-485E-8740-F333A4823E9B@apple.com> Date: Wed, 09 Aug 2017 08:45:46 -0700 In-reply-to: Cc: Paulo Alcantara , Jordan Justen , edk2-devel@lists.01.org, Ard Biesheuvel To: Laszlo Ersek References: <20170808193143.18128-1-pcacjr@zytor.com> <20170808193143.18128-5-pcacjr@zytor.com> X-Mailer: Apple Mail (2.3273) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsUi2FCYqqur1x1pcHOWksX/D7sZLfYcOsps seNaP4vFsmM7WCz2vf7I6MDqsXjPSyaPO9f2sHl0z/7H4vF+31U2jxMtX1gDWKO4bFJSczLL Uov07RK4Mi5ufMxScKyZueLObP8GxrXXmLoYOTkkBEwkzm9+xQxiCwmsYZLY0p0EE1/0bAJL FyMXUPwgo8TajQ2MIAleAUGJH5PvsYDYzAJhEss37GKHKPrCKHH71QGwqcIC4hLvzmwCm8om oCyxYv4HoCIOoGYbiUsPTSBKPCS+7zrCBmKzCKhKXJ7SDVbOKWAn8fThUkaQmcwCsxglVs75 ygqSEBFQkZg94QETxLKpjBKbt/1ghDhVVuLW7EvMIAkJgc9sEutWvGOcwCg0C8m1s5BcOwvo EGYBdYkpU3IhwtoST95dYIWw1SQW/l7EhCy+gJFtFaNQbmJmjm5mnqleYkFBTqpecn7uJkZQ LE23E97BeHqV1SFGAQ5GJR7eBNHuSCHWxLLiytxDjNIcLErivH1ZXZFCAumJJanZqakFqUXx RaU5qcWHGJk4OKUaGHWWyxYu5hT8/jNl2qrIa4vTjJd+/6x1uTC2JSgo+N+3btaVQkfDrE+I Md0ychM6cCVoderEHcw2qaJPFv89dYhtqvApVt7lrPM4FW4lSQirJ55/biT5TrFhYUC95E71 N8sik89/7M3MPX3pQsSmM761CxWWvl1RHBnJlCowT/NPjcTmcJW0OUosxRmJhlrMRcWJANGb qpaGAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsUi2FAcoKur1x1pMPedjMX/D7sZLfYcOsps seNaP4vFsmM7WCz2vf7I6MDqsXjPSyaPO9f2sHl0z/7H4vF+31U2jxMtX1gDWKO4bFJSczLL Uov07RK4Mi5ufMxScKyZueLObP8GxrXXmLoYOTkkBEwkFj2bwNLFyMUhJHCQUWLtxgZGkASv gKDEj8n3WEBsZoEwieUbdrFDFH1hlLj96gBYt7CAuMS7M5uYQWw2AWWJFfM/ABVxADXbSFx6 aAJR4iHxfdcRNhCbRUBV4vKUbrByTgE7iacPlzKCzGQWmMUosXLOV1aQhIiAisTsCQ+YIJZN ZZTYvO0HI8SpshK3Zl9insDIPwvJgbOQHDgLaDezgLrElCm5EGFtiSfvLrBC2GoSC38vYkIW X8DItopRoCg1J7HSXC+xoCAnVS85P3cTIzj4C1N3MDYutzrEKMDBqMTDmyDaHSnEmlhWXJl7 iFGCg1lJhDdfFyjEm5JYWZValB9fVJqTWnyIcSIj0JsTmaVEk/OBsZlXEm9oYmJgYmxsZmxs bmJOS2Elcd79WzoihQTSE0tSs1NTC1KLYI5i4uCUamB0aBcLWqJ/6fWmf1yb/adHbs06v0l9 X4y62O5Y9eucZ7oyLV5ufCT+4YOIdcCZ7I/tazryuPanHZ9wqkkyS5zFf8dbpzXHzqvmzUrp b3Bb91GyOuewwZMbuf+53f9otWuZHUj49eT1gbf2k/yPbo/utjs6Y+bfR7/kTUUPLfB7U768 3DyyLLNWiaU4I9FQi7moOBEAzwsDifECAAA= X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: [PATCH 4/4] OvmfPkg: Introduce UDF_ENABLE build flag X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Aug 2017 15:43:31 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > On Aug 9, 2017, at 2:44 AM, Laszlo Ersek wrote: >=20 > CC Ard and Andrew >=20 > On 08/08/17 21:31, Paulo Alcantara wrote: >> By defining this build flag, OVMF will support booting from UDF file >> systems. >>=20 >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Paulo Alcantara >> --- >> OvmfPkg/OvmfPkgIa32.dsc | 7 +++++++ >> OvmfPkg/OvmfPkgIa32.fdf | 3 +++ >> OvmfPkg/OvmfPkgIa32X64.dsc | 7 +++++++ >> OvmfPkg/OvmfPkgIa32X64.fdf | 3 +++ >> OvmfPkg/OvmfPkgX64.dsc | 7 +++++++ >> OvmfPkg/OvmfPkgX64.fdf | 3 +++ >> 6 files changed, 30 insertions(+) >=20 > Ray already mentioned that PcdUdfFileSystemSupport is not needed. I > agree. Similarly, I think UDF_ENABLE is also not needed, the new = driver > should be added to the DSC and FDF files right after "Fat.inf" (like = you > are doing it now, just unconditionally). >=20 > Furthermore, can you please do the same in the ArmVirtPkg DSC and FDF > files? (Just grep the tree for "Fat.inf".) EmulatorPkg and Nt32Pkg are > further emulation platforms that might want to include this. >=20 > My reason for suggesting the unconditional inclusion is the following > sentence from the UEFI 2.7 spec: >=20 > 13 Protocols =E2=80=94 Media Access > 13.3 File System Format > 13.3.2 Partition Discovery > 13.3.2.1 ISO-9660 and El Torito >=20 > [...] DVD-ROM images formatted as required by the UDF 2.0 > specification (OSTA Universal Disk Format Specification, Revision = 2.0) > can be booted by EFI. [...] >=20 > It does not say "may be bootable", it says "can be booted". >=20 > It would be interesting to see the Mantis ticket (if any) that got = this > language into the spec, without the edk2 reference implementation > providing a UDF driver. > - Using the Mantis simple search function, "UDF" brings up nothing. > - =46rom some googling, this sentence appears to go back to EFI 1.10 = at > the least. >=20 > Andrew, do you remember the history of the quoted sentence? >=20 UDF defines a "UDF Bridge" disk that is "El Torito" compatible. So UDF = punted on boot ability by allowing compatibility with CD-ROMs.=20 EFI supports booting from an ISO-9660 file system that conforms to the = =E2=80=9CEl Torito=E2=80=9D Bootable CD-ROM Format Specification on a = DVD- ROM. A DVD-ROM that contains an ISO-9660 file system is defined as = a =E2=80=9CUDF Bridge=E2=80=9D disk. Booting from CD-ROM and DVD-ROM is = accomplished using the same methods. I'm fine with adding a UDF file system driver, but it is not required = from a UEFI Spec conformance point of view.=20 Thanks, Andrew Fish PS "El Torito" was the restaurant that Curtis and Stan wrote out the = proposal on a napkin. Luckily device paths are not called "House of = Teriyaki", or even worse the nickname "rats and rice". =20 > Paulo, I'll check if I can test your driver with some 3rd party media > (i.e., a DVD image that I don't prepare myself). >=20 > Thank you! > Laszlo >=20 >>=20 >> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc >> index 5a14325f73..c71c332efd 100644 >> --- a/OvmfPkg/OvmfPkgIa32.dsc >> +++ b/OvmfPkg/OvmfPkgIa32.dsc >> @@ -39,6 +39,7 @@ >> DEFINE HTTP_BOOT_ENABLE =3D FALSE >> DEFINE SMM_REQUIRE =3D FALSE >> DEFINE TLS_ENABLE =3D FALSE >> + DEFINE UDF_ENABLE =3D FALSE >>=20 >> # >> # Flash size selection. Setting FD_SIZE_IN_KB on the command line = directly to >> @@ -409,6 +410,9 @@ >> gUefiOvmfPkgTokenSpaceGuid.PcdSmmSmramRequire|TRUE >> gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmEnableBspElection|FALSE >> !endif >> +!if $(UDF_ENABLE) =3D=3D TRUE >> + gEfiMdeModulePkgTokenSpaceGuid.PcdUdfFileSystemSupport|TRUE >> +!endif >>=20 >> [PcdsFixedAtBuild] >> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1 >> @@ -685,6 +689,9 @@ >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> = MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> FatPkg/EnhancedFatDxe/Fat.inf >> +!if $(UDF_ENABLE) =3D=3D TRUE >> + MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf >> +!endif >> MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf >> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf >> OvmfPkg/SataControllerDxe/SataControllerDxe.inf >> diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf >> index 5e5ade2a1f..2da1fcbe1f 100644 >> --- a/OvmfPkg/OvmfPkgIa32.fdf >> +++ b/OvmfPkg/OvmfPkgIa32.fdf >> @@ -282,6 +282,9 @@ INF = MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutorDxe.in= f >> INF = MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResou= rceTableDxe.inf >>=20 >> INF FatPkg/EnhancedFatDxe/Fat.inf >> +!if $(UDF_ENABLE) =3D=3D TRUE >> +INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf >> +!endif >>=20 >> !ifndef $(USE_OLD_SHELL) >> INF ShellPkg/Application/Shell/Shell.inf >> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc >> index 2f17a70db8..d0785cca13 100644 >> --- a/OvmfPkg/OvmfPkgIa32X64.dsc >> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc >> @@ -39,6 +39,7 @@ >> DEFINE HTTP_BOOT_ENABLE =3D FALSE >> DEFINE SMM_REQUIRE =3D FALSE >> DEFINE TLS_ENABLE =3D FALSE >> + DEFINE UDF_ENABLE =3D FALSE >>=20 >> # >> # Flash size selection. Setting FD_SIZE_IN_KB on the command line = directly to >> @@ -414,6 +415,9 @@ >> gUefiOvmfPkgTokenSpaceGuid.PcdSmmSmramRequire|TRUE >> gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmEnableBspElection|FALSE >> !endif >> +!if $(UDF_ENABLE) =3D=3D TRUE >> + gEfiMdeModulePkgTokenSpaceGuid.PcdUdfFileSystemSupport|TRUE >> +!endif >>=20 >> [PcdsFixedAtBuild] >> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1 >> @@ -694,6 +698,9 @@ >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> = MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> FatPkg/EnhancedFatDxe/Fat.inf >> +!if $(UDF_ENABLE) =3D=3D TRUE >> + MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf >> +!endif >> MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf >> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf >> OvmfPkg/SataControllerDxe/SataControllerDxe.inf >> diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf >> index aa0d8c69f3..0fdd359051 100644 >> --- a/OvmfPkg/OvmfPkgIa32X64.fdf >> +++ b/OvmfPkg/OvmfPkgIa32X64.fdf >> @@ -283,6 +283,9 @@ INF = MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutorDxe.in= f >> INF = MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResou= rceTableDxe.inf >>=20 >> INF FatPkg/EnhancedFatDxe/Fat.inf >> +!if $(UDF_ENABLE) =3D=3D TRUE >> +INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf >> +!endif >>=20 >> !ifndef $(USE_OLD_SHELL) >> INF ShellPkg/Application/Shell/Shell.inf >> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc >> index c0bd5d0ea6..a25d8b1e99 100644 >> --- a/OvmfPkg/OvmfPkgX64.dsc >> +++ b/OvmfPkg/OvmfPkgX64.dsc >> @@ -39,6 +39,7 @@ >> DEFINE HTTP_BOOT_ENABLE =3D FALSE >> DEFINE SMM_REQUIRE =3D FALSE >> DEFINE TLS_ENABLE =3D FALSE >> + DEFINE UDF_ENABLE =3D FALSE >>=20 >> # >> # Flash size selection. Setting FD_SIZE_IN_KB on the command line = directly to >> @@ -414,6 +415,9 @@ >> gUefiOvmfPkgTokenSpaceGuid.PcdSmmSmramRequire|TRUE >> gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmEnableBspElection|FALSE >> !endif >> +!if $(UDF_ENABLE) =3D=3D TRUE >> + gEfiMdeModulePkgTokenSpaceGuid.PcdUdfFileSystemSupport|TRUE >> +!endif >>=20 >> [PcdsFixedAtBuild] >> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1 >> @@ -692,6 +696,9 @@ >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> = MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> FatPkg/EnhancedFatDxe/Fat.inf >> +!if $(UDF_ENABLE) =3D=3D TRUE >> + MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf >> +!endif >> MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf >> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf >> OvmfPkg/SataControllerDxe/SataControllerDxe.inf >> diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf >> index 98a0cf17da..8ae591c1f5 100644 >> --- a/OvmfPkg/OvmfPkgX64.fdf >> +++ b/OvmfPkg/OvmfPkgX64.fdf >> @@ -283,6 +283,9 @@ INF = MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutorDxe.in= f >> INF = MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResou= rceTableDxe.inf >>=20 >> INF FatPkg/EnhancedFatDxe/Fat.inf >> +!if $(UDF_ENABLE) =3D=3D TRUE >> +INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf >> +!endif >>=20 >> !ifndef $(USE_OLD_SHELL) >> INF ShellPkg/Application/Shell/Shell.inf >>=20 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel