From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.128]) by mx.groups.io with SMTP id smtpd.web11.5863.1606919694730746861 for ; Wed, 02 Dec 2020 06:34:55 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=qPy85rJb; spf=pass (domain: os.amperecomputing.com, ip: 40.107.102.128, mailfrom: vunguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WbIbQffnPCtGo1uNS8I8LgCdlsewI74j1oWWZvwwi1mNZ/HnhR9eXA01Y557CA8LV+Q4LDpunlagjIBrujUiW2yHA+R50appqOj3VWoU8lfUWl0MXTCY79LFMM7ba1g+qOLVhkwVYLThuUl85zEGWYbdkZik/sh6YWt6NB9OZ3EZ8Gwb9PjnXJHHDst8gZQqNsTrwqwO3eBjacRs2wfY/9q3SwMZJBk8pQnJ6hvcQ8g1dYGAupaaqfb9R4R4HXzD3y0fsAYY5eU3WUhbUcVemG2PgPugOE9rxWfUgTR2v9E5Cb+SMNe5Fjff/hdKETrXKDxJd3iEuIk5h+WunSPTeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=71wDD2USLFztJNpYxlz7f9zUN1bc3DaHSwPdcnumvYo=; b=mZQub8DjA0X0VY899jRsZv+tPtcPch/KUtMSzPZQkYNWPxXLrLWlUGEnfLF2IlMtCJ3CClbloI7QuiQHCA/3H1EsVnh109Q5JR4hNbuBIluDVvnS02b/M1j7qyAHM0kdvtSdaVofcFfLl8K23C4lWSolBrF/6GPaohoP+uJc6YB64fk0/3RSDNlD1n6KBB3QpXOxg2IZMyBrgpeWiMPefikw4DESYkxW6vLLBzQbObn999dJsZhm2vdSZVIi/xGqo3c3vJHTcbwDrzBcrBicyj2c35v2DixEsgdaCZco32yRUEDjQzTrcTBbSbbbyO9SR2ESvOIh/hIFAiJYCwez1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=71wDD2USLFztJNpYxlz7f9zUN1bc3DaHSwPdcnumvYo=; b=qPy85rJbLzUedHSOLxQLB2VLJGBx39yrD3fuQjxkjTUedb7rSkMrXZuYRXULz8aPEcSVLmSF1BH5yA+rS61J3+9iwP4EcJ9FhidpgkiFIaOU8j5K1MJSwnqFC5ztGy+AD/ZsmLhHIhHostAIqIU+9fiNuGQGoHZsGKhx9XoqGaA= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from CH2PR01MB6007.prod.exchangelabs.com (2603:10b6:610:47::29) by CH2PR01MB5928.prod.exchangelabs.com (2603:10b6:610:3d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.25; Wed, 2 Dec 2020 14:34:52 +0000 Received: from CH2PR01MB6007.prod.exchangelabs.com ([fe80::a5bf:cd91:769d:a34b]) by CH2PR01MB6007.prod.exchangelabs.com ([fe80::a5bf:cd91:769d:a34b%5]) with mapi id 15.20.3632.017; Wed, 2 Dec 2020 14:34:52 +0000 Subject: Re: [edk2-non-osi][PATCH 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package To: Leif Lindholm , Vu Nguyen Cc: devel@edk2.groups.io, patches@amperecomputing.com, Ard Biesheuvel , Nate DeSimone References: <20201201085409.20045-1-vunguyen@os.amperecomputing.com> <20201202124434.GH1664@vanye> From: "Vu Nguyen" Message-ID: <38170ded-2839-9729-b719-156e205a149f@amperemail.onmicrosoft.com> Date: Wed, 2 Dec 2020 21:34:42 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 In-Reply-To: <20201202124434.GH1664@vanye> X-Originating-IP: [123.21.116.82] X-ClientProxiedBy: HKAPR03CA0013.apcprd03.prod.outlook.com (2603:1096:203:c8::18) To CH2PR01MB6007.prod.exchangelabs.com (2603:10b6:610:47::29) Return-Path: vunguyen@amperemail.onmicrosoft.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.9] (123.21.116.82) by HKAPR03CA0013.apcprd03.prod.outlook.com (2603:1096:203:c8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.8 via Frontend Transport; Wed, 2 Dec 2020 14:34:49 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5fb3dfab-11a3-4a34-1076-08d896cf6dd0 X-MS-TrafficTypeDiagnostic: CH2PR01MB5928: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TZ1N3vhY4Up3QoDGEJze91tqcP3X9xhHvCosqk3vV+//wbq9cjxRWEuHEOapvtMl+S/I80Cb9Ve/yujZ6pG/TIfW3GMVOpcegvDOtkMeLzf+O6EB8XAnXLffNnKXhEyJg40GE7fpY2kwcTBEhT8M5Nt/yTsT5qkL4Gks3iHHl+OfLbY+kyzgPoahuzKr8VjpIzEw5fQsxoI+7wgMOUxWVAKi/38mItfxR6lgqW0gMKTVEw22R+EtngnIXXL1lPuhw8HJcjLOuTsZm8LrN4tOAKMSkLviamooCfBFxLw2GfCkLV35bRrazHPfZOC2BcNhWPxMjD8LAacRuEWLvPOOSBAqgsgro/h6rLC01t4teV+Xn3cu4UN+oWDIaX5kMYNm7y5mzrq57sU1cUmW38AA5fZLcABIi+VOTSnZkIJ7oYg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR01MB6007.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(396003)(39840400004)(376002)(366004)(31696002)(66946007)(19627235002)(8676002)(52116002)(110136005)(6486002)(2906002)(26005)(66476007)(42882007)(53546011)(8936002)(478600001)(186003)(4326008)(83380400001)(6666004)(55236004)(2616005)(956004)(16526019)(54906003)(66556008)(5660300002)(83170400001)(31686004)(16576012)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?NnJLTmxjcmRnODFtRHdydE5zNExsZ2t2dEFRd0dZVFZQOXRCNFIwRHNwclFt?= =?utf-8?B?aGhtbmhCQ2NaVTFtNU1VeTlWaWxISXRrYk9rSHAvNWVjOEU5ek9YaHJrWTlv?= =?utf-8?B?L1c4aDZXTE9RNjZUVzhRanFYMUsvekNtVm1yZWRYMS85TWVkbEk3RTYwNCtB?= =?utf-8?B?aVhuUEZWeHBsTVlzMnhWbU1xd2xaaG5qNTVFNTJMSmpoQUlrOU1TWSt0MTJh?= =?utf-8?B?ZmxiT3NESEcyYzRrKzVzUkcwUEVORTIzS09FbHVwUXIrTDdFSW1ld1hwV0JZ?= =?utf-8?B?OURSVnRocTJ5SkZ2S1M2UEZNd2x5TGZyS28zNmExOWFMdG1BN1BDS3Z5ZzR3?= =?utf-8?B?Zi9laDhBczFmTDI1Qy9kaFR0RHpVSnVqM25neGU2UnhPTVNSVVNiYTJOVmxM?= =?utf-8?B?dHRCa09FQktCVVVJR3Q4Q3pEMWV5QmhhcmZNMHE0VHh3c2Z0ZG1DWjlSNlFW?= =?utf-8?B?UnJMd0tBRHV6cElVbk4wQ1l3aHJqUGZDSEk1bnpBR00xc3lhVWJxeWtPdWVD?= =?utf-8?B?NTdkcVBmQVVic1FiL0RDV2lGSmhnOXRpbXh0bEVIQ3RVeERiK1BuS2taMW1E?= =?utf-8?B?WmJVVHdNYU5MdFloZVNGRENQdlQvcEhXTTdSMkJTYkkxNjFjbERVUEU3YWR4?= =?utf-8?B?ZVk2SU5Ka0t3TE9yNUtMNUdqb1p4TlNNZDJzRytVckRZbFNCZ1hjUXNWMkJB?= =?utf-8?B?dFEvRk10cFBMTFJTSU9RMUl4cTZWZUZ3ZHpoYVNlTUxQSmozZk5JR2kydHhK?= =?utf-8?B?QjlmWmhUNVh3Q2k3RW9uMEFnMEVnc1lKOEhEZmVET2JkeHgyRndkaHFJTTJ2?= =?utf-8?B?NURsU1V3QmhzcTJBSkIzckF4U1JXQ3dPQU12cHU1dTY4aXFzZmd2akpWcXBB?= =?utf-8?B?dGpiWXM4OFN4QUJwd00wYk1lbjhtd0NBWFdTVlhxOHF6OEE0S1lKTDY5V1FR?= =?utf-8?B?cjlpWjlYMkZRaG4zd1RvRW1UZDc3YzdEdUgwYXpKMUZvUlpONW5LZEh5dTJZ?= =?utf-8?B?dlUySjltM1B1TUtvZEQ3Si9vQU1MK2tGczB2MVVlTnpJTjFQOXN2U2E2OCtT?= =?utf-8?B?LzA1aXcyYlZsbkk4MHN0REdVWVNkTnJWQWZMRFhXa1hETVJraUcwK3BHdmF1?= =?utf-8?B?aGVJb0t4NThqbitQd2J5V1ZxREhIclUrTzM5TGw4aUJ0N3dhL2hLK1d3aUxF?= =?utf-8?B?MTNwRm5ZZHVVN29tKzZ0ejlhUXVIakFJK1R4c2Z0UE5scXYra0NmMG53ZDZw?= =?utf-8?B?TU1GOVRFWTZFNjVLOWtyL2tEd09MUHpkei9IdytQYW5GY1JlUEJnV3c5RVlS?= =?utf-8?Q?e6xJz4H//D3elKd10XEAZtV2Z6a5xFM/II?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5fb3dfab-11a3-4a34-1076-08d896cf6dd0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR01MB6007.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2020 14:34:52.3450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ckWiEK1b7dDy5rMcLtrVieS9ldcZs4cxaB3A6AlMBvhs+GuscKbCFJdKnpxxms0/AMlNHOmlCQKO72HFS0OnqTVJUzhivdh7rwirXiv8s6iEuOcw5+tAQ6KQFqsXsLUS X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR01MB5928 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Hi Leif, Thanks for your comment, let me update the patches. Regards, Vu On 12/2/2020 19:44, Leif Lindholm wrote: > Hi Vu, > > Thanks for this. > > However, as previously communicated to your colleague: > --- > As for the mechanism, please generate a separate patch set, adding > --no-binary to the git format-patch command line. > Then make the commits available in a public repository referred to in > the cover letter. > ---- > > As a feedback detail - please drop any leading _ characters from > include file header guards (or other macros), these are reserved for > toolchain use. > > Also, since this is the first on-list communication about this > platform, it would be helpful if the cover letter stated what these > files are and why they are being upstreamed. > > Best Regards, > > Leif > > On Tue, Dec 01, 2020 at 15:54:07 +0700, Vu Nguyen wrote: >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Cc: Nate DeSimone >> >> Vu Nguyen (2): >> AmpereAltraBinPkg: Add PciePhyLib library and header >> edk2-non-osi: Add AmpereAltraBinPkg maintainers >> >> Maintainers.txt | 4 + >> Silicon/Ampere/License.txt | 25 +++ >> .../Ampere/AmpereAltraBinPkg/Ac01BinPkg.dec | 16 ++ >> .../Library/PciePhyLib/PciePhyLib.inf | 23 +++ >> .../Include/Library/PciePhyLib.h | 165 ++++++++++++++++++ >> .../Library/PciePhyLib/PciePhyLib.lib | Bin 0 -> 26026 bytes >> 6 files changed, 233 insertions(+) >> create mode 100644 Silicon/Ampere/License.txt >> create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Ac01BinPkg.dec >> create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf >> create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h >> create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.lib >> >> -- >> 2.17.1 >>