From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.11675.1595509533472966653 for ; Thu, 23 Jul 2020 06:05:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Zkuwid4W; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595509532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zeOGoPHAEPRh9Z/yvBqP+4aP7Y+adL7oOBS6HaU/6zg=; b=Zkuwid4WWCH0Vo1fvDZPqdrH1Lph/9btDJ/QuLr7qaAptGouvurHwx1sm3bTHMrqGdAQc4 OHYitQ3mhU9j4zVxZZ/CUigOMewtVvZljqM1CGrpdlzaenxDXSzkN2xsJOfHwq76i4QXGk +73FlQ/9WQhU3j6Kvh0i5ok/Mv9mmHE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-191-Tyastp7XP6CVI4QVuh3QGw-1; Thu, 23 Jul 2020 09:05:30 -0400 X-MC-Unique: Tyastp7XP6CVI4QVuh3QGw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 73BA2800C64; Thu, 23 Jul 2020 13:05:29 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-52.ams2.redhat.com [10.36.114.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 594B572E48; Thu, 23 Jul 2020 13:05:28 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg: enable HttpDynamicCommand To: devel@edk2.groups.io, vladimir.olovyannikov@broadcom.com Cc: Ard Biesheuvel , Leif Lindholm References: <20200722205434.4348-1-vladimir.olovyannikov@broadcom.com> <20200722205434.4348-3-vladimir.olovyannikov@broadcom.com> From: "Laszlo Ersek" Message-ID: <381b20d0-2f7f-313b-7ef2-9df91029c616@redhat.com> Date: Thu, 23 Jul 2020 15:05:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200722205434.4348-3-vladimir.olovyannikov@broadcom.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 07/22/20 22:54, Vladimir Olovyannikov via groups.io wrote: > Enable HttpDynamicCommand (Shell command "http") for OvmfPkg platforms. > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2857 > > Signed-off-by: Vladimir Olovyannikov > --- > OvmfPkg/OvmfPkgIa32.dsc | 4 ++++ > OvmfPkg/OvmfPkgIa32.fdf | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++++ > OvmfPkg/OvmfPkgIa32X64.fdf | 1 + > OvmfPkg/OvmfPkgX64.dsc | 4 ++++ > OvmfPkg/OvmfPkgX64.fdf | 1 + > OvmfPkg/OvmfXen.dsc | 4 ++++ > OvmfPkg/OvmfXen.fdf | 1 + > 8 files changed, 20 insertions(+) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index 9178ffeb71cb..78413e5ecaae 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -883,6 +883,10 @@ [Components] > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > } > + ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf { > + > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > + } > OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf { > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > index 2b9a6b58015f..c07b775d0a2d 100644 > --- a/OvmfPkg/OvmfPkgIa32.fdf > +++ b/OvmfPkg/OvmfPkgIa32.fdf > @@ -293,6 +293,7 @@ [FV.DXEFV] > > !if $(TOOL_CHAIN_TAG) != "XCODE5" > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > +INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf > INF OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf > !endif > INF ShellPkg/Application/Shell/Shell.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index a665f78f0dc7..92e08fb8c072 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -897,6 +897,10 @@ [Components.X64] > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > } > + ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf { > + > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > + } > OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf { > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf > index 83ff6aef2e8c..9adf1525c135 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.fdf > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf > @@ -294,6 +294,7 @@ [FV.DXEFV] > > !if $(TOOL_CHAIN_TAG) != "XCODE5" > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > +INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf > INF OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf > !endif > INF ShellPkg/Application/Shell/Shell.inf > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 17f345acf4ee..68ed86ef53ce 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -893,6 +893,10 @@ [Components] > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > } > + ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf { > + > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > + } > OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf { > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > index 83ff6aef2e8c..9adf1525c135 100644 > --- a/OvmfPkg/OvmfPkgX64.fdf > +++ b/OvmfPkg/OvmfPkgX64.fdf > @@ -294,6 +294,7 @@ [FV.DXEFV] > > !if $(TOOL_CHAIN_TAG) != "XCODE5" > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > +INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf > INF OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf > !endif > INF ShellPkg/Application/Shell/Shell.inf > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc > index 782803cb2787..1ed7176d26c5 100644 > --- a/OvmfPkg/OvmfXen.dsc > +++ b/OvmfPkg/OvmfXen.dsc > @@ -675,6 +675,10 @@ [Components] > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > } > + ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf { > + > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > + } > OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf { > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > diff --git a/OvmfPkg/OvmfXen.fdf b/OvmfPkg/OvmfXen.fdf > index d9ee14b484a0..c7d4d1853027 100644 > --- a/OvmfPkg/OvmfXen.fdf > +++ b/OvmfPkg/OvmfXen.fdf > @@ -363,6 +363,7 @@ [FV.DXEFV] > > !if $(TOOL_CHAIN_TAG) != "XCODE5" > INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > +INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf > INF OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf > !endif > INF ShellPkg/Application/Shell/Shell.inf > Reviewed-by: Laszlo Ersek