From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.65; helo=mail-wr1-f65.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 137A8211B696B for ; Thu, 7 Feb 2019 06:59:22 -0800 (PST) Received: by mail-wr1-f65.google.com with SMTP id x10so130699wrs.8 for ; Thu, 07 Feb 2019 06:59:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WiE0FeZVZmew7IDNMkBZtXfWurFwjFUfT1TFchJstSM=; b=NkhTXVNz6CMgJUBtqsYNRVnli3nlwhdktwFpqd3es5QP2U9S6/0wkOBYZWK8aT3i/R PpZ4K5d6J/wDUMNhp8+yQMHJICPXwmD2fDHDfCkwmjSKq67I3UyWtyADORqJER80n85S dUi3dIegHHAVBHJKNawhLTYucfDcCT4DJ/Wp6ewkqJ28c+2KHsCKTsRRFzw73yP193JT 5l/4v7mnX098gJ8LIiTq4MT8f5JLLmd/5MRhvlr3rSxfxrKPMa6Mxf8WW8GHNnD/0QTD WkD+OmQP2lYePqI6F5t8sUb3+0dYYd4IN/QCp2ar+hg5WALxX+ES7crQWN9AZOJKd2rU +ldw== X-Gm-Message-State: AHQUAua+3uClwj29FLAWm07YUDrNwIPQwGISdIRQN7mTZ0S4fh/ySoul uuT3yiIJQffzfARcFIIGrkw7JA== X-Google-Smtp-Source: AHgI3IYBF4NfljV7KJnvRj9/ncoKZYyr8g9mHOt1tpgyhp7eO5zTpWYt4xxdpTffGaJTBlL7lGd9lg== X-Received: by 2002:adf:ebd0:: with SMTP id v16mr13292501wrn.109.1549551561127; Thu, 07 Feb 2019 06:59:21 -0800 (PST) Received: from [192.168.1.103] (10.red-83-35-153.dynamicip.rima-tde.net. [83.35.153.10]) by smtp.gmail.com with ESMTPSA id c7sm9831895wrn.71.2019.02.07.06.59.20 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 07 Feb 2019 06:59:20 -0800 (PST) To: Ryszard Knop , edk2-devel@lists.01.org Cc: Antoine Coeur , Laszlo Ersek References: <280bb5d0-e01c-022e-6a02-6b744f61f28d@redhat.com> <2bf54b577aeef2a5529b3880d4d74e361f8a2089.camel@linux.intel.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <385afbeb-98a5-a15d-62ac-d720b4c72b51@redhat.com> Date: Thu, 7 Feb 2019 15:59:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <2bf54b577aeef2a5529b3880d4d74e361f8a2089.camel@linux.intel.com> Subject: Re: [PATCH] CryptoPkg: Fix various typos X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 14:59:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 2/7/19 2:04 PM, Ryszard Knop wrote: > Hi Philippe, Antoine, > > On Wed, 2019-02-06 at 23:30 +0100, Philippe Mathieu-Daudé wrote: >> Hi Antoine, >> >> On 2/6/19 6:24 PM, Antoine Coeur wrote: >>> Fix various typos in CryptoPkg. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Coeur >>> --- >>> CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +- >>> CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4 ++-- >>> 2 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c >>> b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c >>> index d63c23df09..540c5715cb 100644 >>> --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c >>> +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c >>> @@ -142,7 +142,7 @@ IMPLEMENT_ASN1_FUNCTIONS (TS_TST_INFO) >>> @param[in] Asn1Time Pointer to the ASN.1 >>> GeneralizedTime to be converted. >>> @param[out] SigningTime Return the corresponding EFI Time. >>> >>> - @retval TRUE The time convertion succeeds. >>> + @retval TRUE The time conversion succeeds. >> >> The typos are indeed fixed, so: >> Reviewed-by: Philippe Mathieu-Daude >> >> However reading this description makes me suspicious, I'd have >> written >> "The time convertion succeeded.", but I'm not native English speaker >> so >> I'll let someone with more insurance opinate. > > I'm not a native speaker either, but I'd write "conversion" as well. > (Like revert -> reversion, subvert -> subversion, avert -> aversion, > and so on.) Oops, I copy/pasted the wrong line :S Indeed the correct word is "conversion", thanks for correcting me. My wonder is about what is the correct use between succeeds/succeeded, I'd expect the following diff: - @retval TRUE The time convertion succeeds. + @retval TRUE The time conversion succeeded. >> >> Regards, >> >> Phil. >> >>> @retval FALSE Invalid parameters. >>> >>> **/ >>> diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c >>> b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c >>> index 9510a4a383..929e3fcd1e 100644 >>> --- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c >>> +++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c >>> @@ -84,14 +84,14 @@ QuickSortWorker ( >>> } >>> } >>> // >>> - // Swap pivot to it's final position (NextSwapLocaiton) >>> + // Swap pivot to it's final position (NextSwapLocation) >>> // >>> CopyMem (Buffer, Pivot, ElementSize); >>> CopyMem (Pivot, (UINT8 *)BufferToSort + (NextSwapLocation * >>> ElementSize), ElementSize); >>> CopyMem ((UINT8 *)BufferToSort + (NextSwapLocation * >>> ElementSize), Buffer, ElementSize); >>> >>> // >>> - // Now recurse on 2 paritial lists. Neither of these will have >>> the 'pivot' element. >>> + // Now recurse on 2 partial lists. Neither of these will have >>> the 'pivot' element. >>> // IE list is sorted left half, pivot element, sorted right >>> half... >>> // >>> QuickSortWorker ( >>> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel >