public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Matthew Yeazel <yeazelm@amazon.com>
To: edk2-devel@lists.01.org
Cc: Matthew Yeazel <yeazelm@amazon.com>
Subject: [PATCH] BaseTools: Add support for dots in paths
Date: Fri,  5 Oct 2018 10:13:00 -0700	[thread overview]
Message-ID: <38601194f721dcbf6c2b10c981e25714c073a854.1538756540.git.yeazelm@amazon.com> (raw)

The split assumes that there isn't a dot in the path to the file but
this isn't always the case. This will support more diverse paths.

Contributed-under: TianoCore Contribution Agreement 1.1
    Note: Section 3, paragraph 1, is read as an OR.
Signed-off-by: Matthew Yeazel <yeazelm@amazon.com>
---
 BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py
index eb1b283889..54ad4a5247 100644
--- a/BaseTools/Source/Python/AutoGen/AutoGen.py
+++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
@@ -3062,7 +3062,7 @@ class ModuleAutoGen(AutoGen):
         self.BuildOption
         for SingleFile in FileList:
             if self.BuildRuleOrder and SingleFile.Ext in self.BuildRuleOrder and SingleFile.Ext in self.BuildRules:
-                key = SingleFile.Path.split(SingleFile.Ext)[0]
+                key = SingleFile.Path.rsplit(SingleFile.Ext, 1)[0]
                 if key in Order_Dict:
                     Order_Dict[key].append(SingleFile.Ext)
                 else:
-- 
2.19.0



             reply	other threads:[~2018-10-05 17:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 17:13 Matthew Yeazel [this message]
2018-10-05 18:13 ` [PATCH] BaseTools: Add support for dots in paths Carsey, Jaben
2018-10-05 20:07   ` Yeazel (Prime Air), Matt
2018-10-05 20:20     ` Carsey, Jaben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38601194f721dcbf6c2b10c981e25714c073a854.1538756540.git.yeazelm@amazon.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox