Re: [Patch 11/11] Maintainers.txt: Add UnitTestFrameworkPkg

["Laszlo Ersek" <lersek@redhat.com>]

On 01/24/20 03:10, Michael D Kinney wrote:
> Add maintainers and reviewers for UnitTestFrameworkPkg
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index ca9da28925..91059db937 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -479,6 +479,13 @@ M: Guo Dong <guo.dong@intel.com>
>  M: Benjamin You <benjamin.you@intel.com>
>  S: Maintained
>  
> +UnitTestFrameworkPkg
> +F: UnitTestFrameworkPkg/
> +M: Michael D Kinney <michael.d.kinney@intel.com>
> +R: Sean Brogan <sean.brogan@microsoft.com>
> +R: Bret Barkelew <Bret.Barkelew@microsoft.com>
> +S: Maintained
> +
>  StandaloneMmPkg
>  F: StandaloneMmPkg/
>  M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 

The additions look good, but they seem to be added in the
(alphabetically) wrong place.

Hmm wait, the disorder is already there, from earlier: StandaloneMmPkg
shouldn't have been introduced at the end of the file, in commit
2b85beae0b2e, but inserted between "SourceLevelDebugPkg" and "StdLib".

At this moment (master @ 9a1f14ad721b), we should move the
StandaloneMmPkg section between SourceLevelDebugPkg and UefiCpuPkg.

For this patch:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

and I'll file a BZ about fixing the order of StandaloneMmPkg.

Thanks,
Laszlo