From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.11183.1579861364423504861 for ; Fri, 24 Jan 2020 02:22:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=U1hiVNtT; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579861363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LD4SamTL6yk7ZeBBbvhDEuSS8DFMSpG0zBrXHkIh9zQ=; b=U1hiVNtTLQjhn2fQClkTwchFn0dPRsti1gNV2ti1iJz4ZfvzMd4AmRIMg++7DSTjpQ0RsS 2eA8klVg7QHviiOp4prEt0jh2arSNJWVwaO250+RrqwlZ9h7XzzNOzUqYsUTBep7p1wA1D yWgoNUcZ43yHE8EuvzUQxi7LokfjYKE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-IPbmh-NINm2g6SOKmrOM7Q-1; Fri, 24 Jan 2020 05:22:39 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 61874DB25; Fri, 24 Jan 2020 10:22:38 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-77.ams2.redhat.com [10.36.117.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id F3AA88CCDD; Fri, 24 Jan 2020 10:22:36 +0000 (UTC) Subject: Re: [Patch 11/11] Maintainers.txt: Add UnitTestFrameworkPkg To: Michael D Kinney , devel@edk2.groups.io Cc: Sean Brogan , Bret Barkelew , Andrew Fish , Leif Lindholm References: <20200124021032.13808-1-michael.d.kinney@intel.com> <20200124021032.13808-12-michael.d.kinney@intel.com> From: "Laszlo Ersek" Message-ID: <38649df6-4a87-49ed-b1f3-51d2b872967a@redhat.com> Date: Fri, 24 Jan 2020 11:22:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200124021032.13808-12-michael.d.kinney@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: IPbmh-NINm2g6SOKmrOM7Q-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 01/24/20 03:10, Michael D Kinney wrote: > Add maintainers and reviewers for UnitTestFrameworkPkg > > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney > --- > Maintainers.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index ca9da28925..91059db937 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -479,6 +479,13 @@ M: Guo Dong > M: Benjamin You > S: Maintained > > +UnitTestFrameworkPkg > +F: UnitTestFrameworkPkg/ > +M: Michael D Kinney > +R: Sean Brogan > +R: Bret Barkelew > +S: Maintained > + > StandaloneMmPkg > F: StandaloneMmPkg/ > M: Ard Biesheuvel > The additions look good, but they seem to be added in the (alphabetically) wrong place. Hmm wait, the disorder is already there, from earlier: StandaloneMmPkg shouldn't have been introduced at the end of the file, in commit 2b85beae0b2e, but inserted between "SourceLevelDebugPkg" and "StdLib". At this moment (master @ 9a1f14ad721b), we should move the StandaloneMmPkg section between SourceLevelDebugPkg and UefiCpuPkg. For this patch: Reviewed-by: Laszlo Ersek and I'll file a BZ about fixing the order of StandaloneMmPkg. Thanks, Laszlo