From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g2t2354.austin.hpe.com (g2t2354.austin.hpe.com [15.233.44.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1EF2581962 for ; Mon, 9 Jan 2017 22:49:09 -0800 (PST) Received: from AIA2PHNNRN.local (unknown [16.214.90.9]) by g2t2354.austin.hpe.com (Postfix) with SMTP id 7F2FE50; Tue, 10 Jan 2017 06:49:08 +0000 (UTC) Date: Tue, 10 Jan 2017 00:49:08 -0600 From: Chris Phillips CC: michael.d.kinney@intel.com, liming.gao@intel.com Sender: Chris Phillips To: edk2-devel@lists.01.org Message-ID: <386f0aa8-708b-46e6-b20d-77ae416355ba@AIA2PHNNRN.local> X-Mailer: TortoiseGit MIME-Version: 1.0 Subject: [PATCH] MdePkg: Add comments for SMBIOS Type 3 structure to cover SKU Number X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2017 06:49:09 -0000 Content-Type: text/plain; Starting with SMBIOS spec version 2.7, Type 3 added SKU Number. SKU Number is at a variable offset (depends on count and length of Contained Elements), so cannot add SKU Number to the SMBIOS_TABLE_TYPE3 structure. Adding comments to explain how to get SKU Number. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chris Phillips --- MdePkg/Include/IndustryStandard/SmBios.h | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h index c66422fc3a..a24713d214 100644 --- a/MdePkg/Include/IndustryStandard/SmBios.h +++ b/MdePkg/Include/IndustryStandard/SmBios.h @@ -2,7 +2,7 @@ Industry Standard Definitions of SMBIOS Table Specification v3.0.0. Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
-(C) Copyright 2015 Hewlett Packard Enterprise Development LP
+(C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License that accompanies this distribution. The full text of the license may be found at @@ -467,7 +467,18 @@ typedef struct { UINT8 NumberofPowerCords; UINT8 ContainedElementCount; UINT8 ContainedElementRecordLength; + // + // Can have 0 to (ContainedElementCount * ContainedElementRecordLength) contained elements + // CONTAINED_ELEMENT ContainedElements[1]; + // + // Add for smbios 2.7 + // + // Since ContainedElements has a variable number of entries, must not define SKUNumber in + // the structure. Need to reference it by starting at offset 0x15 and adding + // (ContainedElementCount * ContainedElementRecordLength) bytes. + // + // SMBIOS_TABLE_STRING SKUNumber; } SMBIOS_TABLE_TYPE3; /// -- 2.11.0.windows.1