From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.10389.1597326776939383781 for ; Thu, 13 Aug 2020 06:52:57 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9837631B; Thu, 13 Aug 2020 06:52:56 -0700 (PDT) Received: from [192.168.178.54] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8D4353F6CF; Thu, 13 Aug 2020 06:52:55 -0700 (PDT) Subject: Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix RPi4 GICC PMU PPI To: Pete Batard , Samer El-Haj-Mahmoud , devel@edk2.groups.io Cc: Leif Lindholm , Andrei Warkentin References: <20200728210028.6024-1-Samer.El-Haj-Mahmoud@arm.com> <118c0e2d-94b3-a212-607b-49765f21e77f@akeo.ie> From: "Ard Biesheuvel" Message-ID: <387815c0-7025-bd2f-690f-be336bcd7046@arm.com> Date: Thu, 13 Aug 2020 15:52:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <118c0e2d-94b3-a212-607b-49765f21e77f@akeo.ie> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 7/31/20 9:55 AM, Pete Batard wrote: > On 2020.07.28 22:00, Samer El-Haj-Mahmoud wrote: >> Arm SBSA specification section ver 6.0, 4.1.5 defines specific PPI >> values for certain standard interrupt IDs. The value for >> "Performance Monitors Interrupt" needs to be 23. >> >> REF: https://developer.arm.com/documentation/den0029/latest >> >> This partially fixes SBSA test #11 ("Incorrect PPI value") reported in >> https://github.com/pftf/RPi4/issues/74 >> >> Cc: Leif Lindholm >> Cc: Pete Batard >> Cc: Andrei Warkentin >> Cc: Ard Biesheuvel >> Signed-off-by: Samer El-Haj-Mahmoud >> --- >> =C2=A0 Platform/RaspberryPi/RPi4/RPi4.dsc | 8 ++++---- >> =C2=A0 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc=20 >> b/Platform/RaspberryPi/RPi4/RPi4.dsc >> index c481c3534263..00683afe96b9 100644 >> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc >> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc >> @@ -433,10 +433,10 @@ [PcdsFixedAtBuild.common] >> =C2=A0=C2=A0=C2=A0 gRaspberryPiTokenSpaceGuid.PcdGicInterruptInterface= HBase|0xFF844000 >> =C2=A0=C2=A0=C2=A0 gRaspberryPiTokenSpaceGuid.PcdGicInterruptInterface= VBase|0xFF846000 >> =C2=A0=C2=A0=C2=A0 gRaspberryPiTokenSpaceGuid.PcdGicGsivId|0x19 >> -=C2=A0 gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq0|0x30 >> -=C2=A0 gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq1|0x31 >> -=C2=A0 gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq2|0x32 >> -=C2=A0 gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq3|0x33 >> +=C2=A0 gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq0|23 >> +=C2=A0 gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq1|23 >> +=C2=A0 gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq2|23 >> +=C2=A0 gRaspberryPiTokenSpaceGuid.PcdGicPmuIrq3|23 >> =C2=A0=C2=A0=C2=A0 # >> =C2=A0=C2=A0=C2=A0 # Fixed CPU settings. >> >=20 > Reviewed-by: Pete Batard Thanks Pushed as cf825de918f9..602a7ea1ab6d