From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8CB7A211BFCB5 for ; Wed, 30 Jan 2019 05:35:51 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 05:35:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="112318495" Received: from linux.intel.com ([10.54.29.200]) by orsmga006.jf.intel.com with ESMTP; 30 Jan 2019 05:35:50 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 25207580297; Wed, 30 Jan 2019 05:35:48 -0800 (PST) Message-ID: <3895772efbc341a4cc287587de3c5b2453cd8d16.camel@linux.intel.com> From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Wed, 30 Jan 2019 14:35:47 +0100 In-Reply-To: <20181106175833.26964-12-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-12-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 11/19] IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP token pasting X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 X-List-Received-Date: Wed, 30 Jan 2019 13:35:51 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reviewed-by: Ryszard Knop On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote: > The ## CPP token pasting operator is used to paste *tokens*, which > is not the same thing as pasting arbitrary macro arguments. Since a > token cannot contain . or ) characters in the first place, using > the ## operator here is wrong and unnecessary, so just remove it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h > b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h > index 72f6a95ccb6d..04f08b41c842 100644 > --- a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h > +++ b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h > @@ -112,7 +112,7 @@ typedef struct { > > @return Width of given field is returned > **/ > -#define UNDI_CONFIG_WIDTH(Field) sizeof (UndiPrivateData- > >Configuration. ## Field ## ) > +#define UNDI_CONFIG_WIDTH(Field) sizeof (UndiPrivateData- > >Configuration.Field) > > // General parameters > #define QUESTION_ID_EFI_DRIVER_VER 0x11 > 00