From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.81]) by mx.groups.io with SMTP id smtpd.web12.6602.1639750557336872007 for ; Fri, 17 Dec 2021 06:15:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=DaLKMG0G; spf=pass (domain: arm.com, ip: 40.107.22.81, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+pOe67cT+GsREIlNLnOwijKyZKTc1PzfeutGOrxVP70=; b=DaLKMG0GOUt3tDiQRbxLc00AhcDWLcKasOMvEo2ytBrzMVmf+48QVfo6+1deHPT5+Vg1SzpiEzuoNEiq9ALdEnoL3dMnt9q5D48i5IQfNn14kKRo7DAOrgKNe7Ri+ElguJzKQNnHMyunDBwXTn+lIPZtfWCW4OS5atSBISD7WE4= Received: from AM6P192CA0063.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::40) by PA4PR08MB6112.eurprd08.prod.outlook.com (2603:10a6:102:f1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Fri, 17 Dec 2021 14:15:54 +0000 Received: from VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:82:cafe::56) by AM6P192CA0063.outlook.office365.com (2603:10a6:209:82::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15 via Frontend Transport; Fri, 17 Dec 2021 14:15:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT048.mail.protection.outlook.com (10.152.19.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend Transport; Fri, 17 Dec 2021 14:15:54 +0000 Received: ("Tessian outbound de6049708a0a:v110"); Fri, 17 Dec 2021 14:15:53 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3b8c36477e43a2f0 X-CR-MTA-TID: 64aa7808 Received: from 62a4b0563d89.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C5B46488-46FB-4FAF-A51F-6CA2605A1A38.1; Fri, 17 Dec 2021 14:15:47 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 62a4b0563d89.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 17 Dec 2021 14:15:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J1NE56gIiJpTHAT0jtMSXtTWHBc8QLiqQKSf/NB/yeCPBlgJ+ejk4PE0+hsm/LKqnpsgl02eNPw7luQHLlYpuJ8mlfuO7Oj/wJphyh+lM9MgWCrjZRqaRwXO3Pyym4OjoentXxTaGmuMDNShnjYpASW8S4eOKRi22bxDMPHaC5tJBoz9uz0zld7+UaTBanoQplt/NkT7xnDauJ/CSclTxuzB5BXTEF6/J7ldl65pSvsoy2mWPXKySQPaeaI3WNqDtN5Y8uIuy6Qb2Q/VCDL56ltrCk4TjZA+gWD8M7QKS0OwDYyBAlG65xabZmwnso1c7so0Mt9mQgtFOfAMybEGmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+pOe67cT+GsREIlNLnOwijKyZKTc1PzfeutGOrxVP70=; b=HGnV/lys0DiDIB2RdDnxiBhTjBR4GGanNipemtDq3zyrdXAjfkrwqPALSz+BFj+5+XhwAUBLZkOJ8pvCR1eEepCX6KY4tLDHAc/vZU1Tx/1GjPMTo7RA3OhX4qmRAjYcfOd6vvuCOAGT64BpnrubCFLY+p8Pk09xKUD38x/Wm1R6dzPxR9J7VCXWxFExuH2cQaxtSAl41ENvPAYeWM47HoItvnvW/kHODCbFxPZDJGFfXORmkiKoWZzRIHQMYEukJL6Rg2jxWuvFhPamFsw9uxIPb/bqBTA7WxjGVDYgQtdzbxK7WKTXG0r1I5Yp+cS/I6igsrhVL6gKoc3ArNvw5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+pOe67cT+GsREIlNLnOwijKyZKTc1PzfeutGOrxVP70=; b=DaLKMG0GOUt3tDiQRbxLc00AhcDWLcKasOMvEo2ytBrzMVmf+48QVfo6+1deHPT5+Vg1SzpiEzuoNEiq9ALdEnoL3dMnt9q5D48i5IQfNn14kKRo7DAOrgKNe7Ri+ElguJzKQNnHMyunDBwXTn+lIPZtfWCW4OS5atSBISD7WE4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM5PR0801MB1650.eurprd08.prod.outlook.com (2603:10a6:203:2f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Fri, 17 Dec 2021 14:15:45 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac%6]) with mapi id 15.20.4755.021; Fri, 17 Dec 2021 14:15:45 +0000 Subject: Re: [PATCH edk2-platforms v1 09/10] Platform/ARM: Fix Ecc error 9005 To: Pierre.Gondois@arm.com, devel@edk2.groups.io, nd References: <20211124162330.236813-1-Pierre.Gondois@arm.com> <20211124162330.236813-10-Pierre.Gondois@arm.com> From: "Sami Mujawar" Message-ID: <38abde3e-dac3-7157-8176-b35f5e5b790f@arm.com> Date: Fri, 17 Dec 2021 14:15:53 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211124162330.236813-10-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO2P265CA0022.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::34) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.50) by LO2P265CA0022.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::34) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Fri, 17 Dec 2021 14:15:45 +0000 X-MS-Office365-Filtering-Correlation-Id: d901243d-7aa2-45fb-c718-08d9c167bcdc X-MS-TrafficTypeDiagnostic: AM5PR0801MB1650:EE_|VE1EUR03FT048:EE_|PA4PR08MB6112:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QGvKKsepuPkvXTM/hISBgODfZlU3qVKtWjNufXm75zV3sW/RkvGSC6cJu8fNv4LF1tkqJ+kKGs0NfJrM86jzotGyTefSUBykUHkDbxOdtfWM+KRZ89YyfaiTPud2R2mOMfSM8oSVV4Mj/wCFp6aB+qFs2pFYGQVEu/b1dHsMH47FbqpV+loLwqQFiHw6PQLPmjtJCvHlPSl4Kiqw3fy5E0tV5BROtBTFGRxlgO/d8RuWCv3aLl9Lo52aCIG358O761hSs/5ggkklICHOlK3u/b8yGLu0CIAxCBsMr4DXiKKKmGcIpbaYvafhaIL2jZsO00dASsuJCsTx0w8bAp31LxChca4bY64maAPSJTTRnnepD/FCt+1usb2r97yVXB0dEqduel/77JdxNfIlfa7raizeCOobtkholkVetHWpmWzLIEItOMh+C+Ol8vspYU13hf/Edm3WG+gWWTXLHBf2rLEyHfrKn+EYUgJq6HLxv3nFp2GDOcLia1P73wXP55L4MA0kp9a77ikFjm2foxSHyHw9mOim/fGSDBVqq/3KN3D2vjJSeB+DcTFxexdu3j+ktcuNrqKQqEGccROGd3FGdw6lbrsGp4dukU1aTm4dOKK/0tSM+AnSVhsm9x7XOTwzOZ5Xbe+YBleLf8ZT1NEojD0G6389AUv7eAl/Z6b0izmrE9UxWxAMVMArhhR00pjHM26Ah1A1crvr9GowCVzuNsosjjZ4JhPP3ofjvg014BrZ+1EnspzGh/zgRn44RyEa1NxPRpPt36D5PeVBdo6y/Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6636002)(83380400001)(36756003)(38100700002)(37006003)(8936002)(16576012)(508600001)(26005)(316002)(31696002)(86362001)(31686004)(8676002)(38350700002)(53546011)(2616005)(186003)(956004)(52116002)(66946007)(44832011)(66556008)(6486002)(6666004)(66476007)(6862004)(5660300002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1650 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a2dcf6cd-0a2f-4585-73eb-08d9c167b753 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D2SQcHdseb0cQaG6YjS4J4wu2LED7hXX670s4JYx/NoQNWiWdMOCVWgq0gZetKzAYTlmH9ZzG8o82KURlmkkmrcZyNGCwpMPkb1jpVpGw7eb8aKc9cSkDEH+MuYkBRWjlQ1x8ZejNO/kCdmYPtX52kv89/rQ7NwWdDVGcCr6i3G8U54jDADdajCycAkkN5Mswj9+TQbQP7OtUFMMP4ZBommfpYDqerFzhA6EDHSzmH+6Eh1k/y1bzVEZ+NUi9iy3KzjlXaPM26im4tAD+DxPr5l7EDtj/x7gL7kTtOqeziHaboGbyjnCZnImv//SRd0rdindP8avFydXkpQJEW89nu+Ui1ZF6URaXL754P+g8+TANhtcNJWy5yvKiKubM4lYDG42ayt49O3wmlEw5PIBv8fFqV/pnbG1hfism2e2llgIQxO74SIswiy8FSFbXZGS0sNFYHEr2aw+HKsuOB0s7SK5A9uF3qsB5pnFejHKKI7zqrb6W5YkJqCXaDdIQqM/KbzedTfbXQmq7zsrZcBLbZjT9m1M2k7ChweyGZl0k+rwChG6Hf6IGOkcK9HCb9eE4JWX3nA4PDHTWOtB/i5S/JWlg2831zlTq0d7lA+iz8Ssy8WplL7/QxspH//21VXCkyFQrkpJlQbQ/UkjWptbuuzkZq4ll9XWJSlNYvW9AT7mXCEyGYN1Sf7Kw7F9GJtp30gY53dcFCNj/Gj1UxrYm48M6DIpehTwDokh9XiIFds= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(956004)(16576012)(31686004)(44832011)(356005)(8676002)(83380400001)(31696002)(6636002)(86362001)(2906002)(316002)(53546011)(186003)(5660300002)(6666004)(81166007)(36756003)(508600001)(6862004)(37006003)(82310400004)(8936002)(336012)(6486002)(26005)(47076005)(70586007)(36860700001)(2616005)(70206006)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 14:15:54.2763 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d901243d-7aa2-45fb-c718-08d9c167bcdc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6112 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/11/2021 04:23 PM, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > This patch fixes the following Ecc reported error: > Only Doxygen commands '@bug', '@todo', '@example', > '@file', '@attention', '@param', '@post', '@pre', > '@retval', '@return', '@sa', '@since', '@test', > '@note', '@par', '@endcode', '@code', '@{', '@}' > are allowed to mark the code > > Signed-off-by: Pierre Gondois > --- > .../ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib= /ArmVExpressPciHostBridgeLib.c b/Platform/ARM/VExpressPkg/Library/ArmVExpre= ssPciHostBridgeLib/ArmVExpressPciHostBridgeLib.c > index 54add33b8912..4f6e0c5c44b8 100644 > --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVEx= pressPciHostBridgeLib.c > +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVEx= pressPciHostBridgeLib.c > @@ -106,7 +106,7 @@ STATIC CONST CHAR16 mAcpiAddrSpaceTypeStr[][4] =3D { > > @param [out] Count Return the count of root bridge instances. > > - @returns All the root bridge instances in an array. > + @return All the root bridge instances in an array. > The array should be passed into PciHostBridgeFreeRootBridges= () > when it's not used. > **/ > -- > 2.25.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.