From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web09.44912.1606176309494051379 for ; Mon, 23 Nov 2020 16:05:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PVLzSDfn; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606176308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ubVYo656dVCn3ZN9y9tUJCadSZpbEul9NAraRFwJKKs=; b=PVLzSDfnLt7+AE/8JimbWSX4+4cQfp2BeBEC9B4IXBWTqh4DN/d49TMmlWM8s9wJnMRWWp kS72wVNOM3muswczxUJy5ah+k9B8eFRdwVBxyf4eYrVTFlaie3LVnT1zbk3R5apW8hmNk8 2LY0nrClk7avof+H+bTdaYEMAUBGxkY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-4-IAah6VgAPx-x9vZb3eNpFg-1; Mon, 23 Nov 2020 19:05:06 -0500 X-MC-Unique: IAah6VgAPx-x9vZb3eNpFg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 799B7107B45A; Tue, 24 Nov 2020 00:05:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-230.ams2.redhat.com [10.36.112.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4E9B660864; Tue, 24 Nov 2020 00:05:04 +0000 (UTC) Subject: Re: [PATCH 1/1] OvmfPkg/Bhyve: Add support for the AMD host bridge To: Rebecca Cran , devel@edk2.groups.io Cc: Jordan Justen , Ard Biesheuvel , Peter Grehan References: <20201123050502.96793-1-rebecca@bsdio.com> From: "Laszlo Ersek" Message-ID: <38aeae72-e376-7791-fbd9-ae73a3621479@redhat.com> Date: Tue, 24 Nov 2020 01:05:03 +0100 MIME-Version: 1.0 In-Reply-To: <20201123050502.96793-1-rebecca@bsdio.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/23/20 06:05, Rebecca Cran wrote: > On bhyve, either an Intel or AMD host bridge can be specified, with the > default being Intel. > Both are identical, except the AMD one uses a PCI vendor ID of AMD. > > Signed-off-by: Rebecca Cran > --- > OvmfPkg/Bhyve/PlatformPei/Platform.c | 3 ++- > OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c | 6 ++++-- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/OvmfPkg/Bhyve/PlatformPei/Platform.c b/OvmfPkg/Bhyve/PlatformPei/Platform.c > index 11658d478c3b..9f1900626d6b 100644 > --- a/OvmfPkg/Bhyve/PlatformPei/Platform.c > +++ b/OvmfPkg/Bhyve/PlatformPei/Platform.c > @@ -349,7 +349,8 @@ MiscInitialization ( > // Determine platform type and save Host Bridge DID to PCD > // > switch (mHostBridgeDevId) { > - case 0x1275: // BHYVE > + case 0x7432: // BHYVE (AMD hostbridge) > + case 0x1275: // BHYVE (Intel hostbridge) > case INTEL_82441_DEVICE_ID: > PmCmd = POWER_MGMT_REGISTER_PIIX4 (PCI_COMMAND_OFFSET); > Pmba = POWER_MGMT_REGISTER_PIIX4 (PIIX4_PMBA); > diff --git a/OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c > index 3b94630ac732..eaade4adeae2 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c > +++ b/OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c > @@ -1066,7 +1066,8 @@ SetPciIntLine ( > // and should match SeaBIOS src/fw/pciinit.c *_pci_slot_get_irq() > // > switch (mHostBridgeDevId) { > - case 0x1275: // BHYVE > + case 0x7432: // BHYVE (AMD hostbridge) > + case 0x1275: // BHYVE (Intel hostbridge) > case INTEL_82441_DEVICE_ID: > Idx -= 1; > break; > @@ -1143,7 +1144,8 @@ PciAcpiInitialization ( > // > mHostBridgeDevId = PcdGet16 (PcdOvmfHostBridgePciDevId); > switch (mHostBridgeDevId) { > - case 0x1275: // BHYVE > + case 0x7432: // BHYVE (AMD hostbridge) > + case 0x1275: // BHYVE (Intel hostbridge) > case INTEL_82441_DEVICE_ID: > Pmba = POWER_MGMT_REGISTER_PIIX4 (PIIX4_PMBA); > // > Acked-by: Laszlo Ersek