From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web11.14400.1576259484599845872 for ; Fri, 13 Dec 2019 09:51:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=OUBya+s4; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.65, mailfrom: pete@akeo.ie) Received: by mail-wr1-f65.google.com with SMTP id b6so400923wrq.0 for ; Fri, 13 Dec 2019 09:51:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MiitAuSX/l84ovW8EK77kfg6furdNxbIpU7myjtGn4w=; b=OUBya+s4B+UQmMffChuiereHG4xmxE4Pk/ZbKyWKU7KtJXutT+9a64VWjxZzBH92OB snEFO1U9CxByuKmwVckQd0yL8yAAw7eQpig91eNUSu5u9HcR2ZgMgQ2L1AXJwEQAQpv4 E9zV9MKmspykrkmINdkgvf+SZATULcnl5zqt/ck3j63j+fFZMkKgenIJbIK3gk9cfywS kOtN3la1FvW8Y/evRUD3I/efLN7Be35GabCPGNB5wHY/uWpU2G5+s443lmGYshrjHWxI jgrt6ToxvuTIxcClpi1Y3IIgThRTtj2OTnmVk39Ft0FIhdhMz9TcHy+2I++yzelvmfhN xU4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MiitAuSX/l84ovW8EK77kfg6furdNxbIpU7myjtGn4w=; b=So9VUCdzZuKOyXz/04KIKidYab5oneXHeZtoJA93vBaIGV+2Pm0Kz+QQnh9qkQOTr6 9oK8odYzKNhmI7jE8Zc3IqiCazN1JEOYFS/PjIE0RKDrkocNgzBdfZ2NiMYB+lWp3PGy A0vr6aWVrH1wpjVeKa3Nq/7p09uJk8d1vSMOxnS1kjCgi+SV0yvEJNGTYvkK1wuH3J8E zQF6UJS300qt8JE1pUX6I+Kteb/JfD2cMTytqmMw99aFqg162umE8C+TcpDC9Ly0I5Fs s0T+W4kVpWLWKYd/F5MSHUi7eDvVXt+Qcp2u276ivLxbQzG6P/Pv4GAE61m2dofVdub4 qc0w== X-Gm-Message-State: APjAAAVuu/+NbD9Y8Hi5314KQtrMTPMYkMIec1c3FL1HVc6vLo0J2Uyh 4GFkjblLgXUDl4fe3AJTfB+tYQ== X-Google-Smtp-Source: APXvYqzXr3aMzR8anuUCvayFbfvV0qu1IUr/rIjaHiBJ4ijtPdJQMXbFHPgQWGt++96tooKqu6aanw== X-Received: by 2002:a5d:6349:: with SMTP id b9mr14702727wrw.346.1576259483151; Fri, 13 Dec 2019 09:51:23 -0800 (PST) Return-Path: Received: from [10.0.0.122] ([84.203.45.230]) by smtp.googlemail.com with ESMTPSA id g25sm15603658wmh.3.2019.12.13.09.51.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Dec 2019 09:51:22 -0800 (PST) Subject: Re: [edk2-platforms][PATCH v2 0/4] Platform/RPi4: Add PCIe and xHCI support To: Ard Biesheuvel Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , lintonrjeremy@gmail.com References: <20191213170704.8120-1-pete@akeo.ie> From: "Pete Batard" Message-ID: <38ba6495-d2ba-9ac9-36fa-d7afcc719526@akeo.ie> Date: Fri, 13 Dec 2019 17:51:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2019.12.13 17:40, Ard Biesheuvel wrote: > On Fri, 13 Dec 2019 at 18:07, Pete Batard wrote: >> >> Changes from v1 (https://edk2.groups.io/g/devel/message/52160 - 52164): >> >> * Ensure that read/write accesses are serialized in PciSegmentLib. >> * Flesh out commit messages. >> * Minor comments and code updates for whitespaces & capitalization. >> >> Jeremy Linton (4): >> Silicon/Bcm27xx: Add PCIe constants to Bcm2711.h >> Silicon/Bcm27xx: Add segment library to handle nonstandard ECAM >> Silicon/Bcm27xx: Add PCIe host bridge config library >> Platform/RPi4: Build the PCIe and xHCI drivers into the firmware >> > > Thanks Pete > > Reviewed-by: Ard Biesheuvel > > I have touched up a couple of style issues, and pushed the series as > c682c58b3a29..9c8c79542eae Much appreciated, thanks! Since this RPi4 integration is moving fast, I'll use this opportunity to send a gentle ping for https://edk2.groups.io/g/devel/message/52131, which I sent before the v1 for the PCIe series. Regards, /Pete > > >> Platform/RaspberryPi/RPi4/RPi4.dsc | 29 +- >> Platform/RaspberryPi/RPi4/RPi4.fdf | 10 +- >> Platform/RaspberryPi/RPi4/Readme.md | 23 +- >> Silicon/Broadcom/Bcm27xx/Bcm27xx.dec | 4 + >> Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h | 71 + >> Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c | 193 +++ >> Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.inf | 51 + >> Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLibConstructor.c | 235 ++++ >> Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c | 1445 ++++++++++++++++++++ >> Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.inf | 35 + >> 10 files changed, 2078 insertions(+), 18 deletions(-) >> create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c >> create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.inf >> create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLibConstructor.c >> create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c >> create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.inf >> >> -- >> 2.21.0.windows.1 >>