From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-x234.google.com (mail-yw0-x234.google.com [IPv6:2607:f8b0:4002:c05::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D3F401A1E20 for ; Tue, 18 Oct 2016 09:58:11 -0700 (PDT) Received: by mail-yw0-x234.google.com with SMTP id w3so143097705ywg.1 for ; Tue, 18 Oct 2016 09:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc:content-transfer-encoding; bh=9WQsj0E4b6zh0VmgyLhf6h0DSHFCR27juowwgQO8+OE=; b=Ymjz5n+Oe6gJ+XyidtwNJ1pZm771WOElDjLp/UJzXBIIZjm84++8AaTdAq3/6p5TmI SigW/BZmVm3n/WgOp0x8QJxJa9FmunSQkwmSPZ7cna1nE8MK8imP09pVIfKdkzcK6r9b 0Y1L1jvbq202800uaU1YkCSvo1PhrkdCKVWNk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc :content-transfer-encoding; bh=9WQsj0E4b6zh0VmgyLhf6h0DSHFCR27juowwgQO8+OE=; b=UwqkRIVLEP2wODNbgVao9TAbIAuxQF6gWUkjw6zWTy2EnrQDQiBicoELr/5QUVlFqg Z70HSCCYzMuvxmBMemjbsk8MXb03x4WRLIGIbY5iy1cknnmxnlpwYfw22nOmfadAc/M3 uxY/OtchxYlu2GpQbQCcMNcyP/9M94Lc/aokv3+mulUAGoXAsqcsnSJPeIsDTAbYZObE Wsq5i6gT3iy6fxAB3EjZCzBBWcCO0zFwCcNzGmQ2SVoJPg/Q6UN/TJW2SIwO+wsdHgVu w+vAswcksvaVs+gfj46qguN5izB/v9BFLV/2V86RxUl1QnpRl7Thj828tOpM0nPIsutY UC9Q== X-Gm-Message-State: AA6/9RkuSGckIqhkMilLkDxiTsR4WOyhH3dS09gQwhtnISEjiwxTeBeXWYVwnPTTfXfDD/IdzGegw7w/EpP39k7l X-Received: by 10.13.225.148 with SMTP id k142mr1617510ywe.183.1476809890614; Tue, 18 Oct 2016 09:58:10 -0700 (PDT) From: Vladimir Olovyannikov References: <1476595420-12566-1-git-send-email-vladimir.olovyannikov@broadcom.com> <40b80588-1bb4-e5f2-439c-97a405c873d3@redhat.com> <1e599793ddedca50db54fb22b429cf53@mail.gmail.com> In-Reply-To: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQER8uOXAe1T3m2dQCB9BI96nx1WVQI0U20WAsr2fFcB2sPwFgJQQiVlAZQGnGcCLb6ysAD2fPV6AUaH6JChtZGXkA== Date: Tue, 18 Oct 2016 09:58:09 -0700 Message-ID: <38cdf2c64b531db8250f900f4f4193cb@mail.gmail.com> To: "Shah, Tapan" , "Carsey, Jaben" , Michael Zimmermann Cc: "Ni, Ruiyu" , "Arshi, Shala" , "edk2-devel@lists.01.org" , Laszlo Ersek Subject: Re: [PATCH] GPT Shell Application/Library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2016 16:58:12 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thank you all for comments, So to summarize the discussion: 1. I will create a Shell library which would perform all GPT operations. Part of PartitionDxe will also be in that library so PartitionDxe will be using it. The gpt Shell tool will also be using it. 2. Refactor the parameters of the gpt utility to make it similar to other existing Shell commands. BTW Is there any document describing Shell utility parameters' standards? Please let me know if you have other suggestions. Thank you, Vladimir -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Shah= , Tapan Sent: October-18-16 6:59 AM To: Carsey, Jaben; Vladimir Olovyannikov; Michael Zimmermann Cc: Ni, Ruiyu; Arshi, Shala; edk2-devel@lists.01.org; Laszlo Ersek Subject: Re: [edk2] [PATCH] GPT Shell Application/Library Thanks for the contribution Vladimir! Few comments: 1. It's better to refactor the code now before commit and move GPT related code outside ShellPkg and create a shared library. 2. CLI parameters of this utility are too complex and need to be refactored to make it similar to other existing Shell commands. Thanks, Tapan -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Carsey, Jaben Sent: Monday, October 17, 2016 12:56 PM To: Vladimir Olovyannikov ; Michael Zimmermann Cc: Ni, Ruiyu ; Arshi, Shala ; edk2-devel@lists.01.org ; Carsey, Jaben ; Laszlo Ersek Subject: Re: [edk2] [PATCH] GPT Shell Application/Library To the old question about license: I asked our people to check and was told that the license is compatible with our BSD and ok by Intel. To the technical content =E2=80=93 I really like this idea of a shared libr= ary. That would be a great way to share code and not have as much duplicate. -Jaben From: Vladimir Olovyannikov [mailto:vladimir.olovyannikov@broadcom.com] Sent: Monday, October 17, 2016 10:52 AM To: Michael Zimmermann Cc: Laszlo Ersek ; Carsey, Jaben ; Ni, Ruiyu ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH] GPT Shell Application/Library Importance: High Hi Michael, I am absolutely agree with your proposal. In the gpt Shell library/application I had to =E2=80=9Cborrow=E2=80=9D some= stuff from PartitionDxe.c to not reinvent a wheel. If the PartitionDxe maintainer agrees to have a separate library available for everybody, I would move all the GPT-related stuff from the GptWorker (and partially from the PartitionDxe itself) to that independent library. This could be a longer-term task. Right now I just wanted to share the tool which could be useful for anybody who would wish to manage GPT partitions (and/or do a FAT32 format of either a disk or a GPT partition) from within the Shell. What do you think? Thank you, Vladimir From: Michael Zimmermann [mailto:sigmaepsilon92@gmail.com] Sent: October-17-16 12:25 AM To: Vladimir Olovyannikov Cc: Laszlo Ersek; Jaben Carsey; Ni, Ruiyu; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] GPT Shell Application/Library Hi, wouldn't it be better to make a generic gpt parsing library which is independent of the shell so both the shell and PartitionDxe can use it? It may also be useful for other applications which need additional information like the gpt partition names. Thanks Michael On Mon, Oct 17, 2016 at 8:49 AM, Vladimir Olovyannikov > wrote: Thank you Laszlo, Sorry, I missed the fields; it is my first contribution, I will add the required lines, review the source according to your comments and will resubmit the patch. So do you think the command should be _gpt instead of gpt? I was following TFTP and SF commands as a template. Thank you, Vladimir On Oct 16, 2016 1:05 PM, "Laszlo Ersek" > wrote: > > On 10/16/16 07:23, Vladimir Olovyannikov wrote: > > This allows managing (create, delete, modify, fat format) of GPT > > partitions from within UEFI Shell. > > Syntax: > > gpt [device_mapped_name] [parameters...] See usage > > examples in the .uni file > > --- > > .../Library/UefiShellGptCommandLib/FatFormat.c | 611 +++++++ > > .../Library/UefiShellGptCommandLib/FatFormat.h | 111 ++ > > .../Library/UefiShellGptCommandLib/GptWorker.c | 1902 ++++++++++++++++++++ > > .../Library/UefiShellGptCommandLib/GptWorker.h | 186 ++ > > .../UefiShellGptCommandLib.c | 1135 ++++++++++++ > > .../UefiShellGptCommandLib.inf | 79 + > > .../UefiShellGptCommandLib.uni | 117 ++ > > ShellPkg/ShellPkg.dec | 1 + > > ShellPkg/ShellPkg.dsc | 4 + > > 9 files changed, 4146 insertions(+) create mode 100644 > > ShellPkg/Library/UefiShellGptCommandLib/FatFormat.c > > create mode 100644 > > ShellPkg/Library/UefiShellGptCommandLib/FatFormat.h > > create mode 100644 > > ShellPkg/Library/UefiShellGptCommandLib/GptWorker.c > > create mode 100644 > > ShellPkg/Library/UefiShellGptCommandLib/GptWorker.h > > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/UefiShellGptCommandLib.c > > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/UefiShellGptCommandLib.inf > > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/UefiShellGptCommandLib.uni > > This looks like a supremely welcome, long-awaited addition (latest > request: > ), > but it really needs your Signed-off-by, and the Contributed-under line > above it: > > ShellPkg/Contributions.txt > > I would also suggest (simply based on what I've seen elsewhere in > edk2) to keep the copyright notices tightly collected in the file > headings. > > Someone will have to go over all the licenses too -- does the "Marvell > BSD License Option" for example correspond to the 3-clause BSDL? > > On the technical side, I believe that as long as a shell command (or a > command option) is not standardized (in the shell spec), it usually > starts with an underscore (_), so as to prevent future name collisions. > (I could be wrong about this -- I now recall the TFTP command, which > is also not in the 2.2 spec.) > > Just my two cents. > > Thanks > Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel