From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 387B3AC1260 for ; Fri, 12 Jan 2024 09:57:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=LUdUfjgJIDdvyHAInCHwpYg2Mrm/Wz0LQwQRmkFzrrE=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1705053445; v=1; b=c25q9tqlPiL4VGfl3ggBE6j5Was21KwOuaod6JGj7cyReqx7NiaUfrm6eC1qvQYiJszuUWZo ynKK/HF5eyZG08JhZa3NLYzmBvl7MDpWgBa4imawRjilESdjeIhWY2oiL4URHHab8VGt8ZStAQP DaQk/bf9qXyilg5otudB1GXU= X-Received: by 127.0.0.2 with SMTP id 0VzjYY7687511xewfXyW4nCd; Fri, 12 Jan 2024 01:57:25 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.3964.1705053444033966883 for ; Fri, 12 Jan 2024 01:57:25 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8BxXbv_DKFlIoUEAA--.4875S3; Fri, 12 Jan 2024 17:57:19 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Axz4f7DKFleeITAA--.51400S3; Fri, 12 Jan 2024 17:57:16 +0800 (CST) Message-ID: <3900f14b-b051-4039-aa0b-0f67530ca560@loongson.cn> Date: Fri, 12 Jan 2024 17:57:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg To: devel@edk2.groups.io, ray.ni@intel.com, Sunil V L Cc: "Kinney, Michael D" , Laszlo Ersek , Gerd Hoffmann References: From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8Axz4f7DKFleeITAA--.51400S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAOCGWgj6kKHAABsz X-Coremail-Antispam: 1Uk129KBj93XoW7uFykAFy8WFyfJr1rWw4UAwc_yoW8tF47pa yDtF17t3WkWF4DtF18C347KFW5KaykJa98AF4DKr4qvFn7J3WfK3WDKwsY9a4Y9397Xr4j vw4UtwsxuF95ZFcCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJaTc02F40Eb7x2x7xS6ryj6rWUMc02F40En4AKxVAvwIkv4cxYr24l5I8C rVAqjxCE14ACF2xKxwAqx4xG64kEw2xG04xIwI0_Jr0_Gr1l5I8CrVCF0I0E4I0vr27v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUOa7kC6x804xWl14x267AKxVWUJVW8JwAF c2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII 0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xv wVC0I7IYx2IY6xkF7I0E14v26r4j6F4UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4 x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc80 4VCY07AIYIkI8VC2zVCFFI0UMc02F40Eb7x2x7xS6ryj6rWUMc02F40En4AKxVAvwIkv4c xYr24l5I8CrVAqjxCE14ACF2xKxwAqx4xG64kEw2xG04xIwI0_Jr0_Gr1l5I8CrVCF0I0E 4I0vr24lYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4 IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCjr7xvwVCIw2I0I7xG6c02F41l42xK82IYc2Ij 64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUGVWUWwC20s026x 8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE 2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42 xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF 7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07URHqxUUUUU= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: UwTeQIiJCArht4e725h4mNEYx7686176AA= Content-Type: multipart/alternative; boundary="------------veJM6amEhvhwJ0x5aEuMVuGu" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=c25q9tql; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------veJM6amEhvhwJ0x5aEuMVuGu Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Ray, OK, here I come. [Ray] INF is a good question. [Ray] There are two options: [Ray]    Re-use current INF file. [Ray]    Create a new INF under LoongArch64 folder. [Ray] If the INF content can be shared a lot between different archs. Single INF is better. [Ray] I am just afraid sometimes we just mixed INF contents for different archs together into one INF, which makes the INF hard to read. [Ray] So, it depends on how many contents can be shared. I think it is almost difficult to share, because currently common files only work with IA32 and X86, other ARCHs cannot share files with IA32 and X64. Thanks, Chao On 2024/1/12 17:12, Ni, Ray wrote: > > Sunil, > > I would like to hear your feedback regarding locations of following > RiscV64 components in UefiCpuPkg: > > * UefiCpuPkg/Library/BaseRiscV64CpuExceptionHandlerLib/ > > * UefiCpuPkg/Library/BaseRiscV64CpuTimerLib/ > > * UefiCpuPkg/CpuDxeRiscV64/ > > * UefiCpuPkg/CpuTimerDxeRiscV64/ > > I would like to move them to the following new locations accordingly: > > * UefiCpuPkg/Library/CpuExceptionHandlerLib/RiscV64/ > > * UefiCpuPkg/Library/CpuTimerLib/RiscV64/ > > * UefiCpuPkg/CpuDxe/RiscV64/ > > * UefiCpuPkg/CpuTimerDxe/RiscV64/ > > I want to avoid too many similar drivers in root folder, and too many > libraries in Library folder. > > Movement of the first 3 ones put the RiscV components under existing > folders. > > Movement of the last one creates the UefiCpuPkg/CpuTimerDxe folder, > that could be potentially shared by other archs as well. > > I raised similar comments to Chao Li who is working on LoongArch upstream. > > The location movement follows the 2nd pattern defined by edk2 coding > standard: > > Driver’s location could be: > > [[]] > > or > > [/[/]] > > Library’s location could be: > > |[[]][]| > |  or| > |[]/[[/]]| > > Thanks, > > Ray > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113706): https://edk2.groups.io/g/devel/message/113706 Mute This Topic: https://groups.io/mt/103679850/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------veJM6amEhvhwJ0x5aEuMVuGu Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Ray,

OK, here I come.

[Ray] INF is a good question.

[Ray] There are two options:

[Ray]    Re-use current INF file.

[Ray]    Create a new INF under LoongArch64 folder.

 

[Ray] If the INF content can be shared a lot between different archs. Single INF is better.

[Ray] I am just afraid sometimes we just mixed INF contents for different archs together into one INF, which makes the INF hard to read.

[Ray] So, it depends on how many contents can be shared.

I think it is almost difficult to share, because currently common files only work with IA32 and X86, other ARCHs cannot share files with IA32 and X64.

Thanks,
Chao
On 2024/1/12 17:12, Ni, Ray wrote:

Sunil,

I would like to hear your feedback regarding locations of following RiscV64 components in UefiCpuPkg:

* UefiCpuPkg/Library/BaseRiscV64CpuExceptionHandlerLib/

* UefiCpuPkg/Library/BaseRiscV64CpuTimerLib/

* UefiCpuPkg/CpuDxeRiscV64/

* UefiCpuPkg/CpuTimerDxeRiscV64/

 

I would like to move them to the following new locations accordingly:

* UefiCpuPkg/Library/CpuExceptionHandlerLib/RiscV64/

* UefiCpuPkg/Library/CpuTimerLib/RiscV64/

* UefiCpuPkg/CpuDxe/RiscV64/

* UefiCpuPkg/CpuTimerDxe/RiscV64/

 

I want to avoid too many similar drivers in root folder, and too many libraries in Library folder.

 

Movement of the first 3 ones put the RiscV components under existing folders.

Movement of the last one creates the UefiCpuPkg/CpuTimerDxe folder, that could be potentially shared by other archs as well.

 

I raised similar comments to Chao Li who is working on LoongArch upstream.

 

The location movement follows the 2nd pattern defined by edk2 coding standard:

Driver’s location could be:

<Feature><Phase>[<CpuArch>[<Vendor>]]

  or

<Feature><Phase>[/<CpuArch>[/<Vendor>]]

 

Library’s location could be:

<Phase>[<CpuArch>[<Vendor>]]<LibraryClassName>[<Dependency>]
  or
<Phase><LibraryClassName>[<Dependency>]/[<CpuArch>[/<Vendor>]]

 

 

 

Thanks,

Ray

_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#113706) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------veJM6amEhvhwJ0x5aEuMVuGu--