public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pete Batard" <pete@akeo.ie>
To: devel@edk2.groups.io, jmcneill@invisible.ca
Subject: Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RPi4: Fix SDHC interrupt numbers.
Date: Tue, 31 Dec 2019 11:39:23 +0100	[thread overview]
Message-ID: <39052ebe-f126-6c84-5d95-8c91297216bd@akeo.ie> (raw)
In-Reply-To: <f060fe8604d538baead3f57b173a73739920f21e.1577714594.git.jmcneill@invisible.ca>

Many thanks for fixing these.

Reviewed-by: Pete Batard <pete@akeo.ie>

On 2019-12-30 15:07, Jared McNeill wrote:
> According to the bcm2711 devicetree, the Arasan SDHCI uses GIC SPI 126
> and the Broadcom SDHost uses GIC SPI 120.
> 
> Signed-off-by: Jared McNeill <jmcneill@invisible.ca>
> ---
>   Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
> index 57ee411a61..56d15c3927 100644
> --- a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
> +++ b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
> @@ -33,7 +33,7 @@ Device (SDC1)
>       Name (RBUF, ResourceTemplate ()
>       {
>         MEMORY32FIXED (ReadWrite, 0xFE300000, 0x100,)
> -      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0x5E }
> +      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0x9E }
>       })
>       Return (RBUF)
>     }
> @@ -76,7 +76,7 @@ Device (SDC2)
>       Name (RBUF, ResourceTemplate ()
>       {
>         MEMORY32FIXED (ReadWrite, 0xFE202000, 0x100,)
> -      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0x58 }
> +      Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0x98 }
>       })
>       Return (RBUF)
>     }
> 


  reply	other threads:[~2019-12-31 10:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-30 14:07 [edk2-platforms][PATCH] Platform/RPi4: Fix SDHC interrupt numbers Jared McNeill
2019-12-31 10:39 ` Pete Batard [this message]
2019-12-31 13:30   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-12-31 14:47     ` Pete Batard
2019-12-31 16:15       ` Philippe Mathieu-Daudé
2020-02-14  8:58 ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39052ebe-f126-6c84-5d95-8c91297216bd@akeo.ie \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox