From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web11.1902.1577788766694638520 for ; Tue, 31 Dec 2019 02:39:27 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=Uw8okDUB; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.68, mailfrom: pete@akeo.ie) Received: by mail-wr1-f68.google.com with SMTP id d16so34851391wre.10 for ; Tue, 31 Dec 2019 02:39:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=bg34IiRzKHKJDOuUYK3Jxs/vgKKsrGUDW999kCHbw40=; b=Uw8okDUB6GHBgaeaw856TZMoD0Odm55BOQJTNMgPQNJsmyaGb28j/BlJgDmYcAqmf6 axMlBE3Efcx7hTmPCstzWqEtETidTN64b+n8wDEbABWWhQ9Zazq//48zfN/OHKtuNMiJ DQcbyr0ifWzj0TK1HDgZPeju0YZCO9cFy2lGHMErIF3vKT4h+DHVX446qNsyfHWlQFrM rwcoxUiLE124McZtC0NDaaOVBPVanfODfwYko8aGEEwuZ148Ny2M2NnFMUdGe5P6t7lk SYnrJeqlY6FXFilUNg4ijP57Dy2Ge+xx2bQfXzFxkX2jd+0NcHFHCjJukv6f1Kox2CWR gusw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bg34IiRzKHKJDOuUYK3Jxs/vgKKsrGUDW999kCHbw40=; b=WzXfs2dZt+jEWZB1JaCXv+qF34KKw8++/UArU5ZBdrbqV+nUs+VheuzkV0VErT1QHz 11qgK95TyyFSm0sCKRWzF+zXTQpHlNmJxird5IEwwuXCHeSzincfFq9LaIgSNc66QRVh zYvDF+wNc86PfCo97RjKCzB7+vK7HKdtU1nBpokNR5+dMZMu2uiy9Q4meKKcjUZikJ7u yuofsx4vowFXxQ3+XEOPjAXsJe14magZ/Z+gBk9TLd+4UzE6CHtRHWLvjZuXyuNfPCS+ PFhGuQKkkCVwizGcaiWRk8qSOdGFEUdUrZDFDAbUCTiFJQEG1vA7KZRLT2j1jxAEV2U0 re/Q== X-Gm-Message-State: APjAAAXSvYIU179h5Nk/qaOaxKclPxex0VwXPPHGSmhexIdwsIbzSuE7 gBrysLPvZUg411wEZFktGw5G6w== X-Google-Smtp-Source: APXvYqxwsncW4QbqLi0Ycrq/IoHKYFMRQVVgA+UhugIy5UGtzdFAaekm+nkiHX1N1HgUt5/Z8Bir/g== X-Received: by 2002:adf:e74f:: with SMTP id c15mr74630270wrn.274.1577788765311; Tue, 31 Dec 2019 02:39:25 -0800 (PST) Return-Path: Received: from ?IPv6:2a01:e34:ec6c:8350:3916:716b:f980:24bc? ([2a01:e34:ec6c:8350:3916:716b:f980:24bc]) by smtp.googlemail.com with ESMTPSA id k13sm48412894wrx.59.2019.12.31.02.39.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Dec 2019 02:39:24 -0800 (PST) Subject: Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RPi4: Fix SDHC interrupt numbers. To: devel@edk2.groups.io, jmcneill@invisible.ca References: From: "Pete Batard" Message-ID: <39052ebe-f126-6c84-5d95-8c91297216bd@akeo.ie> Date: Tue, 31 Dec 2019 11:39:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Many thanks for fixing these. Reviewed-by: Pete Batard On 2019-12-30 15:07, Jared McNeill wrote: > According to the bcm2711 devicetree, the Arasan SDHCI uses GIC SPI 126 > and the Broadcom SDHost uses GIC SPI 120. > > Signed-off-by: Jared McNeill > --- > Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl > index 57ee411a61..56d15c3927 100644 > --- a/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl > +++ b/Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl > @@ -33,7 +33,7 @@ Device (SDC1) > Name (RBUF, ResourceTemplate () > { > MEMORY32FIXED (ReadWrite, 0xFE300000, 0x100,) > - Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0x5E } > + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0x9E } > }) > Return (RBUF) > } > @@ -76,7 +76,7 @@ Device (SDC2) > Name (RBUF, ResourceTemplate () > { > MEMORY32FIXED (ReadWrite, 0xFE202000, 0x100,) > - Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0x58 } > + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 0x98 } > }) > Return (RBUF) > } >