public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Philippe Mathieu-Daude <philmd@redhat.com>, devel@edk2.groups.io
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses
Date: Fri, 3 Jan 2020 14:11:05 +0100	[thread overview]
Message-ID: <3915a531-b505-190f-0db0-1f19358d73a0@redhat.com> (raw)
In-Reply-To: <20200102152553.11976-1-philmd@redhat.com>

Hi,

On 01/02/20 16:25, Philippe Mathieu-Daude wrote:
> Last month I cleaned the git-history incorrect email
> addresses: https://edk2.groups.io/g/devel/message/51834
> but today I noticed more incorrect addresses got committed
> (see caa917491a4..33a3293651).
> To avoid having the same cleanup in the future, fix the
> problem once for all by having PatchCheck doing this
> automatically (on merge).
> 
> Since we already have code to check email address in
> PatchCheck, factor the code out to reuse it, and
> add checks for committer/author addresses.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> 
> Philippe Mathieu-Daude (4):
>   BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck
>   BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked
>   BaseTools/PatchCheck.py: Check the patch author email address
>   BaseTools/PatchCheck.py: Check the committer email address
> 
>  BaseTools/Scripts/PatchCheck.py | 99 +++++++++++++++++++++++----------
>  1 file changed, 69 insertions(+), 30 deletions(-)
> 

still struggling with my email backlog, so I'm going to skip this for now.

Thanks
Laszlo


  parent reply	other threads:[~2020-01-03 13:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02 15:25 [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses Philippe Mathieu-Daudé
2020-01-02 15:25 ` [PATCH 1/4] BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck Philippe Mathieu-Daudé
2020-01-02 15:25 ` [PATCH 2/4] BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked Philippe Mathieu-Daudé
2020-01-02 15:25 ` [PATCH 3/4] BaseTools/PatchCheck.py: Check the patch author email address Philippe Mathieu-Daudé
2020-01-02 15:25 ` [RFC PATCH 4/4] BaseTools/PatchCheck.py: Check the committer " Philippe Mathieu-Daudé
2020-01-03 22:59   ` Jordan Justen
2020-01-04 11:38     ` Philippe Mathieu-Daudé
2020-01-03 13:11 ` Laszlo Ersek [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-01-02 15:24 [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses Philippe Mathieu-Daudé
2020-01-02 15:36 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3915a531-b505-190f-0db0-1f19358d73a0@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox