From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120])
 by mx.groups.io with SMTP id smtpd.web11.3588.1578057081926922927
 for <devel@edk2.groups.io>;
 Fri, 03 Jan 2020 05:11:22 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JdYWgRUO;
 spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1578057081;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=AXpq/wyhvc3G+t41X+5leyxrMM6mlZp2yQc1B9lQ9tI=;
	b=JdYWgRUO6mxccUZVjrqDSfXyOUc2ogpP8f27FO4wpvvuyarK+u47yaqbVxHkQThfNcNohr
	NFcVFQbL1FktVRiWMwt6FolXkedL5WuaD+PLDlQ7qfj2Z4Kbdta92HQqmffzv5yp2n9p+t
	zTu+JldDMVrgTSZFA/bGeibbdvIQn9M=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-48-zOPZ-e6yN8OCuIteTfHcKg-1; Fri, 03 Jan 2020 08:11:11 -0500
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E8E6D10054E3;
	Fri,  3 Jan 2020 13:11:09 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-245.ams2.redhat.com [10.36.116.245])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 57BFAA4B60;
	Fri,  3 Jan 2020 13:11:06 +0000 (UTC)
Subject: Re: [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses
To: Philippe Mathieu-Daude <philmd@redhat.com>, devel@edk2.groups.io
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
 Liming Gao <liming.gao@intel.com>, Jordan Justen <jordan.l.justen@intel.com>
References: <20200102152553.11976-1-philmd@redhat.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <3915a531-b505-190f-0db0-1f19358d73a0@redhat.com>
Date: Fri, 3 Jan 2020 14:11:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200102152553.11976-1-philmd@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-MC-Unique: zOPZ-e6yN8OCuIteTfHcKg-1
X-Mimecast-Spam-Score: 0
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Hi,

On 01/02/20 16:25, Philippe Mathieu-Daude wrote:
> Last month I cleaned the git-history incorrect email
> addresses: https://edk2.groups.io/g/devel/message/51834
> but today I noticed more incorrect addresses got committed
> (see caa917491a4..33a3293651).
> To avoid having the same cleanup in the future, fix the
> problem once for all by having PatchCheck doing this
> automatically (on merge).
> 
> Since we already have code to check email address in
> PatchCheck, factor the code out to reuse it, and
> add checks for committer/author addresses.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> 
> Philippe Mathieu-Daude (4):
>   BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck
>   BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked
>   BaseTools/PatchCheck.py: Check the patch author email address
>   BaseTools/PatchCheck.py: Check the committer email address
> 
>  BaseTools/Scripts/PatchCheck.py | 99 +++++++++++++++++++++++----------
>  1 file changed, 69 insertions(+), 30 deletions(-)
> 

still struggling with my email backlog, so I'm going to skip this for now.

Thanks
Laszlo