From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web12.2413.1571677160315589337 for ; Mon, 21 Oct 2019 09:59:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=sPo1ZOue; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.68, mailfrom: pete@akeo.ie) Received: by mail-wm1-f68.google.com with SMTP id p7so14172975wmp.4 for ; Mon, 21 Oct 2019 09:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qNc0L13tA9IbyPKFeSohZBc6iwY4xAvCI3KPrjKGXto=; b=sPo1ZOueW/YmyvlDLFlp27AeDPaut9QK/vsF86oDe9FgPlObR/tyy5lH6n9rnx/wY1 0WsFkpAVR2EzzTwJY52Uu8PmN4VCDH6CYpvlWt07iFpahnMxupL5MOH1Ctlt+LO/zP+J SrqFpF2koXLKj5MM++/fAP1a1lc1C6rcc7V/8yq/yBFaw0ja3kCxC5vUqrXV2BP9wYAQ g3lG+UqB+x9BTNp+Jzfxnvf6Y8QoxIDru5xN++he9qhwjWdZ33Zj0UGs0o3fkm8naSdK 6t15nhcgNMtwlo9/4/Xhst81wsCbM6qgqj1eoL7zJaUkR1urj3MuhYSRxHZMAc7+6ZpJ MoKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qNc0L13tA9IbyPKFeSohZBc6iwY4xAvCI3KPrjKGXto=; b=bg5glWTi1/tb8Rf5dK+TnKFNQ5vuS0vByjdL6QgHjoWF3NOsXgneqveilDbTdfPybx J+26VTHF2Jv2vNUEUG2fy1MbY8+fhkRfXpuwljvpAvTqiJHNK5jwVPLtZvbtxtkb5jMe yxRHSuYYAbAg0u34s4IkMupiq569JF1/7kYVg+4UTxXTvtoMpQ2/OBRxP+ZVs95ephcs zbKC4/lvuJ4Le2LmCSwF3oJgGEI+OFQBU5KTrgiYOerTjDQLhU38CYwSvID0Wmb/al/h qaaYlWWWQ5TlpYc26X01H/0wiN5ysKRq8cuuNkrBabUnMYygqtG674DcDmflphJFktA7 Z+6w== X-Gm-Message-State: APjAAAUp2pZeKDLuSwzrBEDwqEjELll9XcsCTmJkIT0zZWVuwvfm5xwm sofl3xdze7uJVEmxoWyc5B0ajYd4NdlgKQ== X-Google-Smtp-Source: APXvYqxUA2oVQAtKRM7aFyi8JIaOqZQw7c7UpQDCFPupifpic4wvksLp0j+pydv8r7p/6wr9qNQ4aQ== X-Received: by 2002:a05:600c:29a:: with SMTP id 26mr21523555wmk.127.1571677158148; Mon, 21 Oct 2019 09:59:18 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.44.122]) by smtp.googlemail.com with ESMTPSA id o6sm6889527wrx.89.2019.10.21.09.59.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Oct 2019 09:59:17 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RPi3: Restructure platform in preparation for Pi 4 To: Leif Lindholm Cc: Ard Biesheuvel , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , edk2-devel-groups-io References: <20191021112506.1456-1-pete@akeo.ie> <6baf8d74-3639-593c-419a-c4e8d4e6b7d0@redhat.com> <1a295e8f-a679-0a03-283a-850e93c97bab@akeo.ie> <20191021134628.GC16820@bivouac.eciton.net> <240b08f4-e91e-8003-f7a6-5b0e1169b4b6@akeo.ie> <20191021143922.GE16820@bivouac.eciton.net> From: "Pete Batard" Message-ID: <391a53c4-1d3e-11a7-fd4c-81d0f0f5f154@akeo.ie> Date: Mon, 21 Oct 2019 17:59:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191021143922.GE16820@bivouac.eciton.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 2019.10.21 15:39, Leif Lindholm wrote: > On Mon, Oct 21, 2019 at 03:28:37PM +0100, Pete Batard wrote: >> Hi Leif, >> >> On 2019.10.21 14:46, Leif Lindholm wrote: >>> On Mon, Oct 21, 2019 at 03:24:47PM +0200, Ard Biesheuvel wrote: >>>> On Mon, 21 Oct 2019 at 15:09, Philippe Mathieu-Daudé wrote: >>>>>> If anything, I guess we could consider that the non-osi patch should >>>>>> come first. Still, whatever we do here, as long as only one of non-osi >>>>>> and platform is applied, builds are going to be broken, and there is no >>>>>> way to fix that unless you do consider the set of platforms + non-osi as >>>>>> a single patch. >>>>> >>>>> Agreed, this is a egg/chicken problem. >>>> >>>> I dealt with this in the past by just making sure the non-osi and >>>> platform changes are applied at the same time. So it is good to make >>>> note of this in the cover letter, but other than that, there is no way >>>> we can apply interdependent changes to two separate repositories at >>>> the same time without either breaking bisect for one of them, or >>>> making a huge effort to add temporary code, defines etc that will be >>>> removed again right after the changes have landed. >>> >>> Agreed. My preference would be to treat edk2-non-osi as the chicken, >>> and edk2-platforms the egg. I could put the requisite edk2-non-osi >>> hash into the edk2-platforms commit message before pushing, adding a >>> line like: >>> >>> "This commit requires the edk2-non-osi in use to contain commit >>> in order to build." >>> >>> If I'm feeling nitpicky, that could replace the comment >>> "No other changes are being applied at this stage." >>> >>> Pete: would you be OK with those two changes? >> >> Sounds good. Feel free to go ahead with these changes, thanks. > > In that case: > Reviewed-by: Leif Lindholm > Pushed as 03f36b8fcfb7. > > Thanks! Great, thanks! > Do you know when the Pi4 upstreaming is likely to start? Well, as opposed to what was the case for the Pi 3 when we started upstreaming, we don't have a fully working Pi 4 platform yet (or at least, there's a fair amount of work left before we can put a checkmark against all the major elements we would like to see checked). So what we'll probably be aiming at is figure out some kind of minimum viable platform that can be officially submitted, that may not do much, but that we can then build upon in a more public and official manner. Now, since there are quite a few people involved on this one, and we need to discuss this internally, I doubt we're going to start publicly submitting anything Pi 4 related before one week at least. Figuring out what we want to submit, or even if we're truly at a stage where we have something proper to submit, is the current next step for us, as we wanted to make sure mainline was okay with the structure we are planning to go with before moving further (which makes the quick turnover on this patchset much appreciated!). For the record, we have a couple of staging repos at: https://github.com/samerhaj/edk2-platforms/tree/pi4_staging https://github.com/samerhaj/edk2-non-osi/tree/pi4_staging as well as Andrei Warkentin's main development tree (over which the repos above are based) at: https://github.com/andreiw/lampone-edk2-platforms/commits/pi4-hack https://github.com/andreiw/lampone-edk2-platforms/commits/master Of course, these are very much WIP still, and not something we can use to generate a patchset from. At this stage, I would say that our biggest issue, apart from various drivers not being finalized, is that mainline ARM Trusted Firmware has recently integrated support for the Pi 4 in a way that is completely different from what we went for (because there was no Trusted Firmware to start with, Andrei had to figure out his own, which was based on extending the Pi 3's). For starters they went for a BL31 only approach: https://github.com/ARM-software/arm-trusted-firmware/commit/f5cb15b0c886afaa41c5d3dad8e859b6a41f76ab. This means that, depending on how complex it might be to retrofit official ATF, we may submit an initial patchset that relies on our own binaries, and leave the switching to official ATF done at a later date... > As you may have seen from my autoresponder, I'm traveling this week > and next. Yes. We'll take that into account. I believe you might also meet with Samer (El-Haj-Mahmoud), who is participating in the Pi 4 porting effort (the first repos above are his). So feel free to ask for his views as well. I guess I'll wish you some pleasant and safe travels then. Regards, /Pete