public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Isaac Oram" <isaac.w.oram@intel.com>
To: devel@edk2.groups.io
Cc: Isaac Oram <isaac.w.oram@intel.com>,
	Sai Chaganty <rangasai.v.chaganty@intel.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Rebecca Cran <quic_rcran@quicinc.com>
Subject: [edk2-devel][edk2-platforms][PATCH V2 1/1] AdvancedFeaturePkg: Improve sample build instructions
Date: Wed, 18 Jan 2023 17:20:37 -0800	[thread overview]
Message-ID: <393d7af9bcae7e604ea149c80fb8d1b2c97c29e7.1674091122.git.isaac.w.oram@intel.com> (raw)
In-Reply-To: <cover.1674091122.git.isaac.w.oram@intel.com>

V1: Make the Windows build example current working directory based instead of
arbitrary.
V2: Fix case mismatch in edk2 repo local name.

Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Rebecca Cran <quic_rcran@quicinc.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
 Features/Intel/AdvancedFeaturePkg/Readme.md | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/Features/Intel/AdvancedFeaturePkg/Readme.md b/Features/Intel/AdvancedFeaturePkg/Readme.md
index ba50560328..20f456bebe 100644
--- a/Features/Intel/AdvancedFeaturePkg/Readme.md
+++ b/Features/Intel/AdvancedFeaturePkg/Readme.md
@@ -19,19 +19,21 @@ Supported build targets
 * GCC5
 
 ## Windows Example:
-With current working directory at O:\
-
 git clone https://github.com/tianocore/edk2.git
 
+git clone https://github.com/tianocore/edk2-non-osi.git
+
 git clone https://github.com/tianocore/edk2-platforms.git
 
-set workspace=O:\
+set workspace=%cd%
 
-set EDK_TOOLS_PATH=O:\Edk2\BaseTools
+set EDK_TOOLS_PATH=%workspace%\edk2\BaseTools
 
-set packages_path=O:\edk2;O:\edk2-non-osi;O:\edk2-platforms\Platform\Intel;O:\edk2-platforms\Silicon\Intel;O:\edk2-platforms\Platform\Qemu;O:\edk2-platforms\Silicon\Qemu;O:\edk2-platforms\Features\Intel;O:\edk2-platforms\Features\Intel\Debugging;O:\edk2-platforms\Features\Intel\Network;O:\edk2-platforms\Features\Intel\OutOfBandManagement;O:\edk2-platforms\Features\Intel\PowerManagement;O:\edk2-platforms\Features\Intel\SystemInformation;O:\edk2-platforms\Features\Intel\UserInterface
+set packages_path=%workspace%\edk2;%workspace%\edk2-non-osi;%workspace%\edk2-platforms\Platform\Intel;%workspace%\edk2-platforms\Silicon\Intel;%workspace%\edk2-platforms\Platform\Qemu;%workspace%\edk2-platforms\Silicon\Qemu;%workspace%\edk2-platforms\Features\Intel;%workspace%\edk2-platforms\Features\Intel\Debugging;%workspace%\edk2-platforms\Features\Intel\Network;%workspace%\edk2-platforms\Features\Intel\OutOfBandManagement;%workspace%\edk2-platforms\Features\Intel\PowerManagement;%workspace%\edk2-platforms\Features\Intel\SystemInformation;%workspace%\edk2-platforms\Features\Intel\UserInterface
 
-cd \edk2
+cd %workspace%\edk2
+
+git submodule update --init
 
 edksetup.bat Rebuild
 
-- 
2.39.0.windows.1


       reply	other threads:[~2023-01-19  1:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1674091122.git.isaac.w.oram@intel.com>
2023-01-19  1:20 ` Isaac Oram [this message]
2023-01-19 15:55   ` [edk2-devel][edk2-platforms][PATCH V2 1/1] AdvancedFeaturePkg: Improve sample build instructions Rebecca Cran
2023-02-09  1:44     ` Isaac Oram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=393d7af9bcae7e604ea149c80fb8d1b2c97c29e7.1674091122.git.isaac.w.oram@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox