* [PATCH 1/3] ArmPkg: Fix typos
2022-12-02 9:25 [PATCH 0/3] Fix some typos Dongdong Zhang
@ 2022-12-02 9:25 ` Dongdong Zhang
2022-12-02 9:25 ` [PATCH 2/3] ArmPlatformPkg: " Dongdong Zhang
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Dongdong Zhang @ 2022-12-02 9:25 UTC (permalink / raw)
To: devel; +Cc: zhuwenjun, zhengyu, jinyanjiang, Dongdong Zhang
Fix some typos in ArmPkg directory.
Signed-off-by: Dongdong Zhang <zhangdongdong@eswincomputing.com>
---
ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c | 2 +-
ArmPkg/Include/Library/OemMiscLib.h | 2 +-
ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c | 6 +++---
ArmPkg/Library/ArmLib/AArch64/ArmLibSupport.S | 2 +-
ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S | 2 +-
ArmPkg/Library/SemihostLib/Arm/GccSemihost.S | 2 +-
ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 6 +++---
ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 2 +-
.../Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | 2 +-
9 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c b/ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c
index 1fc448b9bf..a9cff0c395 100644
--- a/ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c
+++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c
@@ -40,7 +40,7 @@ STATIC CONST SCMI_PROTOCOL_ENTRY Protocols[] = {
install Base, Clock and Performance protocols.
@param[in] SystemTable A pointer to boot time system table.
- @retval EFI_SUCCESS Driver initalized successfully.
+ @retval EFI_SUCCESS Driver initialized successfully.
@retval EFI_UNSUPPORTED If SCMI base protocol version is not supported.
@retval !(EFI_SUCCESS) Other errors.
**/
diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/OemMiscLib.h
index 541274999e..02af6afdc2 100644
--- a/ArmPkg/Include/Library/OemMiscLib.h
+++ b/ArmPkg/Include/Library/OemMiscLib.h
@@ -86,7 +86,7 @@ OemGetCpuFreq (
@param ProcessorIndex Index of the processor to get the information for.
@param ProcessorStatus Processor status.
- @param ProcessorCharacteristics Processor characteritics.
+ @param ProcessorCharacteristics Processor characteristics.
@param MiscProcessorData Miscellaneous processor information.
@return TRUE on success, FALSE on failure.
diff --git a/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c b/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c
index 6dae7a9121..7083f6f514 100644
--- a/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c
+++ b/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c
@@ -663,9 +663,9 @@ DisassembleThumbInstruction (
// ITSTATE = cond:mask OpCode[7:4]:OpCode[3:0]
// ITSTATE[7:5] == cond[3:1]
// ITSTATE[4] == 1st Instruction cond[0]
- // ITSTATE[3] == 2st Instruction cond[0]
- // ITSTATE[2] == 3st Instruction cond[0]
- // ITSTATE[1] == 4st Instruction cond[0]
+ // ITSTATE[3] == 2nd Instruction cond[0]
+ // ITSTATE[2] == 3rd Instruction cond[0]
+ // ITSTATE[1] == 4th Instruction cond[0]
// ITSTATE[0] == 1 4 instruction IT block. 0 means 0,1,2 or 3 instructions
// 1st one in ITSTATE low bits defines the number of instructions
Mask = (OpCode & 0xf);
diff --git a/ArmPkg/Library/ArmLib/AArch64/ArmLibSupport.S b/ArmPkg/Library/ArmLib/AArch64/ArmLibSupport.S
index ba0ec5682b..c402154e4c 100644
--- a/ArmPkg/Library/ArmLib/AArch64/ArmLibSupport.S
+++ b/ArmPkg/Library/ArmLib/AArch64/ArmLibSupport.S
@@ -20,7 +20,7 @@ ASM_FUNC(ArmReadMidr)
ret
ASM_FUNC(ArmCacheInfo)
- mrs x0, ctr_el0 // Read from Cache Type Regiter (CTR)
+ mrs x0, ctr_el0 // Read from Cache Type Register (CTR)
ret
ASM_FUNC(ArmGetInterruptState)
diff --git a/ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S b/ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S
index 0ae75e4cb9..6a64219f67 100644
--- a/ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S
+++ b/ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S
@@ -23,7 +23,7 @@
ASM_FUNC(ArmIsMpCore)
- mrs x0, mpidr_el1 // Read EL1 Multiprocessor Affinty Reg (MPIDR)
+ mrs x0, mpidr_el1 // Read EL1 Multiprocessor Affinity Reg (MPIDR)
and x0, x0, #MPIDR_U_MASK // U Bit clear, the processor is part of a multiprocessor system
lsr x0, x0, #MPIDR_U_BIT
eor x0, x0, #1
diff --git a/ArmPkg/Library/SemihostLib/Arm/GccSemihost.S b/ArmPkg/Library/SemihostLib/Arm/GccSemihost.S
index d6f81ec2c9..b1992b605f 100644
--- a/ArmPkg/Library/SemihostLib/Arm/GccSemihost.S
+++ b/ArmPkg/Library/SemihostLib/Arm/GccSemihost.S
@@ -16,7 +16,7 @@
BKPT 0xAB for ARMv7-M (Thumb-2 only)
R0 - operation type
- R1 - block containing all other parametes
+ R1 - block containing all other parameters
lr - must be saved as svc instruction will cause an svc exception and write
the svc lr register. That happens to be the one we are using, so we must
diff --git a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c
index d55aff7620..c61d6f7b77 100644
--- a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c
+++ b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c
@@ -31,7 +31,7 @@
return it contains the response parameters.
@param [out] RetVal Pointer to return the response value.
- @retval EFI_SUCCESS Request successfull.
+ @retval EFI_SUCCESS Request successful.
@retval EFI_INVALID_PARAMETER A parameter is invalid.
@retval EFI_NOT_READY Callee is busy or not in a state to handle
this request.
@@ -134,7 +134,7 @@ SendMemoryPermissionRequest (
@param [in] BaseAddress Base address for the memory region.
@param [out] MemoryAttributes Pointer to return the memory attributes.
- @retval EFI_SUCCESS Request successfull.
+ @retval EFI_SUCCESS Request successful.
@retval EFI_INVALID_PARAMETER A parameter is invalid.
@retval EFI_NOT_READY Callee is busy or not in a state to handle
this request.
@@ -193,7 +193,7 @@ GetMemoryPermissions (
@param [in] Length Length of the memory region.
@param [in] Permissions Memory access controls attributes.
- @retval EFI_SUCCESS Request successfull.
+ @retval EFI_SUCCESS Request successful.
@retval EFI_INVALID_PARAMETER A parameter is invalid.
@retval EFI_NOT_READY Callee is busy or not in a state to handle
this request.
diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
index a5d635da9e..dd207a62f7 100644
--- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
+++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
@@ -39,7 +39,7 @@ OemGetCpuFreq (
@param ProcessorIndex Index of the processor to get the information for.
@param ProcessorStatus Processor status.
- @param ProcessorCharacteristics Processor characteritics.
+ @param ProcessorCharacteristics Processor characteristics.
@param MiscProcessorData Miscellaneous processor information.
@return TRUE on success, FALSE on failure.
diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c
index b961be2133..8d83f0723d 100644
--- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c
+++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c
@@ -79,7 +79,7 @@ SmbiosProcessorHasSeparateCaches (
return SeparateCaches;
}
-/** Checks if ther ARM64 SoC ID SMC call is supported
+/** Checks if the ARM64 SoC ID SMC call is supported
@return Whether the ARM64 SoC ID call is supported.
**/
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/3] ArmPlatformPkg: Fix typos
2022-12-02 9:25 [PATCH 0/3] Fix some typos Dongdong Zhang
2022-12-02 9:25 ` [PATCH 1/3] ArmPkg: Fix typos Dongdong Zhang
@ 2022-12-02 9:25 ` Dongdong Zhang
2022-12-02 9:25 ` [PATCH 3/3] ArmVirtPkg: " Dongdong Zhang
2022-12-12 14:58 ` [edk2-devel] [PATCH 0/3] Fix some typos Michael Kubacki
3 siblings, 0 replies; 8+ messages in thread
From: Dongdong Zhang @ 2022-12-02 9:25 UTC (permalink / raw)
To: devel; +Cc: zhuwenjun, zhengyu, jinyanjiang, Dongdong Zhang
Fix some typos in ArmPlatformPkg directory.
Signed-off-by: Dongdong Zhang <zhangdongdong@eswincomputing.com>
---
ArmPlatformPkg/ArmPlatformPkg.dec | 2 +-
ArmPlatformPkg/Include/Library/LcdPlatformLib.h | 2 +-
ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c | 2 +-
ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
index 7b5d7e6cb5..c905f97d2c 100644
--- a/ArmPlatformPkg/ArmPlatformPkg.dec
+++ b/ArmPlatformPkg/ArmPlatformPkg.dec
@@ -97,7 +97,7 @@
gArmPlatformTokenSpaceGuid.PcdPL111LcdBase|0x0|UINT32|0x00000026
gArmPlatformTokenSpaceGuid.PcdArmHdLcdBase|0x0|UINT32|0x00000027
- ## Default size for display modes upto 1920x1080 (1920 * 1080 * 4 Bytes Per Pixel)
+ ## Default size for display modes up to 1920x1080 (1920 * 1080 * 4 Bytes Per Pixel)
gArmPlatformTokenSpaceGuid.PcdArmLcdDdrFrameBufferSize|0x7E9000|UINT32|0x00000043
## If set, framebuffer memory will be reserved and mapped in the system RAM
gArmPlatformTokenSpaceGuid.PcdArmLcdDdrFrameBufferBase|0x0|UINT64|0x00000044
diff --git a/ArmPlatformPkg/Include/Library/LcdPlatformLib.h b/ArmPlatformPkg/Include/Library/LcdPlatformLib.h
index b5628ece56..2049e5ef60 100644
--- a/ArmPlatformPkg/Include/Library/LcdPlatformLib.h
+++ b/ArmPlatformPkg/Include/Library/LcdPlatformLib.h
@@ -220,7 +220,7 @@ typedef struct {
@param[in] Handle Handle to the LCD device instance.
- @retval EFI_SUCCESS Plaform library initialized successfully.
+ @retval EFI_SUCCESS Platform library initialized successfully.
@retval !(EFI_SUCCESS) Other errors.
**/
EFI_STATUS
diff --git a/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c b/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c
index d01c910f6e..cea7ce2cc7 100644
--- a/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c
+++ b/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c
@@ -287,7 +287,7 @@ LcdInitialize (
return EFI_SUCCESS;
}
-/** Set ARM Mali DP in cofiguration mode.
+/** Set ARM Mali DP in configuration mode.
The ARM Mali DP must be in the configuration mode for
configuration of the H_INTERVALS, V_INTERVALS, SYNC_CONTROL
diff --git a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c
index 07f9b0f6be..f0658b40dc 100644
--- a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c
+++ b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c
@@ -19,7 +19,7 @@
@retval EFI_SUCCESS Returns success if platform implements a
PL111 controller.
- @retval EFI_NOT_FOUND PL111 display controller not found the plaform.
+ @retval EFI_NOT_FOUND PL111 display controller not found the platform.
**/
EFI_STATUS
LcdIdentify (
@@ -73,7 +73,7 @@ LcdInitialize (
@param[in] ModeNumbe Display mode number.
- @retval EFI_SUCCESS Display mode set successfuly.
+ @retval EFI_SUCCESS Display mode set successfully.
@retval !(EFI_SUCCESS) Other errors.
**/
EFI_STATUS
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 3/3] ArmVirtPkg: Fix typos
2022-12-02 9:25 [PATCH 0/3] Fix some typos Dongdong Zhang
2022-12-02 9:25 ` [PATCH 1/3] ArmPkg: Fix typos Dongdong Zhang
2022-12-02 9:25 ` [PATCH 2/3] ArmPlatformPkg: " Dongdong Zhang
@ 2022-12-02 9:25 ` Dongdong Zhang
2022-12-12 14:58 ` [edk2-devel] [PATCH 0/3] Fix some typos Michael Kubacki
3 siblings, 0 replies; 8+ messages in thread
From: Dongdong Zhang @ 2022-12-02 9:25 UTC (permalink / raw)
To: devel; +Cc: zhuwenjun, zhengyu, jinyanjiang, Dongdong Zhang
Fix some typos in ArmVirtPkg directory.
Signed-off-by: Dongdong Zhang <zhangdongdong@eswincomputing.com>
---
ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
.../Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c | 2 +-
ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index 462073517a..f1aa51c896 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -93,7 +93,7 @@
#
# It is not possible to prevent the ARM compiler from inserting calls to intrinsic functions.
- # This library provides the instrinsic functions such a compiler may generate calls to.
+ # This library provides the intrinsic functions such a compiler may generate calls to.
#
NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
diff --git a/ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c b/ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c
index 28a0c0b078..107ebbf3cd 100644
--- a/ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c
+++ b/ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c
@@ -103,7 +103,7 @@ CloudHvVirtMemInfoPeiLibConstructor (
CurBase + CurSize - 1
));
- // We should build Hob seperately for the memory node except the first one
+ // We should build Hob separately for the memory node except the first one
if (CurBase != MemBase) {
BuildResourceDescriptorHob (
EFI_RESOURCE_SYSTEM_MEMORY,
diff --git a/ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c b/ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c
index 9cf43f06c0..464e7a6d04 100644
--- a/ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c
+++ b/ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c
@@ -27,7 +27,7 @@
#define MACH_VIRT_PERIPH_SIZE SIZE_128MB
/**
- Default library constructur that obtains the memory size from a PCD.
+ Default library constructor that obtains the memory size from a PCD.
@return Always returns RETURN_SUCCESS
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [edk2-devel] [PATCH 0/3] Fix some typos
2022-12-02 9:25 [PATCH 0/3] Fix some typos Dongdong Zhang
` (2 preceding siblings ...)
2022-12-02 9:25 ` [PATCH 3/3] ArmVirtPkg: " Dongdong Zhang
@ 2022-12-12 14:58 ` Michael Kubacki
2022-12-13 1:32 ` Dongdong Zhang
3 siblings, 1 reply; 8+ messages in thread
From: Michael Kubacki @ 2022-12-12 14:58 UTC (permalink / raw)
To: devel, zhangdongdong; +Cc: zhuwenjun, zhengyu, jinyanjiang
Hello,
I sent a similar series a few months ago:
https://github.com/tianocore/edk2/pull/2903
At the time, there was not much interest in fixing these in edk2. But I
would still like to get the changes in.
Are you running the spell check CI plugin?
In order to reduce the number of spelling related fixes, do you think we
could merge our changes?
Thanks,
Michael
On 12/2/2022 4:25 AM, Dongdong Zhang wrote:
> Hi all,
>
> My focus was fixing typos in comments. Most of them
> were found by spellchecker.
>
> There are many similar spelling mistakes, so to avoid involving
> too many modules at once, only the files in the 'ArmPkg',
> 'ArmPlatformPkg' and 'ArmVirtPkg' directories were modified this time.
>
> Dongdong Zhang (3):
> ArmPkg: Fix typos
> ArmPlatformPkg: Fix typos
> ArmVirtPkg: Fix typos
>
> ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c | 2 +-
> ArmPkg/Include/Library/OemMiscLib.h | 2 +-
> ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c | 6 +++---
> ArmPkg/Library/ArmLib/AArch64/ArmLibSupport.S | 2 +-
> ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S | 2 +-
> ArmPkg/Library/SemihostLib/Arm/GccSemihost.S | 2 +-
> ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 6 +++---
> ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 2 +-
> .../Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | 2 +-
> ArmPlatformPkg/ArmPlatformPkg.dec | 2 +-
> ArmPlatformPkg/Include/Library/LcdPlatformLib.h | 2 +-
> ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c | 2 +-
> ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 4 ++--
> ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
> .../Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c | 2 +-
> ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c | 2 +-
> 16 files changed, 21 insertions(+), 21 deletions(-)
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [edk2-devel] [PATCH 0/3] Fix some typos
2022-12-12 14:58 ` [edk2-devel] [PATCH 0/3] Fix some typos Michael Kubacki
@ 2022-12-13 1:32 ` Dongdong Zhang
2022-12-14 3:13 ` Michael Kubacki
0 siblings, 1 reply; 8+ messages in thread
From: Dongdong Zhang @ 2022-12-13 1:32 UTC (permalink / raw)
To: Michael Kubacki; +Cc: devel, zhuwenjun, zhengyu, jinyanjiang
Hi,Michael
Sorry, I didn't notice your similar commit.
I am using codespell to check.
In order to avoid similar commits,
I feel it is necessary to merge your previous patch.
Thanks,
Dongdong
> -----原始邮件-----发件人:"Michael Kubacki" <mikuback@linux.microsoft.com>发送时间:2022-12-12 22:58:37 (星期一)收件人:devel@edk2.groups.io, zhangdongdong@eswincomputing.com抄送:zhuwenjun@eswincomputing.com, zhengyu@eswincomputing.com, jinyanjiang@eswincomputing.com主题:Re: [edk2-devel] [PATCH 0/3] Fix some typos
>
> Hello,
>
> I sent a similar series a few months ago:
> https://github.com/tianocore/edk2/pull/2903
>
> At the time, there was not much interest in fixing these in edk2. But I
> would still like to get the changes in.
>
> Are you running the spell check CI plugin?
>
> In order to reduce the number of spelling related fixes, do you think we
> could merge our changes?
>
> Thanks,
> Michael
>
> On 12/2/2022 4:25 AM, Dongdong Zhang wrote:
> > Hi all,
> >
> > My focus was fixing typos in comments. Most of them
> > were found by spellchecker.
> >
> > There are many similar spelling mistakes, so to avoid involving
> > too many modules at once, only the files in the 'ArmPkg',
> > 'ArmPlatformPkg' and 'ArmVirtPkg' directories were modified this time.
> >
> > Dongdong Zhang (3):
> > ArmPkg: Fix typos
> > ArmPlatformPkg: Fix typos
> > ArmVirtPkg: Fix typos
> >
> > ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c | 2 +-
> > ArmPkg/Include/Library/OemMiscLib.h | 2 +-
> > ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c | 6 +++---
> > ArmPkg/Library/ArmLib/AArch64/ArmLibSupport.S | 2 +-
> > ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S | 2 +-
> > ArmPkg/Library/SemihostLib/Arm/GccSemihost.S | 2 +-
> > ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 6 +++---
> > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 2 +-
> > .../Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | 2 +-
> > ArmPlatformPkg/ArmPlatformPkg.dec | 2 +-
> > ArmPlatformPkg/Include/Library/LcdPlatformLib.h | 2 +-
> > ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c | 2 +-
> > ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 4 ++--
> > ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
> > .../Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c | 2 +-
> > ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c | 2 +-
> > 16 files changed, 21 insertions(+), 21 deletions(-)
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH 0/3] Fix some typos
2022-12-13 1:32 ` Dongdong Zhang
@ 2022-12-14 3:13 ` Michael Kubacki
2022-12-14 8:18 ` Dongdong Zhang
0 siblings, 1 reply; 8+ messages in thread
From: Michael Kubacki @ 2022-12-14 3:13 UTC (permalink / raw)
To: devel, zhangdongdong; +Cc: zhuwenjun, zhengyu, jinyanjiang
Hi Dongdong,
I rebased my series and placed your three commits on top. Any changes
that were already addressed in my series were resolved and removed from
yours.
I added maintainer CC's to your patches so the maintainers will be
notified of the patches if they have email rules set up for that.
Here's the branch:
https://github.com/makubacki/edk2/commits/fix_new_spelling_errors
The PR is updated as well:
https://github.com/tianocore/edk2/pull/2903
The main purpose of my changes were originally to allow edk2 to upgrade
the spell checker used in the build process to a newer version. The
changes fix issues only reported in the new version.
I investigated automating corrections for all spelling issues (not just
those for new spell checker version to work) and the changes became
very, very large.
So I'm beginning to think I will just try to get this series in for now
since it's already taken some time to get it reviewed and then we can
deal with those later (our CI ignores those issues at the moment).
Can you please review my branch above and confirm that you are okay for
me to send a new patch series with your commits included?
Thanks,
Michael
On 12/12/2022 8:32 PM, Dongdong Zhang wrote:
> Hi,Michael
>
> Sorry, I didn't notice your similar commit.
> I am using codespell to check.
> In order to avoid similar commits,
> I feel it is necessary to merge your previous patch.
>
>
> Thanks,
> Dongdong
>
>> -----原始邮件-----发件人:"Michael Kubacki" <mikuback@linux.microsoft.com>发送时间:2022-12-12 22:58:37 (星期一)收件人:devel@edk2.groups.io, zhangdongdong@eswincomputing.com抄送:zhuwenjun@eswincomputing.com, zhengyu@eswincomputing.com, jinyanjiang@eswincomputing.com主题:Re: [edk2-devel] [PATCH 0/3] Fix some typos
>>
>> Hello,
>>
>> I sent a similar series a few months ago:
>> https://github.com/tianocore/edk2/pull/2903
>>
>> At the time, there was not much interest in fixing these in edk2. But I
>> would still like to get the changes in.
>>
>> Are you running the spell check CI plugin?
>>
>> In order to reduce the number of spelling related fixes, do you think we
>> could merge our changes?
>>
>> Thanks,
>> Michael
>>
>> On 12/2/2022 4:25 AM, Dongdong Zhang wrote:
>>> Hi all,
>>>
>>> My focus was fixing typos in comments. Most of them
>>> were found by spellchecker.
>>>
>>> There are many similar spelling mistakes, so to avoid involving
>>> too many modules at once, only the files in the 'ArmPkg',
>>> 'ArmPlatformPkg' and 'ArmVirtPkg' directories were modified this time.
>>>
>>> Dongdong Zhang (3):
>>> ArmPkg: Fix typos
>>> ArmPlatformPkg: Fix typos
>>> ArmVirtPkg: Fix typos
>>>
>>> ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c | 2 +-
>>> ArmPkg/Include/Library/OemMiscLib.h | 2 +-
>>> ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c | 6 +++---
>>> ArmPkg/Library/ArmLib/AArch64/ArmLibSupport.S | 2 +-
>>> ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S | 2 +-
>>> ArmPkg/Library/SemihostLib/Arm/GccSemihost.S | 2 +-
>>> ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 6 +++---
>>> ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 2 +-
>>> .../Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | 2 +-
>>> ArmPlatformPkg/ArmPlatformPkg.dec | 2 +-
>>> ArmPlatformPkg/Include/Library/LcdPlatformLib.h | 2 +-
>>> ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c | 2 +-
>>> ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 4 ++--
>>> ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
>>> .../Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c | 2 +-
>>> ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c | 2 +-
>>> 16 files changed, 21 insertions(+), 21 deletions(-)
>>>
>
>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH 0/3] Fix some typos
2022-12-14 3:13 ` Michael Kubacki
@ 2022-12-14 8:18 ` Dongdong Zhang
0 siblings, 0 replies; 8+ messages in thread
From: Dongdong Zhang @ 2022-12-14 8:18 UTC (permalink / raw)
To: Michael Kubacki; +Cc: devel, zhuwenjun, zhengyu, jinyanjiang
Hi Michael,
Thanks for your submission,
I just reviewed your edit and I think it looks good to me.
Thanks,
Dongdong
> -----原始邮件-----发件人:"Michael Kubacki" <mikuback@linux.microsoft.com>发送时间:2022-12-14 11:13:27 (星期三)收件人:devel@edk2.groups.io, zhangdongdong@eswincomputing.com抄送:zhuwenjun@eswincomputing.com, zhengyu@eswincomputing.com, jinyanjiang@eswincomputing.com主题:Re: [edk2-devel] [PATCH 0/3] Fix some typos
>
> Hi Dongdong,
>
> I rebased my series and placed your three commits on top. Any changes
> that were already addressed in my series were resolved and removed from
> yours.
>
> I added maintainer CC's to your patches so the maintainers will be
> notified of the patches if they have email rules set up for that.
>
> Here's the branch:
>
> https://github.com/makubacki/edk2/commits/fix_new_spelling_errors
>
> The PR is updated as well:
>
> https://github.com/tianocore/edk2/pull/2903
>
> The main purpose of my changes were originally to allow edk2 to upgrade
> the spell checker used in the build process to a newer version. The
> changes fix issues only reported in the new version.
>
> I investigated automating corrections for all spelling issues (not just
> those for new spell checker version to work) and the changes became
> very, very large.
>
> So I'm beginning to think I will just try to get this series in for now
> since it's already taken some time to get it reviewed and then we can
> deal with those later (our CI ignores those issues at the moment).
>
> Can you please review my branch above and confirm that you are okay for
> me to send a new patch series with your commits included?
>
> Thanks,
> Michael
>
> On 12/12/2022 8:32 PM, Dongdong Zhang wrote:
> > Hi,Michael
> >
> > Sorry, I didn't notice your similar commit.
> > I am using codespell to check.
> > In order to avoid similar commits,
> > I feel it is necessary to merge your previous patch.
> >
> >
> > Thanks,
> > Dongdong
> >
> >> -----原始邮件-----发件人:"Michael Kubacki" <mikuback@linux.microsoft.com>发送时间:2022-12-12 22:58:37 (星期一)收件人:devel@edk2.groups.io, zhangdongdong@eswincomputing.com抄送:zhuwenjun@eswincomputing.com, zhengyu@eswincomputing.com, jinyanjiang@eswincomputing.com主题:Re: [edk2-devel] [PATCH 0/3] Fix some typos
> >>
> >> Hello,
> >>
> >> I sent a similar series a few months ago:
> >> https://github.com/tianocore/edk2/pull/2903
> >>
> >> At the time, there was not much interest in fixing these in edk2. But I
> >> would still like to get the changes in.
> >>
> >> Are you running the spell check CI plugin?
> >>
> >> In order to reduce the number of spelling related fixes, do you think we
> >> could merge our changes?
> >>
> >> Thanks,
> >> Michael
> >>
> >> On 12/2/2022 4:25 AM, Dongdong Zhang wrote:
> >>> Hi all,
> >>>
> >>> My focus was fixing typos in comments. Most of them
> >>> were found by spellchecker.
> >>>
> >>> There are many similar spelling mistakes, so to avoid involving
> >>> too many modules at once, only the files in the 'ArmPkg',
> >>> 'ArmPlatformPkg' and 'ArmVirtPkg' directories were modified this time.
> >>>
> >>> Dongdong Zhang (3):
> >>> ArmPkg: Fix typos
> >>> ArmPlatformPkg: Fix typos
> >>> ArmVirtPkg: Fix typos
> >>>
> >>> ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c | 2 +-
> >>> ArmPkg/Include/Library/OemMiscLib.h | 2 +-
> >>> ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c | 6 +++---
> >>> ArmPkg/Library/ArmLib/AArch64/ArmLibSupport.S | 2 +-
> >>> ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S | 2 +-
> >>> ArmPkg/Library/SemihostLib/Arm/GccSemihost.S | 2 +-
> >>> ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c | 6 +++---
> >>> ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 2 +-
> >>> .../Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | 2 +-
> >>> ArmPlatformPkg/ArmPlatformPkg.dec | 2 +-
> >>> ArmPlatformPkg/Include/Library/LcdPlatformLib.h | 2 +-
> >>> ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c | 2 +-
> >>> ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 4 ++--
> >>> ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
> >>> .../Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c | 2 +-
> >>> ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c | 2 +-
> >>> 16 files changed, 21 insertions(+), 21 deletions(-)
> >>>
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 8+ messages in thread