From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9C9AFD80056 for ; Fri, 19 Jan 2024 13:48:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MEHjLc57EDTraOxbgSTdZ8UYSgxebtVBEiyIlC7vBOg=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705672083; v=1; b=YcYznKItAUAFzVBJAFJpB1aig6ztOe3dK4+ESqoZIeYWY7qgbjbvq1JRSZOl335Q4/B0jwFG fQQfXOWgbJg1Mx31N/mSv4RP71NCa0Yy+hwMa5YFkk8/IP4YKJtsxSviDg3pV958ZK4rtOvncfb XOeJIbLzkYhIqyvo4iIGym1E= X-Received: by 127.0.0.2 with SMTP id ykbaYY7687511x0r9zG61D8n; Fri, 19 Jan 2024 05:48:03 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.22391.1705672082482418578 for ; Fri, 19 Jan 2024 05:48:02 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-228-s9m8hrDWPi-AV7SIcRyZkQ-1; Fri, 19 Jan 2024 08:47:58 -0500 X-MC-Unique: s9m8hrDWPi-AV7SIcRyZkQ-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 03B56185A786; Fri, 19 Jan 2024 13:47:58 +0000 (UTC) X-Received: from [10.39.192.76] (unknown [10.39.192.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 79B75200A2F4; Fri, 19 Jan 2024 13:47:56 +0000 (UTC) Message-ID: <39489c62-75b3-6280-a1df-ab96b837c7fb@redhat.com> Date: Fri, 19 Jan 2024 14:47:55 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg To: "Ni, Ray" , "devel@edk2.groups.io" , "lichao@loongson.cn" , Sunil V L Cc: "Kinney, Michael D" , Gerd Hoffmann , Abner Chang References: <542dcacf-9cf1-42ae-b308-8c8be24b3332@loongson.cn> <17AAAE0FD29564BB.7072@groups.io> <9a473c12-7a0c-4146-a4bf-23205ec03004@loongson.cn> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Ev9Fp5NmecA8pwYuSNDo8TCLx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=YcYznKIt; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 1/19/24 11:17, Ni, Ray wrote: > Chao, > >   > > In the plan A, CpuDxe.inf contains reference to > gUefiCpuPkgTokenSpaceGuid.PcdCpuExceptionVectorBaseAddress in [Pcd] > section. But I guess it’s only needed by LoongArch64. That’s why I > didn’t like the common-inf idea. > >   > > But after looking at the other INF changes, I changed my mind. I think > the common-inf looks good as the other INF files don’t have so much > difference between LoonArch and x86. > >   > > So, I am ok with plan A. Thanks for preparing both changes for review. > >   > > Mike, Laszlo, Gerd, Abner, any comments? I'm also OK with plan A. Thanks Laszlo > >   > >   > > Thanks, > > Ray > > *From:* Chao Li > *Sent:* Thursday, January 18, 2024 4:27 PM > *To:* Ni, Ray ; Sunil V L > *Cc:* devel@edk2.groups.io; Kinney, Michael D > ; Laszlo Ersek ; Gerd > Hoffmann ; Abner Chang > *Subject:* Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg > >   > > Hi Ray and Sunil, > > Sorry, I'm late, I have very busy these days. > > I created two PRs in my private repo. > > *Plan A:* > > Moved most of LoongArch libraries and drivers to current matching > folders, removed LoongArch private INF, adjusted common INF. > > URL: https://github.com/kilaterlee/edk2/pull/8 > > >   > > *Plan B:* > > Moved most of LoongArch libraries and drivers to current matching > folders, keeping to use LoongArch private INF. > > URL: https://github.com/kilaterlee/edk2/pull/9 > > >   > > After you reading these two PRs, let's discuss how to deal with INF. > > I prefer plan A, it is better to use the same INF for all ARCHs and have > only one INF per modules. I was discussed this plan with Ray and Abner, > but it was not allowed at the time. > >   > > Thanks, > Chao > > On 2024/1/16 08:59, Chao Li wrote: > > OK, let me finish this work tomorrow, I'm a little busy today. > > On 2024/1/15 16:11, Ni, Ray wrote: > > Yes. Fine to me. Thanks! > >   > > Thanks, > > Ray > > -----Original Message----- > > From: Sunil V L > > Sent: Monday, January 15, 2024 2:46 PM > > To: Chao Li > > Cc: devel@edk2.groups.io ; Ni, Ray ; Kinney, Michael D > > ; Laszlo Ersek ; Gerd > > Hoffmann > > Subject: Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg > >   > > On Mon, Jan 15, 2024 at 02:17:09PM +0800, Chao Li wrote: > > Ray and Sunil, > >   > > I plan send two example PRs to github to  show how to deal the INFs, one to > > adjust current INF, and another PR to move the libraris to the current > > folders. I hope after these two PRs are sent we can decide what to do with > > the INF. What do you think of this plan? > >   > >   > > Hi Chao, That's fine with me. > >   > > Thanks, > > Sunil > > Thanks, > > Chao > > On 2024/1/15 13:44, Ni, Ray wrote: > > That will be great! > >   > > Thanks, > > Ray > > -----Original Message----- > > From: Sunil V L > > Sent: Monday, January 15, 2024 12:44 PM > > To: Ni, Ray > > Cc:devel@edk2.groups.io;lichao@loongson.cn ; Kinney, Michael D > > ; Laszlo Ersek ; Gerd > > Hoffmann > > Subject: Re: RFC: Folder layout change in UefiCpuPkg > >   > > On Mon, Jan 15, 2024 at 01:13:03AM +0000, Ni, Ray wrote: > > Sunil, > > I am glad that you don't have concern about the direction. > >   > > "RiscV" is good to me. > >   > >   > > Thanks!, Ray. So, shall I send patches to reorganize this? > >   > > Thanks, > > Sunil > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114046): https://edk2.groups.io/g/devel/message/114046 Mute This Topic: https://groups.io/mt/103679850/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-