From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.51.1574184642377495536 for ; Tue, 19 Nov 2019 09:30:42 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iwIY1kmS; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574184641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3K6opMxOganbVKIahuIEoimtovzK2C5v1dyOPvNgT3M=; b=iwIY1kmS/TWvfKhu4iuOC8XXFPc9ZLOm9PzH3v3j+gsDrogvb59uGw0MMhi4GxjMP5dxuG sArq/n12Oqo2E/W2VJvImtUpoWAw3y34hmBP4lS75t7/7AKmF1NvFTJ7lwiWxJ+AKPCgf/ 7PLJ1RWo4sSmrARl6xBzRNyPbKjjfW4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-311-QvWzLSQqOZSILM1PxtPZqA-1; Tue, 19 Nov 2019 12:30:39 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 159701051E82; Tue, 19 Nov 2019 17:30:38 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-47.ams2.redhat.com [10.36.116.47]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0AF8729360; Tue, 19 Nov 2019 17:30:36 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Update the coding styles To: devel@edk2.groups.io, shenglei.zhang@intel.com Cc: Eric Dong , Ray Ni References: <20191114114644.5504-1-shenglei.zhang@intel.com> <20191114114644.5504-4-shenglei.zhang@intel.com> From: "Laszlo Ersek" Message-ID: <395ff476-7391-8e67-7559-c78acba35b03@redhat.com> Date: Tue, 19 Nov 2019 18:30:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191114114644.5504-4-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: QvWzLSQqOZSILM1PxtPZqA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/14/19 12:46, Zhang, Shenglei wrote: > From: Shenglei Zhang >=20 > In MpLib.c, remove the white space on a new line. > In PageTbl.c and PiSmmCpuDxeSmm.h, update the comment style. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Shenglei Zhang > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/Mp= InitLib/MpLib.c > index 49be5d5385d9..d32adf0780b7 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c > @@ -475,7 +475,7 @@ CollectProcessorCount ( > CpuPause (); > } > =20 > - =20 > + > // > // Enable x2APIC mode if > // 1. Number of CPU is greater than 255; or > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c b/UefiCpuPkg/PiSmmC= puDxeSmm/Ia32/PageTbl.c > index f891a811126f..2483f2ea849d 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c > @@ -342,7 +342,7 @@ RestoreCr2 ( > =20 > @retval TRUE Access to non-SMRAM is restricted. > @retval FALSE Access to non-SMRAM is not restricted. > -*/ > +**/ > BOOLEAN > IsRestrictedMemoryAccess ( > VOID > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c b/UefiCpuPkg/PiSmmCp= uDxeSmm/X64/PageTbl.c > index e5c4788c13d7..810985df20ae 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c > @@ -1275,7 +1275,7 @@ RestoreCr2 ( > =20 > @retval TRUE Access to non-SMRAM is restricted. > @retval FALSE Access to non-SMRAM is not restricted. > -*/ > +**/ > BOOLEAN > IsRestrictedMemoryAccess ( > VOID > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSm= mCpuDxeSmm/PiSmmCpuDxeSmm.h > index daf977f654b4..7e7c73f27f76 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > @@ -1455,7 +1455,7 @@ InitializeDataForMmMp ( > =20 > @retval TRUE Access to non-SMRAM is restricted. > @retval FALSE Access to non-SMRAM is not restricted. > -*/ > +**/ > BOOLEAN > IsRestrictedMemoryAccess ( > VOID >=20 Reviewed-by: Laszlo Ersek