MdeModulePkg/Bus/Sd/EmmcDxe: Too verbose debug print on read

MdeModulePkg/Bus/Sd/EmmcDxe: Too verbose debug print on read

[methavanitpong.pipat]

Hi,

My team is developing a board booting Linux from an on-board eMMC,
and we find that EmmcReadWrite() debug print is too verbose for INFO level. 

    // https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c#L904
    DEBUG ((EFI_D_INFO, "Emmc%a(): Part %d Lba ...

Is this an intended level?
I wonder if the level should be `DEBUG_BLKIO` instead. 


Thanks,
--
Pipat Methavanitpong
Software Developer, S-Project 3
Socionext Inc.

Re: MdeModulePkg/Bus/Sd/EmmcDxe: Too verbose debug print on read

[Ard Biesheuvel]

On 5 June 2018 at 13:45,  <methavanitpong.pipat@socionext.com> wrote:
> Hi,
>
> My team is developing a board booting Linux from an on-board eMMC,
> and we find that EmmcReadWrite() debug print is too verbose for INFO level.
>
>     // https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c#L904
>     DEBUG ((EFI_D_INFO, "Emmc%a(): Part %d Lba ...
>
> Is this an intended level?
> I wonder if the level should be `DEBUG_BLKIO` instead.
>

I agree. I noticed the same, when loading GRUB, kernel and initrd from
eMMC, a significant amount of time is spent in these debug prints

Re: MdeModulePkg/Bus/Sd/EmmcDxe: Too verbose debug print on read

[Zeng, Star]

I am ok with that, you can propose patch.


Thanks,
Star
-----Original Message-----
From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] 
Sent: Tuesday, June 5, 2018 8:15 PM
To: Pipat/メタワニットポン ピパット <methavanitpong.pipat@socionext.com>
Cc: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Dong, Eric <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: Re: [edk2] MdeModulePkg/Bus/Sd/EmmcDxe: Too verbose debug print on read

On 5 June 2018 at 13:45,  <methavanitpong.pipat@socionext.com> wrote:
> Hi,
>
> My team is developing a board booting Linux from an on-board eMMC, and 
> we find that EmmcReadWrite() debug print is too verbose for INFO level.
>
>     // https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c#L904
>     DEBUG ((EFI_D_INFO, "Emmc%a(): Part %d Lba ...
>
> Is this an intended level?
> I wonder if the level should be `DEBUG_BLKIO` instead.
>

I agree. I noticed the same, when loading GRUB, kernel and initrd from eMMC, a significant amount of time is spent in these debug prints