From: Pete Batard <pete@akeo.ie>
To: "Gao, Liming" <liming.gao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 1/1] BaseTools: Use VS2017 SDK path if defined and reorganize variables
Date: Thu, 16 Nov 2017 15:45:24 +0000 [thread overview]
Message-ID: <397a7f3e-6020-f088-75c4-6183f456f4e7@akeo.ie> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E17F40A@SHSMSX104.ccr.corp.intel.com>
On 2017.11.16 14:48, Gao, Liming wrote:
> I agree to separate HOST and ARCH. For this patch, I have minor comment on WINSDK10_BIN.
>
> DEFINE WINSDK10_BIN = ENV(WINSDK10_PREFIX)x86
> ==>
> DEFINE WINSDK10_BIN = ENV(WINSDK10_PREFIX)DEF(VS2017_HOST)
Good point. I agree that the SDK should use the VS2017_HOST definition too.
If that's okay with you, I'm going to wait 24 hours to give a chance for
people to comment, and then resubmit a v2 of your VS2017 patch series,
that includes my proposed modifications as well as the change above.
Regards,
/Pete
prev parent reply other threads:[~2017-11-16 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 13:21 [PATCH 0/1] Update for the 2017-10-18 VS2017 proposal Pete Batard
2017-11-16 13:21 ` [PATCH 1/1] BaseTools: Use VS2017 SDK path if defined and reorganize variables Pete Batard
2017-11-16 14:48 ` Gao, Liming
2017-11-16 15:45 ` Pete Batard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=397a7f3e-6020-f088-75c4-6183f456f4e7@akeo.ie \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox