From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:4010:c07::22c; helo=mail-lf0-x22c.google.com; envelope-from=pete@akeo.ie; receiver=edk2-devel@lists.01.org Received: from mail-lf0-x22c.google.com (mail-lf0-x22c.google.com [IPv6:2a00:1450:4010:c07::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D11522035A7A2 for ; Thu, 16 Nov 2017 07:41:18 -0800 (PST) Received: by mail-lf0-x22c.google.com with SMTP id m1so14727790lfj.9 for ; Thu, 16 Nov 2017 07:45:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=SABRYVLQra7anVKZ3cuRDa/5h/+Bu0pR4M7/PK0r1Xo=; b=f/2GMhLRZjQuSlmUFySfmvs5TLpGxEU3dkF9l+MfDdaOXthe1ip2ANXI+/a3Ol8wCt 1EZSgUvyNMdVnUMNTdotXowInVvnerkUNgb2ZYH4V1PcQtSJXo4chfJgx9t6GIUyQJhb oglNVntpivVNZyOWVbYtH+tKAV/0uzqTutHP6DsmeDvFTCIlYKvJSJtl4poh0M5kS9mC nPd5PPAapCkbejxk1HZskrbDef3ZaKpZSbHuFdk5hK4Mp2fcnhb19jq97a3YPMEGJq4M KSrTwDRVZxkaJ5e+IhxjQoIUjWHjmHZiIE3NN03uw12xI4tcGUSHetOuMvj7NJ02vEVv OtRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SABRYVLQra7anVKZ3cuRDa/5h/+Bu0pR4M7/PK0r1Xo=; b=Dj7YbROlXcBS8q1XuFwoWUz80jrojja5KaHrGzcfNkmf23HzTNf67fS/TXGmf0bWYA /EV6XEJGNDccKg2LXdDsjFfLkpYc/26R1cR3dfIpW6UhS15OqOs5fQV1z76u7CGDxXZ7 Bg+mG4+M8FDbAMbCVsBv0xqE+/jkCpS9kTqWmKqsjaxW8YHjGgTiKRDvCmr4EZEDcSdO X1DxPejbctzvHYC2LTBFAXR6X+d77MpiG8s760/M0DSir+Mvon4tbZDfhmh9sxAzhVg/ KXRfT0EnawTry+N7l2+1KuBVjOLUtofdsO1/COg0S5t49oiW2DC4TPhh3/Ha/Y0jl6H8 AeLw== X-Gm-Message-State: AJaThX7sVuXSY0dAFcFcYXz5n/BzNSGcmyrxcQDhjrZuluvJyuR5IJ+A eu51y3vf7JwnnkGNDxev93bkDFBr7Fo= X-Google-Smtp-Source: AGs4zMa2lGpwgdEa/Ugbg5E0Zv0h9TJwNcthJrubUWrbpaZjxloUFuBNf/zUH0Wu3v4C/5vUyHa+mg== X-Received: by 10.25.199.139 with SMTP id x133mr806153lff.87.1510847126392; Thu, 16 Nov 2017 07:45:26 -0800 (PST) Received: from [10.0.0.101] ([84.203.65.190]) by smtp.googlemail.com with ESMTPSA id l85sm352226lje.72.2017.11.16.07.45.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Nov 2017 07:45:25 -0800 (PST) To: "Gao, Liming" , "edk2-devel@lists.01.org" References: <20171116132110.11060-1-pete@akeo.ie> <20171116132110.11060-2-pete@akeo.ie> <4A89E2EF3DFEDB4C8BFDE51014F606A14E17F40A@SHSMSX104.ccr.corp.intel.com> From: Pete Batard Message-ID: <397a7f3e-6020-f088-75c4-6183f456f4e7@akeo.ie> Date: Thu, 16 Nov 2017 15:45:24 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E17F40A@SHSMSX104.ccr.corp.intel.com> Subject: Re: [PATCH 1/1] BaseTools: Use VS2017 SDK path if defined and reorganize variables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 15:41:19 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2017.11.16 14:48, Gao, Liming wrote: > I agree to separate HOST and ARCH. For this patch, I have minor comment on WINSDK10_BIN. > > DEFINE WINSDK10_BIN = ENV(WINSDK10_PREFIX)x86 > ==> > DEFINE WINSDK10_BIN = ENV(WINSDK10_PREFIX)DEF(VS2017_HOST) Good point. I agree that the SDK should use the VS2017_HOST definition too. If that's okay with you, I'm going to wait 24 hours to give a chance for people to comment, and then resubmit a v2 of your VS2017 patch series, that includes my proposed modifications as well as the change above. Regards, /Pete