From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C4E8E211B5A57 for ; Mon, 14 Jan 2019 17:33:30 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2019 17:33:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,479,1539673200"; d="scan'208";a="311838605" Received: from shzintpr02.sh.intel.com (HELO [10.253.24.32]) ([10.239.4.160]) by fmsmga005.fm.intel.com with ESMTP; 14 Jan 2019 17:33:29 -0800 To: Leif Lindholm Cc: edk2-devel@lists.01.org, star.zeng@intel.com References: <1547479196-40248-1-git-send-email-star.zeng@intel.com> <1547479196-40248-13-git-send-email-star.zeng@intel.com> <20190114221104.oudom6c7utyf6pb7@bivouac.eciton.net> From: "Zeng, Star" Message-ID: <397b0978-c67f-d511-cca4-476cc5bf3fa6@intel.com> Date: Tue, 15 Jan 2019 09:32:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190114221104.oudom6c7utyf6pb7@bivouac.eciton.net> Subject: Re: [PATCH V2 12/15] BeagleBoardPkg: Use merged variable driver for emulated NV mode X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 01:33:31 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2019/1/15 6:11, Leif Lindholm wrote: > Hi Star, > > This set looks like a good cleanup. Thanks. > > This patch also need an added resolution for SynchronizationLib. > (MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > should be fine.) Oh, yes. I assumed it has been there, but it is not. > > The same modification will also be needed in edk2-platforms for > Platform/Hisilicon/HiKey and HiKey960. Yes, I mentioned it in cover letter, that will be in a separated patch series later. Thanks, Star > > Regards, > > Leif > > On Mon, Jan 14, 2019 at 11:19:53PM +0800, Star Zeng wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 >> Merge EmuVariable and Real variable driver. >> >> The real variable driver has been updated to support emulated >> variable NV mode and the EmuVariableRuntimeDxe will be removed >> later, so use merged variable driver for emulated NV mode. >> >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Star Zeng >> --- >> BeagleBoardPkg/BeagleBoardPkg.dsc | 13 +++++++++++-- >> BeagleBoardPkg/BeagleBoardPkg.fdf | 4 ++-- >> 2 files changed, 13 insertions(+), 4 deletions(-) >> >> diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc >> index 6dabfa905ae9..479b1504825a 100644 >> --- a/BeagleBoardPkg/BeagleBoardPkg.dsc >> +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc >> @@ -2,7 +2,7 @@ >> # Beagle board package. >> # >> # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.
>> -# Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
>> +# Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
>> # Copyright (c) 2016, Linaro Ltd. All rights reserved.
>> # >> # This program and the accompanying materials >> @@ -137,6 +137,10 @@ [LibraryClasses.common] >> >> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >> >> + AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >> + TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf >> + VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >> + >> [LibraryClasses.common.SEC] >> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >> ReportStatusCodeLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf >> @@ -345,6 +349,11 @@ [PcdsFixedAtBuild.common] >> >> gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE >> >> + # >> + # Make VariableRuntimeDxe work at emulated non-volatile variable mode. >> + # >> + gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE >> + >> ################################################################################ >> # >> # Components Section - list of all EDK II Modules needed by this Platform >> @@ -376,7 +385,7 @@ [Components.common] >> MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf >> MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf >> MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf >> - MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf >> + MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf >> EmbeddedPkg/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter.inf >> >> MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf >> diff --git a/BeagleBoardPkg/BeagleBoardPkg.fdf b/BeagleBoardPkg/BeagleBoardPkg.fdf >> index 83d85fce4070..42d6bad0c73b 100644 >> --- a/BeagleBoardPkg/BeagleBoardPkg.fdf >> +++ b/BeagleBoardPkg/BeagleBoardPkg.fdf >> @@ -1,7 +1,7 @@ >> # FLASH layout file for Beagle board. >> # >> # Copyright (c) 2009, Apple Inc. All rights reserved.
>> -# Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
>> +# Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
>> # Copyright (c) 2016, Linaro, Ltd. All rights reserved.
>> # >> # This program and the accompanying materials >> @@ -106,7 +106,7 @@ [FV.FvMain] >> INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf >> INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf >> INF MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf >> - INF MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf >> + INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf >> INF EmbeddedPkg/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter.inf >> >> INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf >> -- >> 2.7.0.windows.1 >>