From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.7164.1586260171062934557 for ; Tue, 07 Apr 2020 04:49:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ivfRowE9; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586260170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LayAFWAK+ccLiA5Vqvf5OOrzK39bn+gzgOBHYXHaLT8=; b=ivfRowE99/HXMNc+3jA4ZxIZNLNz5uDY9f4i5e91+qvSxAEGWfZ/w2mWx0hMP2ZHlfe379 eJI+I26/U70FLcFQtgD3+M/j3hMxFAyqCko+IMjk3ZXTh+xlUslNcZDC9RunqSyhzU0SXc KZcWo2uMe9kpalJTGdJOzeBB9Vc0jFU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-BxXv9xjkPJ6NlyaRcGRccA-1; Tue, 07 Apr 2020 07:49:25 -0400 X-MC-Unique: BxXv9xjkPJ6NlyaRcGRccA-1 Received: by mail-wr1-f72.google.com with SMTP id g6so1619429wru.8 for ; Tue, 07 Apr 2020 04:49:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XvKtMtM/6wM+V4CdQX2hQL14v4glI5X/ekdhLHAl54o=; b=DkHqvwJX5TlfUXyb4hvz48HzmuqcFBeZQc72t9B8iuKNye08eYIxFqJUwGJrj84AvE 9Oectbbuvg4RUcXNL89tFmsNNdXXglvMIRwQxNyFD0Bd7qXkIy8QrPKEuVYtGzbI9Bz+ G+jz2lX696EMKJprx5wlVOzm6/gDvNenc+cG8lftP0ocokZbBqrqtA26ZXEZENJFvEV3 z/f2k5evB6c0SAIBgrWv2QXrS/tX/Sfwk6HO5pbgYrEQO5gVkoAYC4su8/jIDl2bg9SO UYHK1SiOjIOz45XsfVgIR96b90nTpWUnJy2DJ2GUDdosKP2Kpc9xQt5Ztg1cMm4LkGpb 3Qcw== X-Gm-Message-State: AGi0Puai1NEbKnLRJZaipiVcesQPDe+AT1n+KCkyBR+pdcv2rCmUQL9v JJwyN/1KYW/GASWOypPXFDjtZFeaFnYEfAoWGNSVHTWYRF+NA+aSWnv/Fl83U05eDIe0aoXrrbt s99YBFgkGZk+MKA== X-Received: by 2002:a1c:3105:: with SMTP id x5mr2105268wmx.51.1586260164106; Tue, 07 Apr 2020 04:49:24 -0700 (PDT) X-Google-Smtp-Source: APiQypLPO2wjgWVcT6Pnq5UgXAA5BsVwRsn6x5YH/a5Q4PYFbgDnwJxX/XNaRKF1Cz+nvl4S/rpypw== X-Received: by 2002:a1c:3105:: with SMTP id x5mr2105240wmx.51.1586260163795; Tue, 07 Apr 2020 04:49:23 -0700 (PDT) Return-Path: Received: from [192.168.1.39] (116.red-83-42-57.dynamicip.rima-tde.net. [83.42.57.116]) by smtp.gmail.com with ESMTPSA id b82sm2159145wmh.1.2020.04.07.04.49.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2020 04:49:22 -0700 (PDT) Subject: Re: [PATCH] OvmfPkg: supply missing lib class declarations in the DEC file To: Laszlo Ersek , edk2-devel-groups-io Cc: Ard Biesheuvel , Jordan Justen , Sean Brogan References: <20200407100545.25406-1-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <398096dd-79da-d85d-e66e-08080c091acc@redhat.com> Date: Tue, 7 Apr 2020 13:49:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200407100545.25406-1-lersek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 4/7/20 12:05 PM, Laszlo Ersek wrote: > List the header files in the OvmfPkg DEC file for the following lib > classes: >=20 > - MemEncryptSevLib (one instance: BaseMemEncryptSevLib) >=20 > - PlatformFvbLib (two instances: EmuVariableFvbLib, PlatformFvbLibNull) >=20 > - VirtioLib (one instance: VirtioLib) >=20 > - VirtioMmioDeviceLib (one instance: VirtioMmioDeviceLib) >=20 > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daud=C3=A9 > Cc: Sean Brogan > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2662 > Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daude > --- >=20 > Notes: > Repo: https://pagure.io/lersek/edk2.git > Branch: lib_classes_bz_2662 >=20 > OvmfPkg/OvmfPkg.dec | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) >=20 > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec > index eae4d5e7ab42..28030391cff2 100644 > --- a/OvmfPkg/OvmfPkg.dec > +++ b/OvmfPkg/OvmfPkg.dec > @@ -22,6 +22,10 @@ [LibraryClasses] > # > LoadLinuxLib|Include/Library/LoadLinuxLib.h > =20 > + ## @libraryclass Declares helper functions for Secure Encrypted > + # Virtualization (SEV) guests. > + MemEncryptSevLib|Include/Library/MemEncryptSevLib.h > + > ## @libraryclass Save and restore variables using a file > # > NvVarsFileLib|Include/Library/NvVarsFileLib.h > @@ -45,6 +49,9 @@ [LibraryClasses] > # return codes, to the UEFI console. > PlatformBmPrintScLib|Include/Library/PlatformBmPrintScLib.h > =20 > + ## @libraryclass Customize FVB2 protocol member functions for a plat= form. > + PlatformFvbLib|Include/Library/PlatformFvbLib.h > + > ## @libraryclass Access QEMU's firmware configuration interface > # > QemuFwCfgLib|Include/Library/QemuFwCfgLib.h > @@ -67,6 +74,13 @@ [LibraryClasses] > # > SerializeVariablesLib|Include/Library/SerializeVariablesLib.h > =20 > + ## @libraryclass Declares utility functions for virtio device driver= s. > + VirtioLib|Include/Library/VirtioLib.h > + > + ## @libraryclass Install Virtio Device Protocol instances on virtio-= mmio > + # transports. > + VirtioMmioDeviceLib|Include/Library/VirtioMmioDeviceLib.h > + > ## @libraryclass Invoke Xen hypercalls > # > XenHypercallLib|Include/Library/XenHypercallLib.h >=20