public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] OvmfPkg: supply missing lib class declarations in the DEC file
@ 2020-04-07 10:05 Laszlo Ersek
  2020-04-07 10:48 ` Ard Biesheuvel
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Laszlo Ersek @ 2020-04-07 10:05 UTC (permalink / raw)
  To: edk2-devel-groups-io
  Cc: Ard Biesheuvel, Jordan Justen, Philippe Mathieu-Daudé,
	Sean Brogan

List the header files in the OvmfPkg DEC file for the following lib
classes:

- MemEncryptSevLib (one instance: BaseMemEncryptSevLib)

- PlatformFvbLib (two instances: EmuVariableFvbLib, PlatformFvbLibNull)

- VirtioLib (one instance: VirtioLib)

- VirtioMmioDeviceLib (one instance: VirtioMmioDeviceLib)

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2662
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---

Notes:
    Repo:   https://pagure.io/lersek/edk2.git
    Branch: lib_classes_bz_2662

 OvmfPkg/OvmfPkg.dec | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
index eae4d5e7ab42..28030391cff2 100644
--- a/OvmfPkg/OvmfPkg.dec
+++ b/OvmfPkg/OvmfPkg.dec
@@ -22,6 +22,10 @@ [LibraryClasses]
   #
   LoadLinuxLib|Include/Library/LoadLinuxLib.h
 
+  ##  @libraryclass  Declares helper functions for Secure Encrypted
+  #                  Virtualization (SEV) guests.
+  MemEncryptSevLib|Include/Library/MemEncryptSevLib.h
+
   ##  @libraryclass  Save and restore variables using a file
   #
   NvVarsFileLib|Include/Library/NvVarsFileLib.h
@@ -45,6 +49,9 @@ [LibraryClasses]
   #                  return codes, to the UEFI console.
   PlatformBmPrintScLib|Include/Library/PlatformBmPrintScLib.h
 
+  ##  @libraryclass  Customize FVB2 protocol member functions for a platform.
+  PlatformFvbLib|Include/Library/PlatformFvbLib.h
+
   ##  @libraryclass  Access QEMU's firmware configuration interface
   #
   QemuFwCfgLib|Include/Library/QemuFwCfgLib.h
@@ -67,6 +74,13 @@ [LibraryClasses]
   #
   SerializeVariablesLib|Include/Library/SerializeVariablesLib.h
 
+  ##  @libraryclass  Declares utility functions for virtio device drivers.
+  VirtioLib|Include/Library/VirtioLib.h
+
+  ##  @libraryclass  Install Virtio Device Protocol instances on virtio-mmio
+  #                  transports.
+  VirtioMmioDeviceLib|Include/Library/VirtioMmioDeviceLib.h
+
   ##  @libraryclass  Invoke Xen hypercalls
   #
   XenHypercallLib|Include/Library/XenHypercallLib.h
-- 
2.19.1.3.g30247aa5d201


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] OvmfPkg: supply missing lib class declarations in the DEC file
  2020-04-07 10:05 [PATCH] OvmfPkg: supply missing lib class declarations in the DEC file Laszlo Ersek
@ 2020-04-07 10:48 ` Ard Biesheuvel
  2020-04-07 11:49 ` Philippe Mathieu-Daudé
  2020-04-08  9:34 ` [edk2-devel] " Laszlo Ersek
  2 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2020-04-07 10:48 UTC (permalink / raw)
  To: Laszlo Ersek, edk2-devel-groups-io
  Cc: Jordan Justen, Philippe Mathieu-Daudé, Sean Brogan

On 4/7/20 12:05 PM, Laszlo Ersek wrote:
> List the header files in the OvmfPkg DEC file for the following lib
> classes:
> 
> - MemEncryptSevLib (one instance: BaseMemEncryptSevLib)
> 
> - PlatformFvbLib (two instances: EmuVariableFvbLib, PlatformFvbLibNull)
> 
> - VirtioLib (one instance: VirtioLib)
> 
> - VirtioMmioDeviceLib (one instance: VirtioMmioDeviceLib)
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2662
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

> ---
> 
> Notes:
>      Repo:   https://pagure.io/lersek/edk2.git
>      Branch: lib_classes_bz_2662
> 
>   OvmfPkg/OvmfPkg.dec | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
> index eae4d5e7ab42..28030391cff2 100644
> --- a/OvmfPkg/OvmfPkg.dec
> +++ b/OvmfPkg/OvmfPkg.dec
> @@ -22,6 +22,10 @@ [LibraryClasses]
>     #
>     LoadLinuxLib|Include/Library/LoadLinuxLib.h
>   
> +  ##  @libraryclass  Declares helper functions for Secure Encrypted
> +  #                  Virtualization (SEV) guests.
> +  MemEncryptSevLib|Include/Library/MemEncryptSevLib.h
> +
>     ##  @libraryclass  Save and restore variables using a file
>     #
>     NvVarsFileLib|Include/Library/NvVarsFileLib.h
> @@ -45,6 +49,9 @@ [LibraryClasses]
>     #                  return codes, to the UEFI console.
>     PlatformBmPrintScLib|Include/Library/PlatformBmPrintScLib.h
>   
> +  ##  @libraryclass  Customize FVB2 protocol member functions for a platform.
> +  PlatformFvbLib|Include/Library/PlatformFvbLib.h
> +
>     ##  @libraryclass  Access QEMU's firmware configuration interface
>     #
>     QemuFwCfgLib|Include/Library/QemuFwCfgLib.h
> @@ -67,6 +74,13 @@ [LibraryClasses]
>     #
>     SerializeVariablesLib|Include/Library/SerializeVariablesLib.h
>   
> +  ##  @libraryclass  Declares utility functions for virtio device drivers.
> +  VirtioLib|Include/Library/VirtioLib.h
> +
> +  ##  @libraryclass  Install Virtio Device Protocol instances on virtio-mmio
> +  #                  transports.
> +  VirtioMmioDeviceLib|Include/Library/VirtioMmioDeviceLib.h
> +
>     ##  @libraryclass  Invoke Xen hypercalls
>     #
>     XenHypercallLib|Include/Library/XenHypercallLib.h
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] OvmfPkg: supply missing lib class declarations in the DEC file
  2020-04-07 10:05 [PATCH] OvmfPkg: supply missing lib class declarations in the DEC file Laszlo Ersek
  2020-04-07 10:48 ` Ard Biesheuvel
@ 2020-04-07 11:49 ` Philippe Mathieu-Daudé
  2020-04-08  9:34 ` [edk2-devel] " Laszlo Ersek
  2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-04-07 11:49 UTC (permalink / raw)
  To: Laszlo Ersek, edk2-devel-groups-io
  Cc: Ard Biesheuvel, Jordan Justen, Sean Brogan

On 4/7/20 12:05 PM, Laszlo Ersek wrote:
> List the header files in the OvmfPkg DEC file for the following lib
> classes:
> 
> - MemEncryptSevLib (one instance: BaseMemEncryptSevLib)
> 
> - PlatformFvbLib (two instances: EmuVariableFvbLib, PlatformFvbLibNull)
> 
> - VirtioLib (one instance: VirtioLib)
> 
> - VirtioMmioDeviceLib (one instance: VirtioMmioDeviceLib)
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2662
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

> ---
> 
> Notes:
>      Repo:   https://pagure.io/lersek/edk2.git
>      Branch: lib_classes_bz_2662
> 
>   OvmfPkg/OvmfPkg.dec | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
> index eae4d5e7ab42..28030391cff2 100644
> --- a/OvmfPkg/OvmfPkg.dec
> +++ b/OvmfPkg/OvmfPkg.dec
> @@ -22,6 +22,10 @@ [LibraryClasses]
>     #
>     LoadLinuxLib|Include/Library/LoadLinuxLib.h
>   
> +  ##  @libraryclass  Declares helper functions for Secure Encrypted
> +  #                  Virtualization (SEV) guests.
> +  MemEncryptSevLib|Include/Library/MemEncryptSevLib.h
> +
>     ##  @libraryclass  Save and restore variables using a file
>     #
>     NvVarsFileLib|Include/Library/NvVarsFileLib.h
> @@ -45,6 +49,9 @@ [LibraryClasses]
>     #                  return codes, to the UEFI console.
>     PlatformBmPrintScLib|Include/Library/PlatformBmPrintScLib.h
>   
> +  ##  @libraryclass  Customize FVB2 protocol member functions for a platform.
> +  PlatformFvbLib|Include/Library/PlatformFvbLib.h
> +
>     ##  @libraryclass  Access QEMU's firmware configuration interface
>     #
>     QemuFwCfgLib|Include/Library/QemuFwCfgLib.h
> @@ -67,6 +74,13 @@ [LibraryClasses]
>     #
>     SerializeVariablesLib|Include/Library/SerializeVariablesLib.h
>   
> +  ##  @libraryclass  Declares utility functions for virtio device drivers.
> +  VirtioLib|Include/Library/VirtioLib.h
> +
> +  ##  @libraryclass  Install Virtio Device Protocol instances on virtio-mmio
> +  #                  transports.
> +  VirtioMmioDeviceLib|Include/Library/VirtioMmioDeviceLib.h
> +
>     ##  @libraryclass  Invoke Xen hypercalls
>     #
>     XenHypercallLib|Include/Library/XenHypercallLib.h
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH] OvmfPkg: supply missing lib class declarations in the DEC file
  2020-04-07 10:05 [PATCH] OvmfPkg: supply missing lib class declarations in the DEC file Laszlo Ersek
  2020-04-07 10:48 ` Ard Biesheuvel
  2020-04-07 11:49 ` Philippe Mathieu-Daudé
@ 2020-04-08  9:34 ` Laszlo Ersek
  2 siblings, 0 replies; 4+ messages in thread
From: Laszlo Ersek @ 2020-04-08  9:34 UTC (permalink / raw)
  To: Ard Biesheuvel, Philippe Mathieu-Daudé, Sean Brogan
  Cc: edk2-devel-groups-io, Jordan Justen

On 04/07/20 12:05, Laszlo Ersek wrote:
> List the header files in the OvmfPkg DEC file for the following lib
> classes:
> 
> - MemEncryptSevLib (one instance: BaseMemEncryptSevLib)
> 
> - PlatformFvbLib (two instances: EmuVariableFvbLib, PlatformFvbLibNull)
> 
> - VirtioLib (one instance: VirtioLib)
> 
> - VirtioMmioDeviceLib (one instance: VirtioMmioDeviceLib)
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2662
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     Repo:   https://pagure.io/lersek/edk2.git
>     Branch: lib_classes_bz_2662
> 
>  OvmfPkg/OvmfPkg.dec | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
> index eae4d5e7ab42..28030391cff2 100644
> --- a/OvmfPkg/OvmfPkg.dec
> +++ b/OvmfPkg/OvmfPkg.dec
> @@ -22,6 +22,10 @@ [LibraryClasses]
>    #
>    LoadLinuxLib|Include/Library/LoadLinuxLib.h
>  
> +  ##  @libraryclass  Declares helper functions for Secure Encrypted
> +  #                  Virtualization (SEV) guests.
> +  MemEncryptSevLib|Include/Library/MemEncryptSevLib.h
> +
>    ##  @libraryclass  Save and restore variables using a file
>    #
>    NvVarsFileLib|Include/Library/NvVarsFileLib.h
> @@ -45,6 +49,9 @@ [LibraryClasses]
>    #                  return codes, to the UEFI console.
>    PlatformBmPrintScLib|Include/Library/PlatformBmPrintScLib.h
>  
> +  ##  @libraryclass  Customize FVB2 protocol member functions for a platform.
> +  PlatformFvbLib|Include/Library/PlatformFvbLib.h
> +
>    ##  @libraryclass  Access QEMU's firmware configuration interface
>    #
>    QemuFwCfgLib|Include/Library/QemuFwCfgLib.h
> @@ -67,6 +74,13 @@ [LibraryClasses]
>    #
>    SerializeVariablesLib|Include/Library/SerializeVariablesLib.h
>  
> +  ##  @libraryclass  Declares utility functions for virtio device drivers.
> +  VirtioLib|Include/Library/VirtioLib.h
> +
> +  ##  @libraryclass  Install Virtio Device Protocol instances on virtio-mmio
> +  #                  transports.
> +  VirtioMmioDeviceLib|Include/Library/VirtioMmioDeviceLib.h
> +
>    ##  @libraryclass  Invoke Xen hypercalls
>    #
>    XenHypercallLib|Include/Library/XenHypercallLib.h
> 

Merged as commit 7cfc48fe4f97, via
<https://github.com/tianocore/edk2/pull/511>.

Thanks!
Laszlo


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-04-08  9:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-07 10:05 [PATCH] OvmfPkg: supply missing lib class declarations in the DEC file Laszlo Ersek
2020-04-07 10:48 ` Ard Biesheuvel
2020-04-07 11:49 ` Philippe Mathieu-Daudé
2020-04-08  9:34 ` [edk2-devel] " Laszlo Ersek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox