From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web10.6512.1586256524792740595
 for <devel@edk2.groups.io>;
 Tue, 07 Apr 2020 03:48:45 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6CA7F31B;
	Tue,  7 Apr 2020 03:48:44 -0700 (PDT)
Received: from [192.168.1.81] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 310CC3F73D;
	Tue,  7 Apr 2020 03:48:42 -0700 (PDT)
Subject: Re: [PATCH] OvmfPkg: supply missing lib class declarations in the DEC file
To: Laszlo Ersek <lersek@redhat.com>,
 edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Jordan Justen <jordan.l.justen@intel.com>,
 =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@redhat.com>,
 Sean Brogan <sean.brogan@microsoft.com>
References: <20200407100545.25406-1-lersek@redhat.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <39963f69-bc24-ae95-515c-e348b4d7fdf8@arm.com>
Date: Tue, 7 Apr 2020 12:48:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200407100545.25406-1-lersek@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 4/7/20 12:05 PM, Laszlo Ersek wrote:
> List the header files in the OvmfPkg DEC file for the following lib
> classes:
>=20
> - MemEncryptSevLib (one instance: BaseMemEncryptSevLib)
>=20
> - PlatformFvbLib (two instances: EmuVariableFvbLib, PlatformFvbLibNull)
>=20
> - VirtioLib (one instance: VirtioLib)
>=20
> - VirtioMmioDeviceLib (one instance: VirtioMmioDeviceLib)
>=20
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Philippe Mathieu-Daud=C3=A9 <philmd@redhat.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2662
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

> ---
>=20
> Notes:
>      Repo:   https://pagure.io/lersek/edk2.git
>      Branch: lib_classes_bz_2662
>=20
>   OvmfPkg/OvmfPkg.dec | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>=20
> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
> index eae4d5e7ab42..28030391cff2 100644
> --- a/OvmfPkg/OvmfPkg.dec
> +++ b/OvmfPkg/OvmfPkg.dec
> @@ -22,6 +22,10 @@ [LibraryClasses]
>     #
>     LoadLinuxLib|Include/Library/LoadLinuxLib.h
>  =20
> +  ##  @libraryclass  Declares helper functions for Secure Encrypted
> +  #                  Virtualization (SEV) guests.
> +  MemEncryptSevLib|Include/Library/MemEncryptSevLib.h
> +
>     ##  @libraryclass  Save and restore variables using a file
>     #
>     NvVarsFileLib|Include/Library/NvVarsFileLib.h
> @@ -45,6 +49,9 @@ [LibraryClasses]
>     #                  return codes, to the UEFI console.
>     PlatformBmPrintScLib|Include/Library/PlatformBmPrintScLib.h
>  =20
> +  ##  @libraryclass  Customize FVB2 protocol member functions for a pl=
atform.
> +  PlatformFvbLib|Include/Library/PlatformFvbLib.h
> +
>     ##  @libraryclass  Access QEMU's firmware configuration interface
>     #
>     QemuFwCfgLib|Include/Library/QemuFwCfgLib.h
> @@ -67,6 +74,13 @@ [LibraryClasses]
>     #
>     SerializeVariablesLib|Include/Library/SerializeVariablesLib.h
>  =20
> +  ##  @libraryclass  Declares utility functions for virtio device driv=
ers.
> +  VirtioLib|Include/Library/VirtioLib.h
> +
> +  ##  @libraryclass  Install Virtio Device Protocol instances on virti=
o-mmio
> +  #                  transports.
> +  VirtioMmioDeviceLib|Include/Library/VirtioMmioDeviceLib.h
> +
>     ##  @libraryclass  Invoke Xen hypercalls
>     #
>     XenHypercallLib|Include/Library/XenHypercallLib.h
>=20