From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Fri, 20 Sep 2019 08:00:18 -0700 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DC2816B for ; Fri, 20 Sep 2019 15:00:17 +0000 (UTC) Received: by mail-wr1-f69.google.com with SMTP id z17so2403053wru.13 for ; Fri, 20 Sep 2019 08:00:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nx9lrwDIw5PvgUyqBlzdDXknRqME+MmvhsiZKMhmifw=; b=I+KJAO1kSf866u4RpBtMUkwd3DvEzDTHfwiuN/jmJuSA1N3j9h+c1qkQ9QQaNvBG4Z csdy1viT9cJ0CA8uipU/4dcO+KGj/FU9mj22+X1Y4mVrl5FY/WH1QEWSijtGwlkZ3hmh q+QwPsE8X71Pdglmd0ZparmVHdOR/vl06tSuff1eNyuR9g9o8w3CHK43XgiZHYk/jWSy vOTXaB+E+chd79DQcUx6R4fbWchpLO0KNB2yPHx69urZafKzcztd00SZ1CWqwv2ZHivD Id0R6ts9J/ZuUlqlAVdO2B+q10QVQIXsdcBOcHto+fCkrUujMDnOXDiExW6eWPfESNql 4I6A== X-Gm-Message-State: APjAAAXIzb5NJRcHDBi46ELqZrFKL+snZTYs4c8RrM0KY24BS8fuxgQV q1rES0jK5dlY/ptNdpPMt2F3wYJ0AK7ntXhofLt3qx7kBhJL1MaSKbSCfbyCXsUiDVJXp70jkZX etP9i/n2fYgnwpA== X-Received: by 2002:a7b:c108:: with SMTP id w8mr3960042wmi.8.1568991616236; Fri, 20 Sep 2019 08:00:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqwtfcnh1YBo3stBJjK2CddkJkArYjnP1wIcK2t8FAQB5anC207D/Eb+mHuQo9TdOlqgfZEFxg== X-Received: by 2002:a7b:c108:: with SMTP id w8mr3960032wmi.8.1568991616092; Fri, 20 Sep 2019 08:00:16 -0700 (PDT) Received: from [192.168.1.40] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id g138sm2887282wmg.29.2019.09.20.08.00.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Sep 2019 08:00:15 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 05/35] EmulatorPkg/DxeTimerLib: drop superfluous cast To: devel@edk2.groups.io, lersek@redhat.com Cc: Andrew Fish , Jordan Justen , Ray Ni References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-6-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <39a241be-62f5-b8ed-74fc-6a5f247ad3c5@redhat.com> Date: Fri, 20 Sep 2019 17:00:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190917194935.24322-6-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/17/19 9:49 PM, Laszlo Ersek wrote: > "gTimerEvent" has type EFI_EVENT already, drop the superfluous cast. > > Cc: Andrew Fish > Cc: Jordan Justen > Cc: Ray Ni > Signed-off-by: Laszlo Ersek > --- > > Notes: > build-tested only > > EmulatorPkg/Library/DxeTimerLib/DxeTimerLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/EmulatorPkg/Library/DxeTimerLib/DxeTimerLib.c b/EmulatorPkg/Library/DxeTimerLib/DxeTimerLib.c > index 14cae4214c66..6fb5d8f3aaea 100644 > --- a/EmulatorPkg/Library/DxeTimerLib/DxeTimerLib.c > +++ b/EmulatorPkg/Library/DxeTimerLib/DxeTimerLib.c > @@ -40,7 +40,7 @@ RegisterTimerArchProtocol ( > gTimerPeriod = MultU64x32 (gTimerPeriod, 100); > > if (gTimerEvent == NULL) { > - Status = gBS->CreateEvent (EVT_TIMER, 0, NULL, NULL, (VOID **)&gTimerEvent); > + Status = gBS->CreateEvent (EVT_TIMER, 0, NULL, NULL, &gTimerEvent); > ASSERT_EFI_ERROR (Status); > } > } > Reviewed-by: Philippe Mathieu-Daude