From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mx.groups.io with SMTP id smtpd.web11.7902.1688071004651870971 for ; Thu, 29 Jun 2023 13:36:44 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=PxKsF2ml; spf=pass (domain: gmail.com, ip: 209.85.214.175, mailfrom: kuqin12@gmail.com) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1b8033987baso6988335ad.0 for ; Thu, 29 Jun 2023 13:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688071003; x=1690663003; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cIyWCUEAnNxHJoMEmayriJpnXtCIdJlYVKRr5wd5JCc=; b=PxKsF2ml58iWLg41h75qKmLmGcg0/4yy6hUN1zNaWPhoZVDCIP3T9RVNJzxOv6j9kO x1hbgyYm1EVawjEj8nuzP0Tanp0yKgeHmgvYAL8zB49gA9+f0iKWyD/MT+Ewhft8dS/0 GSHHGVwul/kGNHOsGszofIzaVGutpna8ywfyh6BmqUT2B7mLOvhruUUCtgNstBZC2RvL /78rX20tNAEpOQpIZZZDqEuc8F38hWGNqDZIfUhMu/komn5cMjLedOhue9gBnTUS2gjl DI+ku0AzjZNyJxsyYHjC7MGlWDpL6GOX/4IEzqj6scy8IaC4bz/UoS+lf/AuTxYjdYYF nMTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688071003; x=1690663003; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cIyWCUEAnNxHJoMEmayriJpnXtCIdJlYVKRr5wd5JCc=; b=RBsYpCZOAZyKj2GmqYUS/7P9DN1f5kT89F8xCHsg0UPGfPnKP0CLeCmOrOnwiSFovu t5u4duPjmArhnflOAyRQO04Eg5xp5IBvYvJSFRrMWQ5ErFFLct8iYPWNyc0703+x2mg4 coUC8n7gQ2T7M7PRekrYJCpWHdAMTgl6f5y0MqPyqD7QrmBPmJQFNFdByXHOoenob5W1 c1qlGqDnQvCcApl104G8yRq6h9OGJZnoHEwC1hIRUZNqNMLiQH2ZDcy9RVS7syM3KfIh imogJ+ZQiSP+A2dqj4woPk7ylSmD2d+3GofPZ9oqI6Lbs4koBD29wjfwHE+AGpEBHRSx MMkA== X-Gm-Message-State: ABy/qLZoTNHaw2bfwBdddPy5qVBh3VbKGYMpl8YaWpM5xsz7YB434Cey m0FxEePdrUcEORQhoW6U2SYPAb0IhZs= X-Google-Smtp-Source: APBJJlHUZWIFlWmUpw5l3Gwib5EpEQjd/he3eBNiRW+pJu0a/OPYBXc5XZ1Ye3JveAn2/2xto3YfEA== X-Received: by 2002:a17:902:d4ca:b0:1b8:224f:e823 with SMTP id o10-20020a170902d4ca00b001b8224fe823mr1294954plg.7.1688071003520; Thu, 29 Jun 2023 13:36:43 -0700 (PDT) Return-Path: Received: from ?IPV6:2001:4898:d8:33:956:7e07:c1c3:d47a? ([2001:4898:80e8:0:8978:7e07:c1c3:d47a]) by smtp.gmail.com with ESMTPSA id e6-20020a170902cf4600b001b1c4d875f5sm9473927plg.44.2023.06.29.13.36.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jun 2023 13:36:43 -0700 (PDT) Message-ID: <39d07743-80f9-8595-1a33-db86a7f3323d@gmail.com> Date: Thu, 29 Jun 2023 13:36:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [edk2-devel] [PATCH v1 2/8] MdePkg/MdePkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg To: devel@edk2.groups.io, pierre.gondois@arm.com Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Jiewen Yao , Jian J Wang , Ard Biesheuvel , Sami Mujawar , Jose Marinho , Samer El-Haj-Mahmoud References: <20230509074042.1523428-1-pierre.gondois@arm.com> <20230509074042.1523428-3-pierre.gondois@arm.com> From: "Kun Qin" In-Reply-To: <20230509074042.1523428-3-pierre.gondois@arm.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit This patch seems to have some discrepancy between the title and content :) Can you please break this patch into 2, so that MdePkg change and SecurityPkg can be their own commit? Thanks, Kun On 5/9/2023 12:40 AM, PierreGondois wrote: > From: Pierre Gondois > > In order to use PcdCpuRngSupportedAlgorithm in the MdePkg in a > following patch and to avoid making the MdePkg dependent on another > package, move PcdCpuRngSupportedAlgorithm to the MdePkg. > > As the Pcf is only used for AARCH64, place it in an AARCH64 > specific sections. > > Signed-off-by: Pierre Gondois > --- > MdePkg/MdePkg.dec | 5 +++++ > SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf | 4 ++-- > SecurityPkg/SecurityPkg.dec | 2 -- > 3 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index d6c4179b2a48..0ecfad5795e4 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -2357,6 +2357,11 @@ [PcdsFixedAtBuild,PcdsPatchableInModule] > # @Prompt IPMI KCS Interface I/O Base Address > gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsIoBaseAddress|0xca2|UINT16|0x00000031 > > +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] > + ## GUID identifying the Rng algorithm implemented by CPU instruction. > + # @Prompt CPU Rng algorithm's GUID. > + gEfiMdePkgTokenSpaceGuid.PcdCpuRngSupportedAlgorithm|{0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00}|VOID*|0x00000032 > + > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > ## This value is used to set the base address of PCI express hierarchy. > # @Prompt PCI Express Base Address. > diff --git a/SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf b/SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf > index c8e0ee4ae5d9..d6c2d30195bf 100644 > --- a/SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf > +++ b/SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf > @@ -79,8 +79,8 @@ [Guids] > [Protocols] > gEfiRngProtocolGuid ## PRODUCES > > -[Pcd] > - gEfiSecurityPkgTokenSpaceGuid.PcdCpuRngSupportedAlgorithm ## CONSUMES > +[Pcd.AARCH64] > + gEfiMdePkgTokenSpaceGuid.PcdCpuRngSupportedAlgorithm ## CONSUMES > > [Depex] > TRUE > diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec > index 0a8042d63fe1..6bb02d58bdf0 100644 > --- a/SecurityPkg/SecurityPkg.dec > +++ b/SecurityPkg/SecurityPkg.dec > @@ -325,8 +325,6 @@ [PcdsFixedAtBuild, PcdsPatchableInModule] > gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeFvVerificationPass|0x0303100A|UINT32|0x00010030 > gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeFvVerificationFail|0x0303100B|UINT32|0x00010031 > > - gEfiSecurityPkgTokenSpaceGuid.PcdCpuRngSupportedAlgorithm|{0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00}|VOID*|0x00010032 > - > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > ## Image verification policy for OptionRom. Only following values are valid:

> # NOTE: Do NOT use 0x5 and 0x2 since it violates the UEFI specification and has been removed.