From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by mx.groups.io with SMTP id smtpd.web10.12364.1645719056247855886 for ; Thu, 24 Feb 2022 08:10:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=NoJs8H9i; spf=pass (domain: quicinc.com, ip: 199.106.114.39, mailfrom: quic_rcran@quicinc.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1645719056; x=1677255056; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=J+w8ePPtQHB0O+hL+WnxAIkpnhjmuE3Cua4G1YpoUyA=; b=NoJs8H9iT+RQ6oC/g6FqNTEHEOIeAz9pgvFvKA46OepaKBs6dNhYW5WH NCHjKWAVqDc5ueXiwZxAyn4nUA139NQrKL4cXodLQ/t/8J0WdsbnqBxMO QAAX02jU3+qSoh9eccXb2qgtO/l+5P8C6PrCx7RbGo19h6X2N8m2EItqW w=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-02.qualcomm.com with ESMTP; 24 Feb 2022 08:10:55 -0800 X-QCInternal: smtphost Received: from nasanex01b.na.qualcomm.com ([10.46.141.250]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 08:10:55 -0800 Received: from [10.110.101.24] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Thu, 24 Feb 2022 08:10:55 -0800 Message-ID: <39d2ee0a-f909-b355-7060-1c96be9bbe79@quicinc.com> Date: Thu, 24 Feb 2022 09:10:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [edk2-devel] [PATCH v3] MdeModulePkg: Correct high-memory use in NvmExpressDxe To: , CC: Ray Ni , Ard Biesheuvel , Leif Lindholm References: <20220224132929.2052626-1-quic_tpilar@quicinc.com> From: "Rebecca Cran" In-Reply-To: <20220224132929.2052626-1-quic_tpilar@quicinc.com> Return-Path: quic_rcran@quicinc.com X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 2/24/22 06:29, Tomas Pilar (tpilar) wrote: > + // > + // Enable 64-bit DMA support in the PCI layer. > + // > + Status = PciIo->Attributes ( > + PciIo, > + EfiPciIoAttributeOperationEnable, > + EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE, > + NULL > + ); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_WARN, "NvmeControllerInit: failed to enable 64-bit DMA (%r)\n", Status)); > + } > + The message should probably mention NvmExpressDriverBindingStart instead of NvmeControllerInit. -- Rebecca Cran