From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.groups.io with SMTP id smtpd.web12.284.1570566123582692829 for ; Tue, 08 Oct 2019 13:22:03 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 082013082E66; Tue, 8 Oct 2019 20:22:03 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-109.rdu2.redhat.com [10.10.120.109]) by smtp.corp.redhat.com (Postfix) with ESMTP id 267A8600CE; Tue, 8 Oct 2019 20:22:01 +0000 (UTC) Subject: Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions To: "Gao, Liming" , "devel@edk2.groups.io" , "afish@apple.com" References: <1569570395-11240-1-git-send-email-liming.gao@intel.com> <1569570395-11240-6-git-send-email-liming.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E5124C6@SHSMSX104.ccr.corp.intel.com> From: "Laszlo Ersek" Message-ID: <39dad92d-917a-c6a4-05ff-8e32afd05533@redhat.com> Date: Tue, 8 Oct 2019 22:22:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E5124C6@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 08 Oct 2019 20:22:03 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/08/19 16:47, Gao, Liming wrote: > [Liming] I verify GCC5 tool chain. I will verify GCC48/GCC49 and > XCODE5. >=20 > I don=E2=80=99t know the specific reason about __inline__. If there= is no > impact on >=20 > other GCC tool chain, I prefer to remove them. > [Liming] This seems the remaining clean up task. So, I prefer to remove > __inline__ if no impact on GCC tool chain. OK. Given your testing with GCC48, I'm fine. Thanks Laszlo