From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 63AF4780091 for ; Tue, 23 Jan 2024 04:40:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=RVY/1gWx979KRNHTLo+yBz9KM+szus8m38TEUE4rQHM=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1705984805; v=1; b=lOcyFLgJ52w6qR5UXg6Mo877447SGNSAopSRddTczGxyVzOQgw0iTGkKrT6PZx7z3Mz4Ck7l f96L3vLchKF/1QWUG+1aQm80C0tfgXQBDvs6sFaYlhBAzxPlJLCkvj1P3sOXK5qQHKQ0yh0dI5D tmjy2+aqEhH3wx/pcYVMO55o= X-Received: by 127.0.0.2 with SMTP id cwZLYY7687511xZn925Ad3yD; Mon, 22 Jan 2024 20:40:05 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.4559.1705984803746818430 for ; Mon, 22 Jan 2024 20:40:04 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8DxfesVQ69lUwIEAA--.15869S3; Tue, 23 Jan 2024 12:39:49 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Bx7c4PQ69lipcTAA--.22901S3; Tue, 23 Jan 2024 12:39:44 +0800 (CST) Message-ID: <39e2f9d7-d564-4911-aab6-4128e68ed81d@loongson.cn> Date: Tue, 23 Jan 2024 12:39:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg To: "Chang, Abner" , Laszlo Ersek , "Ni, Ray" , "devel@edk2.groups.io" , Sunil V L Cc: "Kinney, Michael D" , Gerd Hoffmann References: <542dcacf-9cf1-42ae-b308-8c8be24b3332@loongson.cn> <17AAAE0FD29564BB.7072@groups.io> <9a473c12-7a0c-4146-a4bf-23205ec03004@loongson.cn> <39489c62-75b3-6280-a1df-ab96b837c7fb@redhat.com> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8Bx7c4PQ69lipcTAA--.22901S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAFCGWuJ2AFDAAOsH X-Coremail-Antispam: 1Uk129KBj93XoW3Ar4furW7JF48WrWrZryUXFc_yoWxZryxpr 4akasIyry8JryIv3yvka4UZryFvFs5GFWDGan8Kw4FkF9xCw1UK34ftr48GryDCr95Kr15 tF4Y9w1ft3W5urXCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUyGb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67 AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1le2I262IYc4CY6c8I j28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAv7VC0I7IYx2IY67AKxVWUJVWUGw Av7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMx8G jcxK6IxK0xIIj40E5I8CrwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8Jw C20s026c02F40E14v26r106r1rMI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAF wI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjx v20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2 jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43 ZEXa7IU1NeOJUUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 54thXQDFV6loIsOpgCfsgbfYx7686176AA= Content-Type: multipart/alternative; boundary="------------5qjcjU4ybkXbUYhghwkuyh70" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=lOcyFLgJ; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------5qjcjU4ybkXbUYhghwkuyh70 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Abner, The ExceptionLib is different from other libs such as Mp and Timer. Since ExceptionLib can provide for 32-bit service for LoongArch32 in the future, 64-bit private files are located in LoongArch/LoongArch64/ and the 32-bit will be located in LoongArch/LoongArch32, although the 32-bit LoongArch is not upstream yet. Thanks, Chao On 2024/1/23 11:10, Chang, Abner wrote: > [AMD Official Use Only - General] > > HI all, > I have no problem with the plan A, except the folder structure under CpuExecptionHandlerLib. > It has a LoongArch folder that contains the common source files for LoongArch and LoongArch64 folder under LoongArch for 64-buite architecture. This folder structure is different from other lib such as MpInitLib and CpuTimerLib. > Do you have 32-bit LoongArch? If not for now, then you probably can move the files under LoongArch to LoongArch64. Len you can a consistent folder structure for LoongArch. > > Thanks > Abner > >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Friday, January 19, 2024 9:48 PM >> To: Ni, Ray;devel@edk2.groups.io;lichao@loongson.cn; >> Sunil V L >> Cc: Kinney, Michael D; Gerd Hoffmann >> ; Chang, Abner >> Subject: Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg >> >> Caution: This message originated from an External Source. Use proper caution >> when opening attachments, clicking links, or responding. >> >> >> On 1/19/24 11:17, Ni, Ray wrote: >>> Chao, >>> >>> >>> >>> In the plan A, CpuDxe.inf contains reference to >>> gUefiCpuPkgTokenSpaceGuid.PcdCpuExceptionVectorBaseAddress in [Pcd] >>> section. But I guess it’s only needed by LoongArch64. That’s why I >>> didn’t like the common-inf idea. >>> >>> >>> >>> But after looking at the other INF changes, I changed my mind. I think >>> the common-inf looks good as the other INF files don’t have so much >>> difference between LoonArch and x86. >>> >>> >>> >>> So, I am ok with plan A. Thanks for preparing both changes for review. >>> >>> >>> >>> Mike, Laszlo, Gerd, Abner, any comments? >> I'm also OK with plan A. >> >> Thanks >> Laszlo >> >>> >>> >>> >>> >>> Thanks, >>> >>> Ray >>> >>> *From:* Chao Li >>> *Sent:* Thursday, January 18, 2024 4:27 PM >>> *To:* Ni, Ray; Sunil V L >>> *Cc:*devel@edk2.groups.io; Kinney, Michael D >>> ; Laszlo Ersek; Gerd >>> Hoffmann; Abner Chang >>> *Subject:* Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg >>> >>> >>> >>> Hi Ray and Sunil, >>> >>> Sorry, I'm late, I have very busy these days. >>> >>> I created two PRs in my private repo. >>> >>> *Plan A:* >>> >>> Moved most of LoongArch libraries and drivers to current matching >>> folders, removed LoongArch private INF, adjusted common INF. >>> >>> URL:https://github.com/kilaterlee/edk2/pull/8 >>> >>> >>> >>> >>> *Plan B:* >>> >>> Moved most of LoongArch libraries and drivers to current matching >>> folders, keeping to use LoongArch private INF. >>> >>> URL:https://github.com/kilaterlee/edk2/pull/9 >>> >>> >>> >>> >>> After you reading these two PRs, let's discuss how to deal with INF. >>> >>> I prefer plan A, it is better to use the same INF for all ARCHs and have >>> only one INF per modules. I was discussed this plan with Ray and Abner, >>> but it was not allowed at the time. >>> >>> >>> >>> Thanks, >>> Chao >>> >>> On 2024/1/16 08:59, Chao Li wrote: >>> >>> OK, let me finish this work tomorrow, I'm a little busy today. >>> >>> On 2024/1/15 16:11, Ni, Ray wrote: >>> >>> Yes. Fine to me. Thanks! >>> >>> >>> >>> Thanks, >>> >>> Ray >>> >>> -----Original Message----- >>> >>> From: Sunil V L >> >>> Sent: Monday, January 15, 2024 2:46 PM >>> >>> To: Chao Li >>> >>> Cc:devel@edk2.groups.io ; Ni, Ray >> ; Kinney, Michael D >>> ; >> Laszlo Ersek ; Gerd >>> Hoffmann >>> >>> Subject: Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg >>> >>> >>> >>> On Mon, Jan 15, 2024 at 02:17:09PM +0800, Chao Li wrote: >>> >>> Ray and Sunil, >>> >>> >>> >>> I plan send two example PRs to github to show how to deal the >> INFs, one to >>> adjust current INF, and another PR to move the libraris to the current >>> >>> folders. I hope after these two PRs are sent we can decide what to do >> with >>> the INF. What do you think of this plan? >>> >>> >>> >>> >>> >>> Hi Chao, That's fine with me. >>> >>> >>> >>> Thanks, >>> >>> Sunil >>> >>> Thanks, >>> >>> Chao >>> >>> On 2024/1/15 13:44, Ni, Ray wrote: >>> >>> That will be great! >>> >>> >>> >>> Thanks, >>> >>> Ray >>> >>> -----Original Message----- >>> >>> From: Sunil V L >> >>> Sent: Monday, January 15, 2024 12:44 PM >>> >>> To: Ni, Ray >>> >>> Cc:devel@edk2.groups.io;lichao@loongson.cn >> ; Kinney, Michael D >>> >> ; Laszlo Ersek >> ; Gerd >>> Hoffmann >>> >>> Subject: Re: RFC: Folder layout change in UefiCpuPkg >>> >>> >>> >>> On Mon, Jan 15, 2024 at 01:13:03AM +0000, Ni, Ray wrote: >>> >>> Sunil, >>> >>> I am glad that you don't have concern about the direction. >>> >>> >>> >>> "RiscV" is good to me. >>> >>> >>> >>> >>> >>> Thanks!, Ray. So, shall I send patches to reorganize this? >>> >>> >>> >>> Thanks, >>> >>> Sunil >>> >>> >>> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114168): https://edk2.groups.io/g/devel/message/114168 Mute This Topic: https://groups.io/mt/103679850/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------5qjcjU4ybkXbUYhghwkuyh70 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Abner,

The ExceptionLib is different from other libs such as Mp and Timer. Since ExceptionLib can provide for 32-bit service for LoongArch32 in the future, 64-bit private files are located in LoongArch/LoongArch64/ and the 32-bit will be located in LoongArch/LoongArch32, although the 32-bit LoongArch is not upstream yet.


Thanks,
Chao
On 2024/1/23 11:10, Chang, Abner wrote:
[AMD Official Use Only - General]

HI all,
I have no problem with the plan A, except the folder structure under CpuExecptionHandlerLib.
It has a LoongArch folder that contains the common source files for LoongArch and LoongArch64 folder under LoongArch for 64-buite architecture. This folder structure is different from other lib such as MpInitLib and CpuTimerLib.
Do you have 32-bit LoongArch? If not for now, then you probably can move the files under LoongArch to LoongArch64. Len you can a consistent folder structure for LoongArch.

Thanks
Abner


-----Original Message-----
From: Laszlo Ersek <lersek@redhat.com>
Sent: Friday, January 19, 2024 9:48 PM
To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; lichao@loongson.cn;
Sunil V L <sunilvl@ventanamicro.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gerd Hoffmann
<kraxel@redhat.com>; Chang, Abner <Abner.Chang@amd.com>
Subject: Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg

Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.


On 1/19/24 11:17, Ni, Ray wrote:

Chao,



In the plan A, CpuDxe.inf contains reference to
gUefiCpuPkgTokenSpaceGuid.PcdCpuExceptionVectorBaseAddress in [Pcd]
section. But I guess it’s only needed by LoongArch64. That’s why I
didn’t like the common-inf idea.



But after looking at the other INF changes, I changed my mind. I think
the common-inf looks good as the other INF files don’t have so much
difference between LoonArch and x86.



So, I am ok with plan A. Thanks for preparing both changes for review.



Mike, Laszlo, Gerd, Abner, any comments?

I'm also OK with plan A.

Thanks
Laszlo






Thanks,

Ray

*From:* Chao Li <lichao@loongson.cn>
*Sent:* Thursday, January 18, 2024 4:27 PM
*To:* Ni, Ray <ray.ni@intel.com>; Sunil V L <sunilvl@ventanamicro.com>
*Cc:* devel@edk2.groups.io; Kinney, Michael D
<michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>; Gerd
Hoffmann <kraxel@redhat.com>; Abner Chang <abner.chang@amd.com>
*Subject:* Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg



Hi Ray and Sunil,

Sorry, I'm late, I have very busy these days.

I created two PRs in my private repo.

*Plan A:*

Moved most of LoongArch libraries and drivers to current matching
folders, removed LoongArch private INF, adjusted common INF.

URL: https://github.com/kilaterlee/edk2/pull/8
<https://github.com/kilaterlee/edk2/pull/8>



*Plan B:*

Moved most of LoongArch libraries and drivers to current matching
folders, keeping to use LoongArch private INF.

URL: https://github.com/kilaterlee/edk2/pull/9
<https://github.com/kilaterlee/edk2/pull/9>



After you reading these two PRs, let's discuss how to deal with INF.

I prefer plan A, it is better to use the same INF for all ARCHs and have
only one INF per modules. I was discussed this plan with Ray and Abner,
but it was not allowed at the time.



Thanks,
Chao

On 2024/1/16 08:59, Chao Li wrote:

    OK, let me finish this work tomorrow, I'm a little busy today.

    On 2024/1/15 16:11, Ni, Ray wrote:

        Yes. Fine to me. Thanks!



        Thanks,

        Ray

            -----Original Message-----

            From: Sunil V L <sunilvl@ventanamicro.com>

<mailto:sunilvl@ventanamicro.com>

            Sent: Monday, January 15, 2024 2:46 PM

            To: Chao Li <lichao@loongson.cn> <mailto:lichao@loongson.cn>

            Cc: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Ni, Ray

<ray.ni@intel.com> <mailto:ray.ni@intel.com>; Kinney, Michael D

            <michael.d.kinney@intel.com> <mailto:michael.d.kinney@intel.com>;

Laszlo Ersek <lersek@redhat.com> <mailto:lersek@redhat.com>; Gerd

            Hoffmann <kraxel@redhat.com> <mailto:kraxel@redhat.com>

            Subject: Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg



            On Mon, Jan 15, 2024 at 02:17:09PM +0800, Chao Li wrote:

                Ray and Sunil,



                I plan send two example PRs to github to  show how to deal the

INFs, one to

                adjust current INF, and another PR to move the libraris to the current

                folders. I hope after these two PRs are sent we can decide what to do

with

                the INF. What do you think of this plan?





            Hi Chao, That's fine with me.



            Thanks,

            Sunil

                Thanks,

                Chao

                On 2024/1/15 13:44, Ni, Ray wrote:

                    That will be great!



                    Thanks,

                    Ray

                        -----Original Message-----

                        From: Sunil V L<sunilvl@ventanamicro.com>

<mailto:sunilvl@ventanamicro.com>

                        Sent: Monday, January 15, 2024 12:44 PM

                        To: Ni, Ray<ray.ni@intel.com> <mailto:ray.ni@intel.com>

                        Cc:devel@edk2.groups.io;lichao@loongson.cn

<mailto:Cc:devel@edk2.groups.io;lichao@loongson.cn>; Kinney, Michael D

                        <michael.d.kinney@intel.com>

<mailto:michael.d.kinney@intel.com>; Laszlo Ersek<lersek@redhat.com>
<mailto:lersek@redhat.com>; Gerd

                        Hoffmann<kraxel@redhat.com> <mailto:kraxel@redhat.com>
        

    

  




_._,_._,_





Groups.io Links:



  
    You receive all messages sent to this group.
  
  




View/Reply Online (#114168) |


  

|

  Mute This Topic


| New Topic







Your Subscription |
Contact Group Owner |

Unsubscribe

 [rebecca@openfw.io]


_._,_._,_



--------------5qjcjU4ybkXbUYhghwkuyh70--