Re: [PATCH] Maintainers.txt: Remove Nt32Pkg reference after Nt32Pkg is removed

["Laszlo Ersek" <lersek@redhat.com>]

On 05/17/19 06:57, Ray Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7315241b6e..de0b6a284e 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -1,4 +1,4 @@
> -EDK II Maintainers
> +EDK II Maintainers

I'm commenting after the push, but:

why was the above line changed?

More precisely: *how* was it changed? (The diff doesn't indicate.)

... A-ha! Looking at the pushed commit
147e6e70f2be2d3fdebcb2bd366324a24634d562, I can tell. You added a BOM to
the beginning to the file.

Please send a new patch soon, to delete the BOM. (It's a bugfix so it is
suitable for the soft feature freeze.)

Thanks
Laszlo

>  ==================
>  
>  This file provides information about the primary maintainers for
> @@ -185,11 +185,6 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg
>  M: Siyuan Fu <siyuan.fu@intel.com>
>  M: Jiaxin Wu <jiaxin.wu@intel.com>
>  
> -Nt32Pkg
> -W: https://github.com/tianocore/tianocore.github.io/wiki/Nt32Pkg
> -M: Ray Ni <ray.ni@intel.com>
> -M: Hao A Wu <hao.a.wu@intel.com>
> -
>  OvmfPkg
>  W: http://www.tianocore.org/ovmf/
>  M: Jordan Justen <jordan.l.justen@intel.com>
>