From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Fri, 17 May 2019 06:12:49 -0700
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id CC594C0A4F49;
	Fri, 17 May 2019 13:12:48 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-94.rdu2.redhat.com [10.10.120.94])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 451AB38E0E;
	Fri, 17 May 2019 13:12:46 +0000 (UTC)
Subject: Re: [PATCH] Maintainers.txt: Remove Nt32Pkg reference after Nt32Pkg is removed
To: Ray Ni <ray.ni@intel.com>, devel@edk2.groups.io
Cc: Liming Gao <liming.gao@intel.com>, Andrew Fish <afish@apple.com>,
 Leif Lindholm <leif.lindholm@linaro.org>,
 Michael D Kinney <michael.d.kinney@intel.com>
References: <20190517045735.81212-1-ray.ni@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <39ec6397-0261-710c-1e5a-097030f2a27f@redhat.com>
Date: Fri, 17 May 2019 15:12:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190517045735.81212-1-ray.ni@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 17 May 2019 13:12:48 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 05/17/19 06:57, Ray Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>=20
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7315241b6e..de0b6a284e 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -1,4 +1,4 @@
> -EDK II Maintainers
> +=EF=BB=BFEDK II Maintainers

I'm commenting after the push, but:

why was the above line changed?

More precisely: *how* was it changed? (The diff doesn't indicate.)

... A-ha! Looking at the pushed commit
147e6e70f2be2d3fdebcb2bd366324a24634d562, I can tell. You added a BOM to
the beginning to the file.

Please send a new patch soon, to delete the BOM. (It's a bugfix so it is
suitable for the soft feature freeze.)

Thanks
Laszlo

>  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =20
>  This file provides information about the primary maintainers for
> @@ -185,11 +185,6 @@ W: https://github.com/tianocore/tianocore.github.i=
o/wiki/NetworkPkg
>  M: Siyuan Fu <siyuan.fu@intel.com>
>  M: Jiaxin Wu <jiaxin.wu@intel.com>
> =20
> -Nt32Pkg
> -W: https://github.com/tianocore/tianocore.github.io/wiki/Nt32Pkg
> -M: Ray Ni <ray.ni@intel.com>
> -M: Hao A Wu <hao.a.wu@intel.com>
> -
>  OvmfPkg
>  W: http://www.tianocore.org/ovmf/
>  M: Jordan Justen <jordan.l.justen@intel.com>
>=20