From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: christian.rodriguez@intel.com)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by groups.io with SMTP; Tue, 28 May 2019 08:06:24 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
  by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 May 2019 08:06:23 -0700
X-ExtLoop1: 1
Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128])
  by orsmga008.jf.intel.com with ESMTP; 28 May 2019 08:06:23 -0700
Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by
 ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Tue, 28 May 2019 08:06:23 -0700
Received: from orsmsx112.amr.corp.intel.com ([169.254.3.79]) by
 ORSMSX116.amr.corp.intel.com ([169.254.7.165]) with mapi id 14.03.0415.000;
 Tue, 28 May 2019 08:06:22 -0700
From: "Christian Rodriguez" <christian.rodriguez@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Shi, Steven"
	<steven.shi@intel.com>
CC: "Gao, Liming" <liming.gao@intel.com>, "Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools:Fix the library dependency missing in Binary Cache
Thread-Topic: [edk2-devel] [PATCH] BaseTools:Fix the library dependency
 missing in Binary Cache
Thread-Index: AQHVFS1UnY9ulUeBQUGJQcSGYQX0eaaAonKg
Date: Tue, 28 May 2019 15:06:22 +0000
Message-ID: <3A7DCC9A944C6149BF832E1C9B718ABC01F24593@ORSMSX112.amr.corp.intel.com>
References: <20190528081340.14448-1-steven.shi@intel.com>
In-Reply-To: <20190528081340.14448-1-steven.shi@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_NT
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWM3ZmRhMzUtMTY4NC00YzA4LWIwNTQtZGQ1MTJlYTEwMmFiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSnVMazg5c2RiWHhBNDM1b1cxZno4M24xTlQyWTVQaG0yaU13TW5oOUowdkZpSlwvQk55K1AzU0lOU2RTXC9PanpxIn0=
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.22.254.138]
MIME-Version: 1.0
Return-Path: christian.rodriguez@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi Steven,

The problem isn't that the library dependency is missing. We are missing l=
ibrary artifacts and therefore cannot build the library. This can be fixed =
with a snippet of your next patch that adds the libraries artifacts, but wi=
thout the extra tracking information.

Thanks,
Christian

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Steven Shi
>Sent: Tuesday, May 28, 2019 1:14 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
><bob.c.feng@intel.com>; Rodriguez, Christian
><christian.rodriguez@intel.com>
>Subject: [edk2-devel] [PATCH] BaseTools:Fix the library dependency missin=
g
>in Binary Cache
>
>BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1788
>
>The library dependency of a module is wrongly filtered out by binary cach=
e
>implementation which cause all dependent libraries will not been built pr=
ior to
>the module in the build scheduler and the module build fails if cache mis=
s
>happen.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Cc: Christian Rodriguez <christian.rodriguez@intel.com>
>Signed-off-by: Steven Shi <steven.shi@intel.com>
>---
> BaseTools/Source/Python/build/build.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/build/build.py
>b/BaseTools/Source/Python/build/build.py
>index 80ceb98310..673a9379ba 100644
>--- a/BaseTools/Source/Python/build/build.py
>+++ b/BaseTools/Source/Python/build/build.py
>@@ -593,7 +593,7 @@ class BuildTask:
>     #
>     def AddDependency(self, Dependency):
>         for Dep in Dependency:
>-            if not Dep.BuildObject.IsBinaryModule and not
>Dep.BuildObject.CanSkipbyHash():
>+            if not Dep.BuildObject.IsBinaryModule:
>                 self.DependencyList.append(BuildTask.New(Dep))    # Buil=
dTask list
>
>     ## The thread wrapper of LaunchCommand function
>--
>2.17.1.windows.2
>
>
>