public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH] MdeModulePkg DxeCapsuleLibFmp: Free HandleBuffer after it is used
Date: Mon, 30 Jul 2018 22:32:55 +0000	[thread overview]
Message-ID: <3B808BB9-C2B2-4E4C-B04D-261A5404B9AD@intel.com> (raw)
In-Reply-To: <1532940835-29668-1-git-send-email-star.zeng@intel.com>

Reviewed-by: jiewen.yao@intel.com

thank you!
Yao, Jiewen


> 在 2018年7月30日,下午4:54,Zeng, Star <star.zeng@intel.com> 写道:
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 4 ++++
> 1 file changed, 4 insertions(+)
> 
> diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> index a1347b5ce67c..e88dab8c7642 100644
> --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> @@ -610,6 +610,8 @@ DumpAllFmpInfo (
>     FreePool(FmpImageInfoBuf);
>   }
> 
> +  FreePool (HandleBuffer);
> +
>   return ;
> }
> 
> @@ -741,6 +743,8 @@ GetFmpHandleBufferByType (
>     FreePool(FmpImageInfoBuf);
>   }
> 
> +  FreePool (HandleBuffer);
> +
>   if (MatchedNumberOfHandles == 0) {
>     return EFI_NOT_FOUND;
>   }
> -- 
> 2.7.0.windows.1
> 


      reply	other threads:[~2018-07-30 22:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30  8:53 [PATCH] MdeModulePkg DxeCapsuleLibFmp: Free HandleBuffer after it is used Star Zeng
2018-07-30 22:32 ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B808BB9-C2B2-4E4C-B04D-261A5404B9AD@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox