From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=jiewen.yao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EDDC6210C2780 for ; Mon, 30 Jul 2018 15:33:06 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2018 15:33:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,424,1526367600"; d="scan'208";a="61997539" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 30 Jul 2018 15:32:58 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 30 Jul 2018 15:32:58 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 30 Jul 2018 15:32:57 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.100]) with mapi id 14.03.0319.002; Tue, 31 Jul 2018 06:32:56 +0800 From: "Yao, Jiewen" To: "Zeng, Star" CC: "edk2-devel@lists.01.org" , "Kinney, Michael D" Thread-Topic: [PATCH] MdeModulePkg DxeCapsuleLibFmp: Free HandleBuffer after it is used Thread-Index: AQHUJ+LqR+3z5cX6HEq0ittqjPaXdaSoWr+T Date: Mon, 30 Jul 2018 22:32:55 +0000 Message-ID: <3B808BB9-C2B2-4E4C-B04D-261A5404B9AD@intel.com> References: <1532940835-29668-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1532940835-29668-1-git-send-email-star.zeng@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg DxeCapsuleLibFmp: Free HandleBuffer after it is used X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 22:33:07 -0000 Content-Language: zh-CN Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Reviewed-by: jiewen.yao@intel.com thank you! Yao, Jiewen > =1B$B:_=1B(B 2018=1B$BG/=1B(B7=1B$B7n=1B(B30=1B$BF|!$2<8a=1B(B4:54=1B$B!$= =1B(BZeng, Star =1B$B=20 > Cc: Jiewen Yao > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/MdeM= odulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c > index a1347b5ce67c..e88dab8c7642 100644 > --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c > +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c > @@ -610,6 +610,8 @@ DumpAllFmpInfo ( > FreePool(FmpImageInfoBuf); > } >=20 > + FreePool (HandleBuffer); > + > return ; > } >=20 > @@ -741,6 +743,8 @@ GetFmpHandleBufferByType ( > FreePool(FmpImageInfoBuf); > } >=20 > + FreePool (HandleBuffer); > + > if (MatchedNumberOfHandles =3D=3D 0) { > return EFI_NOT_FOUND; > } > --=20 > 2.7.0.windows.1 >=20