From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 17CA11A1E56 for ; Wed, 31 Aug 2016 18:08:47 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP; 31 Aug 2016 18:08:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,264,1470726000"; d="scan'208";a="3368397" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 31 Aug 2016 18:08:46 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 31 Aug 2016 18:08:46 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 31 Aug 2016 18:08:45 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.109]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.250]) with mapi id 14.03.0248.002; Thu, 1 Sep 2016 09:08:43 +0800 From: "Bi, Dandan" To: "Carsey, Jaben" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" Thread-Topic: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command Thread-Index: AQHSA0hcwGhQWeOV/k+UdX1dmNcO6qBiuAGAgAEYTwA= Date: Thu, 1 Sep 2016 01:08:42 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB39580124@shsmsx102.ccr.corp.intel.com> References: <1472621209-205768-1-git-send-email-dandan.bi@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Sep 2016 01:08:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Our codes have already checked for "too few " case, and it will print " Too= few arguments" in this situation. Thanks, Dandan -----Original Message----- From: Carsey, Jaben=20 Sent: Thursday, September 1, 2016 12:12 AM To: Bi, Dandan ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Carsey, Jaben Subject: RE: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bc= fg" command Should we check for too few also? What if the user sends 2 params? > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Dandan Bi > Sent: Tuesday, August 30, 2016 10:27 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben=20 > > Subject: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg= " > command > Importance: High >=20 > When user uses the command "bcfg driver|boot [dump [-v]]", the number=20 > of command line value parameters (doesn't include the > flag) must be three. We can add this point to check whether using this=20 > command correctly. >=20 > Cc: Ruiyu Ni > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | > 4 ++++ > ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.uni=20 > | > 3 ++- > 2 files changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > index 9baeecc..e2306bf 100644 > --- > a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > +++ > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > @@ -1294,10 +1294,14 @@ ShellCommandRunBcfg ( > if (ShellStatus =3D=3D SHELL_SUCCESS && CurrentOperation.Target < > BcfgTargetMax) { > for (ParamNumber =3D 2 ; ParamNumber < > ShellCommandLineGetCount(Package) && ShellStatus =3D=3D SHELL_SUCCESS; > ParamNumber++) { > CurrentParam =3D ShellCommandLineGetRawValue(Package, > ParamNumber); > if (gUnicodeCollation->StriColl(gUnicodeCollation, > (CHAR16*)CurrentParam, L"dump") =3D=3D 0) { > CurrentOperation.Type =3D BcfgTypeDump; > + if (ShellCommandLineGetCount(Package) > 3) { > + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN=20 > + (STR_GEN_TOO_MANY), > gShellBcfgHiiHandle, L"bcfg"); > + ShellStatus =3D SHELL_INVALID_PARAMETER; > + } > } else if (ShellCommandLineGetFlag(Package, L"-v")) { > ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN=20 > (STR_GEN_PARAM_INV), gShellBcfgHiiHandle, L"bcfg", L"-v (without dump)"); > ShellStatus =3D SHELL_INVALID_PARAMETER; > } else if (gUnicodeCollation->StriColl(gUnicodeCollation, > (CHAR16*)CurrentParam, L"add") =3D=3D 0) { > if ((ParamNumber + 3) >=3D ShellCommandLineGetCount(Package))= =20 > { diff --git=20 > a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.uni > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.uni > index 282494b..7668e49 100644 > --- > a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.uni > +++ > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.uni > @@ -1,9 +1,9 @@ > // /** > // > // (C) Copyright 2014-2015 Hewlett-Packard Development Company,=20 > L.P.
-// Copyright (c) 2010 - 2014, Intel Corporation. All rights=20 > reserved.
> +// Copyright (c) 2010 - 2016, Intel Corporation. All rights=20 > +reserved.
> // This program and the accompanying materials // are licensed and=20 > made available under the terms and conditions of the BSD License //=20 > which accompanies this distribution. The full text of the license may=20 > be found at // http://opensource.org/licenses/bsd-license.php > // > @@ -30,10 +30,11 @@ > #string STR_GEN_NO_VALUE #language en-US "%H%s%N: Missing > argument for flag - '%H%s%N'\r\n" > #string STR_GEN_PARAM_INV #language en-US "%H%s%N: Invalid > argument - '%H%s%N'\r\n" > #string STR_GEN_NO_DRIVER_BOOT #language en-US "%H%s%N: Driver > or Boot must be selected.\r\n" > #string STR_GEN_BOOT_ONLY #language en-US "%H%s%N: Boot must > be selected for hot key options.\r\n" > #string STR_GEN_TOO_FEW #language en-US "%H%s%N: Too few > arguments.\r\n" > +#string STR_GEN_TOO_MANY #language en-US "%H%s%N: Too many > arguments\r\n" > #string STR_GEN_FILE_OPEN_FAIL #language en-US "%H%s%N: Cannot > open file - '%H%s%N'\r\n" > #string STR_GEN_FIND_FAIL #language en-US "%H%s%N: File not foun= d > - '%H%s%N'\r\n" > #string STR_GEN_OUT_MEM #language en-US "%H%s%N: Memory > allocation was not successful.\r\n" > #string STR_BCFG_WRITE_FAIL #language en-US "%H%s%N: Unable to > write to '%H%s%N'\r\n" > #string STR_BCFG_READ_FAIL #language en-US "%H%s%N: Unable to > read from '%H%s%N'\r\n" > -- > 1.9.5.msysgit.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel