From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 18EBE1A1DFE for ; Tue, 20 Sep 2016 22:10:17 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 20 Sep 2016 22:10:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,372,1470726000"; d="scan'208";a="1034012418" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 20 Sep 2016 22:10:16 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Sep 2016 22:10:16 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Sep 2016 22:10:16 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.15]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.101]) with mapi id 14.03.0248.002; Wed, 21 Sep 2016 13:10:13 +0800 From: "Bi, Dandan" To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Dong, Eric" Thread-Topic: [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new EFI_HII_IIBT_IMAGE_PNG type Image Thread-Index: AQHSE7G87Sz0MrzABEWLLS3+7ei5yqCDZT8w Date: Wed, 21 Sep 2016 05:10:11 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3961C7DD@shsmsx102.ccr.corp.intel.com> References: <1474425551-9056-1-git-send-email-liming.gao@intel.com> <1474425551-9056-3-git-send-email-liming.gao@intel.com> In-Reply-To: <1474425551-9056-3-git-send-email-liming.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new EFI_HII_IIBT_IMAGE_PNG type Image X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 05:10:17 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Dandan Bi -----Original Message----- From: Gao, Liming=20 Sent: Wednesday, September 21, 2016 10:39 AM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Bi, Dandan Subject: [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new EFI_HII_IIBT_I= MAGE_PNG type Image HiiImage protocol implementation doesn't support EFI_HII_IIBT_IMAGE_PNG. Cc: Eric Dong Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdeModulePkg/Universal/HiiDatabaseDxe/Image.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/Image.c b/MdeModulePkg/U= niversal/HiiDatabaseDxe/Image.c index 612d57a..07b3ba0 100644 --- a/MdeModulePkg/Universal/HiiDatabaseDxe/Image.c +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/Image.c @@ -142,8 +142,9 @@ GetImageIdOrAddress ( break; =20 case EFI_HII_IIBT_IMAGE_JPEG: + case EFI_HII_IIBT_IMAGE_PNG: CopyMem (&Length32, ImageBlock + sizeof (EFI_HII_IMAGE_BLOCK), sizeo= f (UINT32)); - ImageBlock +=3D Length32; + ImageBlock +=3D OFFSET_OF (EFI_HII_IIBT_JPEG_BLOCK, Data) + Length32= ; ImageIdCurrent++; break; =20 @@ -895,6 +896,7 @@ HiiGetImage ( =20 switch (BlockType) { case EFI_HII_IIBT_IMAGE_JPEG: + case EFI_HII_IIBT_IMAGE_PNG: // // BUGBUG: need to be supported as soon as image tool is designed. // @@ -1096,6 +1098,7 @@ HiiSetImage ( // switch (BlockType) { case EFI_HII_IIBT_IMAGE_JPEG: + case EFI_HII_IIBT_IMAGE_PNG: // // BUGBUG: need to be supported as soon as image tool is designed. // @@ -1497,6 +1500,7 @@ HiiDrawImageId ( // // Get the specified Image. // + ZeroMem (&Image, sizeof (Image)); Status =3D HiiGetImage (This, PackageList, ImageId, &Image); if (EFI_ERROR (Status)) { return Status; --=20 2.8.0.windows.1