From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AC97A1A1F19 for ; Wed, 21 Sep 2016 18:10:27 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 21 Sep 2016 18:10:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,376,1470726000"; d="scan'208";a="1034454251" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 21 Sep 2016 18:10:16 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 21 Sep 2016 18:10:15 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 21 Sep 2016 18:10:14 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.15]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.118]) with mapi id 14.03.0248.002; Thu, 22 Sep 2016 09:10:13 +0800 From: "Bi, Dandan" To: Laszlo Ersek CC: "edk2-devel@ml01.01.org" , "Justen, Jordan L" , "Gao, Liming" Thread-Topic: [patch] OvmfPkg: Fix VS toolchain build failure Thread-Index: AQHSFG2j0d5T8FX/Oka0WorTF9DjpaCEsvBA Date: Thu, 22 Sep 2016 01:10:12 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3961DC6B@shsmsx102.ccr.corp.intel.com> References: <1474505679-81904-1-git-send-email-dandan.bi@intel.com> <6ed6d6fe-05bb-82dc-0ea5-c6aeeb83159d@redhat.com> In-Reply-To: <6ed6d6fe-05bb-82dc-0ea5-c6aeeb83159d@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] OvmfPkg: Fix VS toolchain build failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2016 01:10:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ok! Thank you for your comments! I will send patch with V2 for review.=20 Thanks, Dandan -----Original Message----- From: Laszlo Ersek [mailto:lersek@redhat.com]=20 Sent: Thursday, September 22, 2016 9:07 AM To: Bi, Dandan Cc: edk2-devel@ml01.01.org; Justen, Jordan L ; G= ao, Liming Subject: Re: [patch] OvmfPkg: Fix VS toolchain build failure On 09/22/16 02:54, Dandan Bi wrote: > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > OvmfPkg/VirtioGpuDxe/Commands.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/OvmfPkg/VirtioGpuDxe/Commands.c=20 > b/OvmfPkg/VirtioGpuDxe/Commands.c index b369dc3..53a94ac 100644 > --- a/OvmfPkg/VirtioGpuDxe/Commands.c > +++ b/OvmfPkg/VirtioGpuDxe/Commands.c > @@ -287,11 +287,11 @@ VirtioGpuSendCommand ( > =20 > // > // Compose the descriptor chain. > // > VirtioPrepare (&VgpuDev->Ring, &Indices); > - VirtioAppendDesc (&VgpuDev->Ring, (UINTN)Header, RequestSize, > + VirtioAppendDesc (&VgpuDev->Ring, (UINTN)Header,=20 > + (UINT32)RequestSize, > VRING_DESC_F_NEXT, &Indices); > VirtioAppendDesc (&VgpuDev->Ring, (UINTN)&Response, sizeof Response, > VRING_DESC_F_WRITE, &Indices); > =20 > // >=20 The patch is good, but I'd like to see another change: in the function, you= see ASSERT (RequestSize >=3D sizeof *Header); a little bit higher up. Right under that, please add: ASSERT (RequestSize <=3D MAX_UINT32); And then the cast is fine. Can you please send v2 with this addition? Thank you for addressing this compiler warning (and sorry about the inconve= nience with the VS build). Laszlo