From: "Bi, Dandan" <dandan.bi@intel.com>
To: "Wu, Jiaxin" <jiaxin.wu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Fu, Siyuan" <siyuan.fu@intel.com>
Subject: Re: [Patch] NetworkPkg: Coding style refine for IpSecDxe
Date: Thu, 20 Oct 2016 08:09:50 +0000 [thread overview]
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3963D184@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1476928171-19356-1-git-send-email-jiaxin.wu@intel.com>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Thanks,
Dandan
-----Original Message-----
From: Wu, Jiaxin
Sent: Thursday, October 20, 2016 9:50 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
Subject: [Patch] NetworkPkg: Coding style refine for IpSecDxe
Cc: Bi Dandan <dandan.bi@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
---
NetworkPkg/IpSecDxe/IkeCommon.c | 10 +++++----- NetworkPkg/IpSecDxe/IkeCommon.h | 10 +++++-----
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/NetworkPkg/IpSecDxe/IkeCommon.c b/NetworkPkg/IpSecDxe/IkeCommon.c index b1e4321..c5fbfab 100644
--- a/NetworkPkg/IpSecDxe/IkeCommon.c
+++ b/NetworkPkg/IpSecDxe/IkeCommon.c
@@ -199,22 +199,22 @@ IkePayloadFree (
}
/**
Generate an new SPI.
- @param[in] IkeSaSession Pointer to IKEV2_SA_SESSION related to this Child SA
- Session.
- @param[in out] SpiValue Pointer to the new generated SPI value.
+ @param[in] IkeSaSession Pointer to IKEV2_SA_SESSION related to this Child SA
+ Session.
+ @param[in, out] SpiValue Pointer to the new generated SPI value.
@retval EFI_SUCCESS The operation performs successfully.
@retval Otherwise The operation is failed.
**/
EFI_STATUS
IkeGenerateSpi (
- IN IKEV2_SA_SESSION *IkeSaSession,
- OUT UINT32 *SpiValue
+ IN IKEV2_SA_SESSION *IkeSaSession,
+ IN OUT UINT32 *SpiValue
)
{
EFI_STATUS Status;
Status = EFI_SUCCESS;
diff --git a/NetworkPkg/IpSecDxe/IkeCommon.h b/NetworkPkg/IpSecDxe/IkeCommon.h index 7f7fd4d..eb7e913 100644
--- a/NetworkPkg/IpSecDxe/IkeCommon.h
+++ b/NetworkPkg/IpSecDxe/IkeCommon.h
@@ -130,22 +130,22 @@ IkePayloadFree (
);
/**
Generate an new SPI.
- @param[in] IkeSaSession Pointer to IKEV2_SA_SESSION related to this Child SA
- Session.
- @param[in out] SpiValue Pointer to the new generated SPI value.
+ @param[in] IkeSaSession Pointer to IKEV2_SA_SESSION related to this Child SA
+ Session.
+ @param[in, out] SpiValue Pointer to the new generated SPI value.
@retval EFI_SUCCESS The operation performs successfully.
@retval Otherwise The operation is failed.
**/
EFI_STATUS
IkeGenerateSpi (
- IN IKEV2_SA_SESSION *IkeSaSession,
- OUT UINT32 *SpiValue
+ IN IKEV2_SA_SESSION *IkeSaSession,
+ IN OUT UINT32 *SpiValue
);
/**
Generate a random data for IV
--
1.9.5.msysgit.1
prev parent reply other threads:[~2016-10-20 8:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 1:49 [Patch] NetworkPkg: Coding style refine for IpSecDxe Jiaxin Wu
2016-10-20 8:09 ` Bi, Dandan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C0D5C461C9E904E8F62152F6274C0BB3963D184@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox